mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-23 07:50:15 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
50 lines
1.7 KiB
TypeScript
50 lines
1.7 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe(
|
|
'Zero UUID workflow: subgraph undo rendering',
|
|
{ tag: ['@workflow', '@subgraph'] },
|
|
() => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
test.setTimeout(30000) // Extend timeout as we need to reload the page an additional time
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.page.reload() // Reload page as we need to enter in Vue mode
|
|
await comfyPage.page.waitForFunction(() => !!window.app?.graph)
|
|
})
|
|
|
|
test('Undo after subgraph enter/exit renders all nodes when workflow starts with zero UUID', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.workflow.loadWorkflow(
|
|
'subgraphs/basic-subgraph-zero-uuid'
|
|
)
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
|
|
const assertInSubgraph = async (inSubgraph: boolean) => {
|
|
await expect
|
|
.poll(() => comfyPage.subgraph.isInSubgraph())
|
|
.toBe(inSubgraph)
|
|
}
|
|
|
|
// Root graph has 1 subgraph node, rendered in the DOM
|
|
await expect.poll(() => comfyPage.nodeOps.getGraphNodesCount()).toBe(1)
|
|
await expect.poll(() => comfyPage.vueNodes.getNodeCount()).toBe(1)
|
|
|
|
await comfyPage.vueNodes.enterSubgraph()
|
|
await assertInSubgraph(true)
|
|
|
|
await comfyPage.subgraph.exitViaBreadcrumb()
|
|
await assertInSubgraph(false)
|
|
|
|
await comfyPage.canvas.focus()
|
|
await comfyPage.keyboard.undo()
|
|
await comfyPage.nextFrame()
|
|
|
|
// After undo, the subgraph node is still visible and rendered
|
|
await expect.poll(() => comfyPage.nodeOps.getGraphNodesCount()).toBe(1)
|
|
await expect.poll(() => comfyPage.vueNodes.getNodeCount()).toBe(1)
|
|
})
|
|
}
|
|
)
|