mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
0d535631a5
## Summary
Extract inline `getByRole('dialog')` calls across E2E tests into
reusable page objects.
## Changes
- **What**: Extract `ConfirmDialog` class from `ComfyPage.ts` into
`browser_tests/fixtures/components/ConfirmDialog.ts` with new `save`
button locator. Add `MediaLightbox` and `TemplatesDialog` page objects.
Refactor 4 test files to use these page objects instead of raw dialog
locators.
- **Skipped**: `appModeDropdownClipping.spec.ts` uses
`getByRole('dialog')` for a PrimeVue Popover (not a true dialog), left
as-is.
## Review Focus
The `ConfirmDialog.click()` method now supports a `save` action used by
`workflowPersistence.spec.ts`, which also waits for the dialog mask to
disappear and workflow service to settle.
Fixes #10723
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10822-refactor-test-extract-dialog-page-objects-from-inline-getByRole-usage-3366d73d365081b3bc0ee7ef0ddce658)
by [Unito](https://www.unito.io)
69 lines
2.3 KiB
TypeScript
69 lines
2.3 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import type { ComfyPage } from '../fixtures/ComfyPage'
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
test.describe('MediaLightbox', { tag: ['@slow'] }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.setup()
|
|
})
|
|
|
|
async function runAndOpenGallery(comfyPage: ComfyPage) {
|
|
await comfyPage.workflow.loadWorkflow(
|
|
'widgets/save_image_and_animated_webp'
|
|
)
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
await comfyPage.runButton.click()
|
|
|
|
// Wait for SaveImage node to produce output
|
|
const saveImageNode = comfyPage.vueNodes.getNodeByTitle('Save Image')
|
|
await expect(saveImageNode.locator('.image-preview img')).toBeVisible({
|
|
timeout: 30_000
|
|
})
|
|
|
|
// Open Assets sidebar tab and wait for it to load
|
|
await comfyPage.page.locator('.assets-tab-button').click()
|
|
await comfyPage.page
|
|
.locator('.sidebar-content-container')
|
|
.waitFor({ state: 'visible' })
|
|
|
|
// Wait for any asset card to appear (may contain img or video)
|
|
const assetCard = comfyPage.page
|
|
.locator('[role="button"]')
|
|
.filter({ has: comfyPage.page.locator('img, video') })
|
|
.first()
|
|
|
|
await expect(assetCard).toBeVisible({ timeout: 30_000 })
|
|
|
|
// Hover to reveal zoom button, then click it
|
|
await assetCard.hover()
|
|
await assetCard.getByLabel('Zoom in').click()
|
|
|
|
const { root } = comfyPage.mediaLightbox
|
|
await expect(root).toBeVisible()
|
|
}
|
|
|
|
test('opens gallery and shows dialog with close button', async ({
|
|
comfyPage
|
|
}) => {
|
|
await runAndOpenGallery(comfyPage)
|
|
await expect(comfyPage.mediaLightbox.closeButton).toBeVisible()
|
|
})
|
|
|
|
test('closes gallery on Escape key', async ({ comfyPage }) => {
|
|
await runAndOpenGallery(comfyPage)
|
|
|
|
await comfyPage.page.keyboard.press('Escape')
|
|
await expect(comfyPage.mediaLightbox.root).not.toBeVisible()
|
|
})
|
|
|
|
test('closes gallery when clicking close button', async ({ comfyPage }) => {
|
|
await runAndOpenGallery(comfyPage)
|
|
|
|
await comfyPage.mediaLightbox.closeButton.click()
|
|
await expect(comfyPage.mediaLightbox.root).not.toBeVisible()
|
|
})
|
|
})
|