Files
ComfyUI_frontend/src/composables/sidebarTabs/useJobHistorySidebarTab.test.ts
Benjamin Lu 35f15d18b4 feat: add job history and assets sidebar badge behavior (#9050)
## Summary
Add sidebar badge behavior for queue/asset visibility updates:
- Job History tab icon shows active jobs count (`queued + running`) only
when the Job History panel is closed.
- Assets tab icon no longer mirrors active jobs; when QPO V2 is enabled
it now shows the number of assets added since the last time Assets was
opened.
- Opening Assets clears the unseen added-assets badge count.

## Changes
- Added `iconBadge` logic to Job History sidebar tab.
- Replaced Assets sidebar badge source with new unseen-assets counter
logic.
- Added `assetsSidebarBadgeStore` to track unseen asset additions from
history updates and reset on Assets open.
- Added/updated unit tests for both sidebar tab composables and the new
store behavior.


https://github.com/user-attachments/assets/33588a2a-c607-4fcc-8221-e7f11c3d79cc



┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-9050-fix-add-job-history-and-assets-sidebar-badge-behavior-30e6d73d365081c38297fe6aac9cd34c)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
2026-02-22 01:05:39 -08:00

60 lines
1.7 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from 'vitest'
import { useJobHistorySidebarTab } from '@/composables/sidebarTabs/useJobHistorySidebarTab'
const { mockActiveJobsCount, mockActiveSidebarTabId } = vi.hoisted(() => ({
mockActiveJobsCount: { value: 0 },
mockActiveSidebarTabId: { value: null as string | null }
}))
vi.mock('@/components/sidebar/tabs/JobHistorySidebarTab.vue', () => ({
default: {}
}))
vi.mock('@/stores/queueStore', () => ({
useQueueStore: () => ({
activeJobsCount: mockActiveJobsCount.value
})
}))
vi.mock('@/stores/workspace/sidebarTabStore', () => ({
useSidebarTabStore: () => ({
activeSidebarTabId: mockActiveSidebarTabId.value
})
}))
describe('useJobHistorySidebarTab', () => {
beforeEach(() => {
mockActiveSidebarTabId.value = null
mockActiveJobsCount.value = 0
})
it('shows active jobs count while the panel is closed', () => {
mockActiveSidebarTabId.value = 'assets'
mockActiveJobsCount.value = 3
const sidebarTab = useJobHistorySidebarTab()
expect(typeof sidebarTab.iconBadge).toBe('function')
expect((sidebarTab.iconBadge as () => string | null)()).toBe('3')
})
it('hides badge while the job history panel is open', () => {
mockActiveSidebarTabId.value = 'job-history'
mockActiveJobsCount.value = 3
const sidebarTab = useJobHistorySidebarTab()
expect((sidebarTab.iconBadge as () => string | null)()).toBeNull()
})
it('hides badge when there are no active jobs', () => {
mockActiveSidebarTabId.value = null
mockActiveJobsCount.value = 0
const sidebarTab = useJobHistorySidebarTab()
expect((sidebarTab.iconBadge as () => string | null)()).toBeNull()
})
})