mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-23 00:04:06 +00:00
## Summary Add a `node_library_essentials_enabled` feature flag to gate the Essentials tab, allowing the rest of the new node library to ship while the Essentials tab is finalized. ## Changes - **What**: New feature flag (`node_library_essentials_enabled`) that hides the Essentials tab in the node library sidebar and search category sidebar. Defaults to `true` in dev/nightly builds, `false` in production. Overridable via remote config or server feature flags. Falls back to the "All" tab if a user previously had Essentials selected. **Disabled UI** <img width="547" height="782" alt="image" src="https://github.com/user-attachments/assets/bcfcecd4-cbae-4d7b-9bcc-64bdf57929e2" /> **Enabled UI** <img width="547" height="782" alt="image" src="https://github.com/user-attachments/assets/0fb030ea-3bde-475e-982b-45e8f190cb8f" /> ## Review Focus - Feature flag pattern follows existing conventions (e.g. `linearToggleEnabled`) - Fallback behavior when essentials tab was previously selected by user ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9067-feat-add-feature-flag-to-disable-Essentials-tab-in-node-library-30e6d73d36508103b3cad9fc5d260611) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>
144 lines
4.4 KiB
TypeScript
144 lines
4.4 KiB
TypeScript
import { computed, reactive, readonly } from 'vue'
|
|
|
|
import { isCloud, isNightly } from '@/platform/distribution/types'
|
|
import {
|
|
isAuthenticatedConfigLoaded,
|
|
remoteConfig
|
|
} from '@/platform/remoteConfig/remoteConfig'
|
|
import { api } from '@/scripts/api'
|
|
import { getDevOverride } from '@/utils/devFeatureFlagOverride'
|
|
|
|
/**
|
|
* Known server feature flags (top-level, not extensions)
|
|
*/
|
|
export enum ServerFeatureFlag {
|
|
SUPPORTS_PREVIEW_METADATA = 'supports_preview_metadata',
|
|
MAX_UPLOAD_SIZE = 'max_upload_size',
|
|
MANAGER_SUPPORTS_V4 = 'extension.manager.supports_v4',
|
|
MODEL_UPLOAD_BUTTON_ENABLED = 'model_upload_button_enabled',
|
|
ASSET_RENAME_ENABLED = 'asset_rename_enabled',
|
|
PRIVATE_MODELS_ENABLED = 'private_models_enabled',
|
|
ONBOARDING_SURVEY_ENABLED = 'onboarding_survey_enabled',
|
|
LINEAR_TOGGLE_ENABLED = 'linear_toggle_enabled',
|
|
TEAM_WORKSPACES_ENABLED = 'team_workspaces_enabled',
|
|
USER_SECRETS_ENABLED = 'user_secrets_enabled',
|
|
NODE_REPLACEMENTS = 'node_replacements',
|
|
NODE_LIBRARY_ESSENTIALS_ENABLED = 'node_library_essentials_enabled'
|
|
}
|
|
|
|
/**
|
|
* Resolves a feature flag value with dev override > remoteConfig > serverFeature priority.
|
|
*/
|
|
function resolveFlag<T>(
|
|
flagKey: string,
|
|
remoteConfigValue: T | undefined,
|
|
defaultValue: T
|
|
): T {
|
|
const override = getDevOverride<T>(flagKey)
|
|
if (override !== undefined) return override
|
|
return remoteConfigValue ?? api.getServerFeature(flagKey, defaultValue)
|
|
}
|
|
|
|
/**
|
|
* Composable for reactive access to server-side feature flags
|
|
*/
|
|
export function useFeatureFlags() {
|
|
const flags = reactive({
|
|
get supportsPreviewMetadata() {
|
|
return api.getServerFeature(ServerFeatureFlag.SUPPORTS_PREVIEW_METADATA)
|
|
},
|
|
get maxUploadSize() {
|
|
return api.getServerFeature(ServerFeatureFlag.MAX_UPLOAD_SIZE)
|
|
},
|
|
get supportsManagerV4() {
|
|
return api.getServerFeature(ServerFeatureFlag.MANAGER_SUPPORTS_V4)
|
|
},
|
|
get modelUploadButtonEnabled() {
|
|
return resolveFlag(
|
|
ServerFeatureFlag.MODEL_UPLOAD_BUTTON_ENABLED,
|
|
remoteConfig.value.model_upload_button_enabled,
|
|
false
|
|
)
|
|
},
|
|
get assetRenameEnabled() {
|
|
return resolveFlag(
|
|
ServerFeatureFlag.ASSET_RENAME_ENABLED,
|
|
remoteConfig.value.asset_rename_enabled,
|
|
false
|
|
)
|
|
},
|
|
get privateModelsEnabled() {
|
|
return resolveFlag(
|
|
ServerFeatureFlag.PRIVATE_MODELS_ENABLED,
|
|
remoteConfig.value.private_models_enabled,
|
|
false
|
|
)
|
|
},
|
|
get onboardingSurveyEnabled() {
|
|
return resolveFlag(
|
|
ServerFeatureFlag.ONBOARDING_SURVEY_ENABLED,
|
|
remoteConfig.value.onboarding_survey_enabled,
|
|
false
|
|
)
|
|
},
|
|
get linearToggleEnabled() {
|
|
if (isNightly) return true
|
|
|
|
return resolveFlag(
|
|
ServerFeatureFlag.LINEAR_TOGGLE_ENABLED,
|
|
remoteConfig.value.linear_toggle_enabled,
|
|
false
|
|
)
|
|
},
|
|
/**
|
|
* Whether team workspaces feature is enabled.
|
|
* IMPORTANT: Returns false until authenticated remote config is loaded.
|
|
* This ensures we never use workspace tokens when the feature is disabled,
|
|
* and prevents race conditions during initialization.
|
|
*/
|
|
get teamWorkspacesEnabled() {
|
|
const override = getDevOverride<boolean>(
|
|
ServerFeatureFlag.TEAM_WORKSPACES_ENABLED
|
|
)
|
|
if (override !== undefined) return override
|
|
|
|
if (!isCloud) return false
|
|
if (!isAuthenticatedConfigLoaded.value) return false
|
|
|
|
return (
|
|
remoteConfig.value.team_workspaces_enabled ??
|
|
api.getServerFeature(ServerFeatureFlag.TEAM_WORKSPACES_ENABLED, false)
|
|
)
|
|
},
|
|
get userSecretsEnabled() {
|
|
return resolveFlag(
|
|
ServerFeatureFlag.USER_SECRETS_ENABLED,
|
|
remoteConfig.value.user_secrets_enabled,
|
|
false
|
|
)
|
|
},
|
|
get nodeReplacementsEnabled() {
|
|
return api.getServerFeature(ServerFeatureFlag.NODE_REPLACEMENTS, false)
|
|
},
|
|
get nodeLibraryEssentialsEnabled() {
|
|
if (isNightly || import.meta.env.DEV) return true
|
|
|
|
return (
|
|
remoteConfig.value.node_library_essentials_enabled ??
|
|
api.getServerFeature(
|
|
ServerFeatureFlag.NODE_LIBRARY_ESSENTIALS_ENABLED,
|
|
false
|
|
)
|
|
)
|
|
}
|
|
})
|
|
|
|
const featureFlag = <T = unknown>(featurePath: string, defaultValue?: T) =>
|
|
computed(() => api.getServerFeature(featurePath, defaultValue))
|
|
|
|
return {
|
|
flags: readonly(flags),
|
|
featureFlag
|
|
}
|
|
}
|