mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-06-08 15:29:52 +00:00
9a86b33c77
## Summary Silence false Iconify warning spam during Tailwind lint analysis while preserving icon utility generation and real failure signals. ## Changes - **What**: Local wrapper around `@iconify/tailwind4` that swallows the noise from `better-tailwindcss/enforce-canonical-classes` probes. Wrapper delegates icon resolution to upstream's `getDynamicCSSRules`; only custom-comfy folder loading is reimplemented. `lucideStrokePlugin` uses a `InvalidIconProbeError` sentinel so missing icons / missing deps still surface. - **Dependencies**: None. ## Background Both upstreams have refused to address this: - `better-tailwindcss` ([schoero/eslint-plugin-better-tailwindcss#377](https://github.com/schoero/eslint-plugin-better-tailwindcss/issues/377), open) — owner declines to filter third-party warnings; says it should be fixed in iconify. - `@iconify/tailwind4` ([iconify/iconify#357](https://github.com/iconify/iconify/issues/357), closed) — maintainer defends the `console.warn` as intentional; *"not something plugin has control over"*. Trigger path: `enforce-canonical-classes` → Tailwind `canonicalizeCandidates()` → iconify `matchComponents` handler throws on non-icon strings → upstream catches + `console.warn`. ## Review Focus - Inline `loadComfyIconSet` in `iconifyDynamicPlugin.js` skips `@iconify/tools`' `parseColors → currentColor` normalization. Verified the comfy SVGs already use `currentColor` directly; multi-color icons (bria, bytedance) keep their explicit fills as expected. - `lucideStrokePlugin.js` catch is now type-discriminated — only `InvalidIconProbeError` returns `{}`; `Cannot load icon set` and `Cannot find icon` re-throw. --------- Co-authored-by: Amp <amp@ampcode.com>
25 lines
576 B
JSON
25 lines
576 B
JSON
{
|
|
"name": "@comfyorg/design-system",
|
|
"version": "1.0.0",
|
|
"description": "Shared design system for ComfyUI Frontend",
|
|
"type": "module",
|
|
"exports": {
|
|
"./css/*": "./src/css/*"
|
|
},
|
|
"scripts": {
|
|
"typecheck": "tsc --noEmit"
|
|
},
|
|
"dependencies": {
|
|
"@iconify-json/lucide": "catalog:",
|
|
"@iconify/tailwind4": "catalog:",
|
|
"@iconify/tools": "catalog:",
|
|
"@iconify/utils": "catalog:",
|
|
"tailwindcss-primeui": "catalog:",
|
|
"tw-animate-css": "catalog:"
|
|
},
|
|
"devDependencies": {
|
|
"tailwindcss": "catalog:",
|
|
"typescript": "catalog:"
|
|
}
|
|
}
|