mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
8c9328c1b2
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
96 lines
3.6 KiB
TypeScript
96 lines
3.6 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
// If an input is optional by node definition, it should be shown as
|
|
// a hollow circle no matter what shape it was defined in the workflow JSON.
|
|
test.describe('Optional input', { tag: ['@screenshot', '@node'] }, () => {
|
|
test('No shape specified', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/optional_input_no_shape')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('optional_input.png')
|
|
})
|
|
|
|
test('Wrong shape specified', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/optional_input_wrong_shape')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('optional_input.png')
|
|
})
|
|
|
|
test('Correct shape specified', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/optional_input_correct_shape')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('optional_input.png')
|
|
})
|
|
|
|
test('Force input', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/force_input')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('force_input.png')
|
|
})
|
|
|
|
test('Default input', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/default_input')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('default_input.png')
|
|
})
|
|
|
|
test('Only optional inputs', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/only_optional_inputs')
|
|
await expect.poll(() => comfyPage.nodeOps.getGraphNodesCount()).toBe(1)
|
|
await expect(
|
|
comfyPage.page.getByTestId(TestIds.dialogs.errorOverlay)
|
|
).toBeHidden()
|
|
|
|
// If the node's multiline text widget is visible, then it was loaded successfully
|
|
await expect(comfyPage.page.locator('.comfy-multiline-input')).toHaveCount(
|
|
1
|
|
)
|
|
})
|
|
|
|
test('Old workflow with converted input', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/old_workflow_converted_input')
|
|
const node = await comfyPage.nodeOps.getNodeRefById('1')
|
|
const inputs = (await node.getProperty('inputs')) as {
|
|
name: string
|
|
link?: number | null
|
|
}[]
|
|
const vaeInput = inputs.find((w) => w.name === 'vae')
|
|
const convertedInput = inputs.find((w) => w.name === 'strength')
|
|
|
|
expect(vaeInput).toBeDefined()
|
|
expect(convertedInput).toBeDefined()
|
|
expect(vaeInput!.link).toBeNull()
|
|
expect(convertedInput!.link).not.toBeNull()
|
|
})
|
|
|
|
test('Renamed converted input', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/renamed_converted_widget')
|
|
const node = await comfyPage.nodeOps.getNodeRefById('3')
|
|
const inputs = (await node.getProperty('inputs')) as { name: string }[]
|
|
const renamedInput = inputs.find((w) => w.name === 'breadth')
|
|
expect(renamedInput).toBeUndefined()
|
|
})
|
|
|
|
test('slider', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/simple_slider')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('simple_slider.png')
|
|
})
|
|
|
|
test('unknown converted widget', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow(
|
|
'missing/missing_nodes_converted_widget'
|
|
)
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'missing_nodes_converted_widget.png'
|
|
)
|
|
})
|
|
|
|
test('dynamically added input', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('inputs/dynamically_added_input')
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'dynamically_added_input.png'
|
|
)
|
|
})
|
|
})
|