mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
72eed86cea
## Summary Follow-up cleanup for #11184 — removes redundant test setup calls that the `@vue-nodes` fixture now handles. ## Changes - **What**: Remove 40 lines of redundant `setSetting`, `setup()`, and `waitForNodes()` calls across 11 test files - `UseNewMenu: 'Top'` calls (already fixture default) - `setup()` + `waitForNodes()` on default workflow (fixture already does this for `@vue-nodes`) - Page reload in `subgraphZeroUuid` (fixture applies VueNodes.Enabled server-side before navigation) ## Review Focus Each removal was verified against the fixture's `setupSettings()` defaults (ComfyPage.ts:420-442) and the `@vue-nodes` auto-setup (lines 454-456). Tests that call `setup()`/`waitForNodes()` after `loadWorkflow()` or `page.evaluate()` were intentionally kept. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11195-test-remove-redundant-setup-settings-now-handled-by-vue-nodes-fixture-3416d73d36508154827df116a97e9130) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
43 lines
1.4 KiB
TypeScript
43 lines
1.4 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe(
|
|
'Zero UUID workflow: subgraph undo rendering',
|
|
{ tag: ['@workflow', '@subgraph', '@vue-nodes'] },
|
|
() => {
|
|
test('Undo after subgraph enter/exit renders all nodes when workflow starts with zero UUID', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.workflow.loadWorkflow(
|
|
'subgraphs/basic-subgraph-zero-uuid'
|
|
)
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
|
|
const assertInSubgraph = async (inSubgraph: boolean) => {
|
|
await expect
|
|
.poll(() => comfyPage.subgraph.isInSubgraph())
|
|
.toBe(inSubgraph)
|
|
}
|
|
|
|
// Root graph has 1 subgraph node, rendered in the DOM
|
|
await expect.poll(() => comfyPage.nodeOps.getGraphNodesCount()).toBe(1)
|
|
await expect.poll(() => comfyPage.vueNodes.getNodeCount()).toBe(1)
|
|
|
|
await comfyPage.vueNodes.enterSubgraph()
|
|
await assertInSubgraph(true)
|
|
|
|
await comfyPage.subgraph.exitViaBreadcrumb()
|
|
await assertInSubgraph(false)
|
|
|
|
await comfyPage.canvas.focus()
|
|
await comfyPage.keyboard.undo()
|
|
await comfyPage.nextFrame()
|
|
|
|
// After undo, the subgraph node is still visible and rendered
|
|
await expect.poll(() => comfyPage.nodeOps.getGraphNodesCount()).toBe(1)
|
|
await expect.poll(() => comfyPage.vueNodes.getNodeCount()).toBe(1)
|
|
})
|
|
}
|
|
)
|