mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-22 07:19:41 +00:00
72eed86cea
## Summary Follow-up cleanup for #11184 — removes redundant test setup calls that the `@vue-nodes` fixture now handles. ## Changes - **What**: Remove 40 lines of redundant `setSetting`, `setup()`, and `waitForNodes()` calls across 11 test files - `UseNewMenu: 'Top'` calls (already fixture default) - `setup()` + `waitForNodes()` on default workflow (fixture already does this for `@vue-nodes`) - Page reload in `subgraphZeroUuid` (fixture applies VueNodes.Enabled server-side before navigation) ## Review Focus Each removal was verified against the fixture's `setupSettings()` defaults (ComfyPage.ts:420-442) and the `@vue-nodes` auto-setup (lines 454-456). Tests that call `setup()`/`waitForNodes()` after `loadWorkflow()` or `page.evaluate()` were intentionally kept. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11195-test-remove-redundant-setup-settings-now-handled-by-vue-nodes-fixture-3416d73d36508154827df116a97e9130) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
49 lines
1.6 KiB
TypeScript
49 lines
1.6 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
|
|
test.describe('Vue Nodes Renaming', { tag: '@vue-nodes' }, () => {
|
|
test('should display node title', async ({ comfyPage }) => {
|
|
const vueNode = await comfyPage.vueNodes.getFixtureByTitle('KSampler')
|
|
await expect(vueNode.header).toContainText('KSampler')
|
|
})
|
|
|
|
test('should allow title renaming by double clicking on the node header', async ({
|
|
comfyPage
|
|
}) => {
|
|
const vueNode = await comfyPage.vueNodes.getFixtureByTitle('KSampler')
|
|
// Test renaming with Enter
|
|
await vueNode.setTitle('My Custom Sampler')
|
|
await expect(vueNode.title).toHaveText('My Custom Sampler')
|
|
await expect(vueNode.header).toContainText('My Custom Sampler')
|
|
|
|
// Test cancel with Escape
|
|
await vueNode.title.dblclick()
|
|
await comfyPage.nextFrame()
|
|
await vueNode.titleInput.fill('This Should Be Cancelled')
|
|
await vueNode.titleInput.press('Escape')
|
|
await comfyPage.nextFrame()
|
|
|
|
// Title should remain as the previously saved value
|
|
await expect(vueNode.title).toHaveText('My Custom Sampler')
|
|
})
|
|
|
|
test('Double click node body does not trigger edit', async ({
|
|
comfyPage
|
|
}) => {
|
|
const loadCheckpointNode = comfyPage.vueNodes
|
|
.getNodeByTitle('Load Checkpoint')
|
|
.first()
|
|
const nodeBbox = await loadCheckpointNode.boundingBox()
|
|
if (!nodeBbox) throw new Error('Node not found')
|
|
await loadCheckpointNode.dblclick()
|
|
|
|
const editingTitleInput = comfyPage.page.getByTestId(
|
|
TestIds.node.titleInput
|
|
)
|
|
await expect(editingTitleInput).toBeHidden()
|
|
})
|
|
})
|