mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-05 23:50:08 +00:00
f2d5bfab73
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
94 lines
3.1 KiB
TypeScript
94 lines
3.1 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '../../../fixtures/ComfyPage'
|
|
|
|
test.describe('Vue Node Collapse', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.Graph.CanvasMenu', false)
|
|
await comfyPage.settings.setSetting('Comfy.EnableTooltips', true)
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.setup()
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
})
|
|
|
|
test('should allow collapsing node with collapse icon', async ({
|
|
comfyPage
|
|
}) => {
|
|
const vueNode = await comfyPage.vueNodes.getFixtureByTitle('KSampler')
|
|
await expect(vueNode.root).toBeVisible()
|
|
|
|
// Initially should not be collapsed
|
|
const body = vueNode.body
|
|
await expect(body).toBeVisible()
|
|
const expandedBoundingBox = await vueNode.boundingBox()
|
|
if (!expandedBoundingBox)
|
|
throw new Error('Failed to get node bounding box before collapse')
|
|
|
|
// Collapse the node
|
|
await vueNode.toggleCollapse()
|
|
await comfyPage.nextFrame()
|
|
|
|
// Verify node content is hidden
|
|
await expect(body).not.toBeVisible()
|
|
const collapsedBoundingBox = await vueNode.boundingBox()
|
|
if (!collapsedBoundingBox)
|
|
throw new Error('Failed to get node bounding box after collapse')
|
|
expect(collapsedBoundingBox.height).toBeLessThan(expandedBoundingBox.height)
|
|
|
|
// Expand again
|
|
await vueNode.toggleCollapse()
|
|
await comfyPage.nextFrame()
|
|
await expect(body).toBeVisible()
|
|
|
|
// Size should be restored
|
|
const expandedBoundingBoxAfter = await vueNode.boundingBox()
|
|
if (!expandedBoundingBoxAfter)
|
|
throw new Error('Failed to get node bounding box after expand')
|
|
expect(expandedBoundingBoxAfter.height).toBeGreaterThanOrEqual(
|
|
collapsedBoundingBox.height
|
|
)
|
|
})
|
|
|
|
test('should show collapse/expand icon state', async ({ comfyPage }) => {
|
|
const vueNode = await comfyPage.vueNodes.getFixtureByTitle('KSampler')
|
|
await expect(vueNode.root).toBeVisible()
|
|
|
|
// Check initial expanded state icon
|
|
let iconClass = await vueNode.getCollapseIconClass()
|
|
expect(iconClass).not.toContain('-rotate-90')
|
|
|
|
// Collapse and check icon
|
|
await vueNode.toggleCollapse()
|
|
iconClass = await vueNode.getCollapseIconClass()
|
|
expect(iconClass).toContain('-rotate-90')
|
|
|
|
// Expand and check icon
|
|
await vueNode.toggleCollapse()
|
|
iconClass = await vueNode.getCollapseIconClass()
|
|
expect(iconClass).not.toContain('-rotate-90')
|
|
})
|
|
|
|
test('should preserve title when collapsing/expanding', async ({
|
|
comfyPage
|
|
}) => {
|
|
const vueNode = await comfyPage.vueNodes.getFixtureByTitle('KSampler')
|
|
await expect(vueNode.root).toBeVisible()
|
|
|
|
// Set custom title
|
|
await vueNode.setTitle('Test Sampler')
|
|
expect(await vueNode.getTitle()).toBe('Test Sampler')
|
|
|
|
// Collapse
|
|
await vueNode.toggleCollapse()
|
|
expect(await vueNode.getTitle()).toBe('Test Sampler')
|
|
|
|
// Expand
|
|
await vueNode.toggleCollapse()
|
|
expect(await vueNode.getTitle()).toBe('Test Sampler')
|
|
|
|
// Verify title is still displayed
|
|
await expect(vueNode.header).toContainText('Test Sampler')
|
|
})
|
|
})
|