mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-10 01:50:08 +00:00
f2d5bfab73
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
86 lines
3.1 KiB
TypeScript
86 lines
3.1 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '../../../fixtures/ComfyPage'
|
|
|
|
const PIN_HOTKEY = 'p'
|
|
const PIN_INDICATOR = '[data-testid="node-pin-indicator"]'
|
|
|
|
test.describe('Vue Node Pin', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
})
|
|
|
|
test('should allow toggling pin on a selected node with hotkey', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.page.getByText('Load Checkpoint').click()
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
|
|
const checkpointNode = comfyPage.vueNodes.getNodeByTitle('Load Checkpoint')
|
|
const pinIndicator = checkpointNode.locator(PIN_INDICATOR)
|
|
|
|
await expect(pinIndicator).toBeVisible()
|
|
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
await expect(pinIndicator).not.toBeVisible()
|
|
})
|
|
|
|
test('should allow toggling pin on multiple selected nodes with hotkey', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.page.getByText('Load Checkpoint').click()
|
|
await comfyPage.page.getByText('KSampler').click({ modifiers: ['Control'] })
|
|
|
|
const checkpointNode = comfyPage.vueNodes.getNodeByTitle('Load Checkpoint')
|
|
const ksamplerNode = comfyPage.vueNodes.getNodeByTitle('KSampler')
|
|
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
const pinIndicator1 = checkpointNode.locator(PIN_INDICATOR)
|
|
await expect(pinIndicator1).toBeVisible()
|
|
const pinIndicator2 = ksamplerNode.locator(PIN_INDICATOR)
|
|
await expect(pinIndicator2).toBeVisible()
|
|
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
await expect(pinIndicator1).not.toBeVisible()
|
|
await expect(pinIndicator2).not.toBeVisible()
|
|
})
|
|
|
|
test('should not allow dragging pinned nodes', async ({ comfyPage }) => {
|
|
const checkpointNodeHeader = comfyPage.page.getByText('Load Checkpoint')
|
|
await checkpointNodeHeader.click()
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
|
|
// Try to drag the node
|
|
const headerPos = await checkpointNodeHeader.boundingBox()
|
|
if (!headerPos) throw new Error('Failed to get header position')
|
|
await comfyPage.canvasOps.dragAndDrop(
|
|
{ x: headerPos.x, y: headerPos.y },
|
|
{ x: headerPos.x + 256, y: headerPos.y + 256 }
|
|
)
|
|
|
|
// Verify the node is not dragged (same position before and after click-and-drag)
|
|
const headerPosAfterDrag = await checkpointNodeHeader.boundingBox()
|
|
if (!headerPosAfterDrag)
|
|
throw new Error('Failed to get header position after drag')
|
|
expect(headerPosAfterDrag).toEqual(headerPos)
|
|
|
|
// Unpin the node with the hotkey
|
|
await checkpointNodeHeader.click()
|
|
await comfyPage.page.keyboard.press(PIN_HOTKEY)
|
|
|
|
// Try to drag the node again
|
|
await comfyPage.canvasOps.dragAndDrop(
|
|
{ x: headerPos.x, y: headerPos.y },
|
|
{ x: headerPos.x + 256, y: headerPos.y + 256 }
|
|
)
|
|
|
|
// Verify the node is dragged
|
|
const headerPosAfterDrag2 = await checkpointNodeHeader.boundingBox()
|
|
if (!headerPosAfterDrag2)
|
|
throw new Error('Failed to get header position after drag')
|
|
expect(headerPosAfterDrag2).not.toEqual(headerPos)
|
|
})
|
|
})
|