Files
ComfyUI_frontend/tests-ui/tests/store/assetsStore.test.ts
Arjan Singh a2ef569b9c feat(ComboWidget): add ability to have mapped inputs (#6585)
## Summary

1. Add a `getOptionLabel` option to `ComboWidget` so users of it can map
of custom labels to widget values. (e.g., `"My Photo" ->
"my_photo_1235.png"`).
2. Utilize this ability in Cloud environment to map user uploaded
filenames to their corresponding input asset.
3. Copious unit tests to make sure I didn't (AFAIK) break anything
during the refactoring portion of development.
4. Bonus: Scope model browser to only show in cloud distributions until
it's released elsewhere; should prevent some undesired UI behavior if a
user accidentally enables the assetAPI.

## Review Focus

Widget code: please double check the work there.

## Screenshots (if applicable)



https://github.com/user-attachments/assets/a94b3203-c87f-4285-b692-479996859a5a


┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6585-Feat-input-mapping-2a26d73d365081faa667e49892c8d45a)
by [Unito](https://www.unito.io)
2025-11-05 11:33:00 -08:00

158 lines
4.2 KiB
TypeScript

import { createPinia, setActivePinia } from 'pinia'
import { beforeEach, describe, expect, it } from 'vitest'
import type { AssetItem } from '@/platform/assets/schemas/assetSchema'
import { useAssetsStore } from '@/stores/assetsStore'
const HASH_FILENAME =
'72e786ff2a44d682c4294db0b7098e569832bc394efc6dad644e6ec85a78efb7.png'
const HASH_FILENAME_2 =
'a1b2c3d4e5f6789012345678901234567890abcdef1234567890abcdef123456.jpg'
function createMockAssetItem(overrides: Partial<AssetItem> = {}): AssetItem {
return {
id: 'test-id',
name: 'test.png',
asset_hash: 'test-hash',
size: 1024,
tags: [],
created_at: '2024-01-01T00:00:00.000Z',
...overrides
}
}
describe('assetsStore', () => {
beforeEach(() => {
setActivePinia(createPinia())
})
describe('input asset mapping helpers', () => {
it('should return name for valid asset_hash', () => {
const store = useAssetsStore()
store.inputAssets = [
createMockAssetItem({
name: 'Beautiful Sunset.png',
asset_hash: HASH_FILENAME
}),
createMockAssetItem({
name: 'Mountain Vista.jpg',
asset_hash: HASH_FILENAME_2
})
]
expect(store.getInputName(HASH_FILENAME)).toBe('Beautiful Sunset.png')
expect(store.getInputName(HASH_FILENAME_2)).toBe('Mountain Vista.jpg')
})
it('should return original hash when no matching asset found', () => {
const store = useAssetsStore()
store.inputAssets = [
createMockAssetItem({
name: 'Beautiful Sunset.png',
asset_hash: HASH_FILENAME
})
]
const unknownHash =
'fffffffffffffffffffffffffffuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu.png'
expect(store.getInputName(unknownHash)).toBe(unknownHash)
})
it('should return hash as-is when no assets loaded', () => {
const store = useAssetsStore()
store.inputAssets = []
expect(store.getInputName(HASH_FILENAME)).toBe(HASH_FILENAME)
})
it('should ignore assets without asset_hash', () => {
const store = useAssetsStore()
store.inputAssets = [
createMockAssetItem({
name: 'Beautiful Sunset.png',
asset_hash: HASH_FILENAME
}),
createMockAssetItem({
name: 'No Hash Asset.jpg',
asset_hash: null
})
]
// Should find first asset
expect(store.getInputName(HASH_FILENAME)).toBe('Beautiful Sunset.png')
// Map should only contain one entry
expect(store.inputAssetsByFilename.size).toBe(1)
})
})
describe('inputAssetsByFilename computed', () => {
it('should create map keyed by asset_hash', () => {
const store = useAssetsStore()
store.inputAssets = [
createMockAssetItem({
id: 'asset-123',
name: 'Beautiful Sunset.png',
asset_hash: HASH_FILENAME
}),
createMockAssetItem({
id: 'asset-456',
name: 'Mountain Vista.jpg',
asset_hash: HASH_FILENAME_2
})
]
const map = store.inputAssetsByFilename
expect(map.size).toBe(2)
expect(map.get(HASH_FILENAME)).toMatchObject({
id: 'asset-123',
name: 'Beautiful Sunset.png',
asset_hash: HASH_FILENAME
})
expect(map.get(HASH_FILENAME_2)).toMatchObject({
id: 'asset-456',
name: 'Mountain Vista.jpg',
asset_hash: HASH_FILENAME_2
})
})
it('should exclude assets with null/undefined hash from map', () => {
const store = useAssetsStore()
store.inputAssets = [
createMockAssetItem({
name: 'Has Hash.png',
asset_hash: HASH_FILENAME
}),
createMockAssetItem({
name: 'Null Hash.jpg',
asset_hash: null
}),
createMockAssetItem({
name: 'Undefined Hash.jpg',
asset_hash: undefined
})
]
const map = store.inputAssetsByFilename
// Only asset with valid asset_hash should be in map
expect(map.size).toBe(1)
expect(map.has(HASH_FILENAME)).toBe(true)
})
it('should return empty map when no assets loaded', () => {
const store = useAssetsStore()
store.inputAssets = []
expect(store.inputAssetsByFilename.size).toBe(0)
})
})
})