mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
9596a450df
The version-bump workflow injects `packageManager: pnpm@10.33.0` into `package.json` (PR #10972), which conflicts with the explicit `version: 10` in `pnpm/action-setup`. The newer action rejects having both specified. Upgrades all 16 workflow/action files from `pnpm/action-setup@v4.2.0` to `v4.4.0` and removes the `version: 10` input so pnpm version resolves from the `packageManager` field instead. This unblocks CI on the `1.42.11` version-bump PR (#11227) which is needed for the patch release. ┆Issue is synchronized with this [Notion page](https://app.notion.com/p/PR-11228-fix-ci-remove-pnpm-version-10-to-resolve-packageManager-conflict-on-core-1-42-3426d73d3650810fabbdfbec06df5b4a) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>
99 lines
3.1 KiB
YAML
99 lines
3.1 KiB
YAML
name: 'CI: Dist Telemetry Scan'
|
|
|
|
on:
|
|
pull_request:
|
|
branches-ignore: [wip/*, draft/*, temp/*]
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
scan:
|
|
runs-on: ubuntu-latest
|
|
|
|
steps:
|
|
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
|
|
|
|
- name: Install pnpm
|
|
uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0
|
|
|
|
- name: Use Node.js
|
|
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
|
|
with:
|
|
node-version-file: '.nvmrc'
|
|
cache: 'pnpm'
|
|
|
|
- name: Install dependencies
|
|
run: pnpm install --frozen-lockfile
|
|
|
|
- name: Build project
|
|
run: pnpm build
|
|
env:
|
|
DISTRIBUTION: localhost
|
|
|
|
- name: Scan dist for GTM telemetry references
|
|
run: |
|
|
set -euo pipefail
|
|
echo '🔍 Scanning for Google Tag Manager references...'
|
|
if rg --no-ignore -n \
|
|
-g '*.html' \
|
|
-g '*.js' \
|
|
-e 'Google Tag Manager' \
|
|
-e '(?i)\bgtm\.js\b' \
|
|
-e '(?i)googletagmanager\.com/gtm\.js\\?id=' \
|
|
-e '(?i)googletagmanager\.com/ns\.html\\?id=' \
|
|
dist; then
|
|
echo '❌ ERROR: Google Tag Manager references found in dist assets!'
|
|
echo 'GTM must be properly tree-shaken from OSS builds.'
|
|
exit 1
|
|
fi
|
|
echo '✅ No GTM references found'
|
|
|
|
- name: Scan dist for Mixpanel telemetry references
|
|
run: |
|
|
set -euo pipefail
|
|
echo '🔍 Scanning for Mixpanel references...'
|
|
if rg --no-ignore -n \
|
|
-g '*.html' \
|
|
-g '*.js' \
|
|
-e '(?i)mixpanel\.init' \
|
|
-e '(?i)mixpanel\.identify' \
|
|
-e 'MixpanelTelemetryProvider' \
|
|
-e 'mp\.comfy\.org' \
|
|
-e 'mixpanel-browser' \
|
|
-e '(?i)mixpanel\.track\(' \
|
|
dist; then
|
|
echo '❌ ERROR: Mixpanel references found in dist assets!'
|
|
echo 'Mixpanel must be properly tree-shaken from OSS builds.'
|
|
echo ''
|
|
echo 'To fix this:'
|
|
echo '1. Use the TelemetryProvider pattern (see src/platform/telemetry/)'
|
|
echo '2. Call telemetry via useTelemetry() hook'
|
|
echo '3. Use conditional dynamic imports behind isCloud checks'
|
|
exit 1
|
|
fi
|
|
echo '✅ No Mixpanel references found'
|
|
|
|
- name: Scan dist for PostHog telemetry references
|
|
run: |
|
|
set -euo pipefail
|
|
echo '🔍 Scanning for PostHog references...'
|
|
if rg --no-ignore -n \
|
|
-g '*.html' \
|
|
-g '*.js' \
|
|
-e '(?i)posthog\.init' \
|
|
-e '(?i)posthog\.capture' \
|
|
-e 'PostHogTelemetryProvider' \
|
|
-e 'ph\.comfy\.org' \
|
|
-e 'posthog-js' \
|
|
dist; then
|
|
echo '❌ ERROR: PostHog references found in dist assets!'
|
|
echo 'PostHog must be properly tree-shaken from OSS builds.'
|
|
exit 1
|
|
fi
|
|
echo '✅ No PostHog references found'
|