mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-31 05:19:53 +00:00
5897e00793
`LLink.disconnect` is intended to cleanup only the link itself. #4800 mistakenly assumed that it would perform all required steps for disconnection. Later, #5015 would partially resolve this by adding some of the missing functionality into `LLink.disconnect`, but this still left output cleanup unhandled and failed to call `node.onConnectionsChanged`. This PR instead moves the disconnection code to call the function that already has robust handling for these items and removes the no-longer-needed and potentially misleading workaround. Resolves #6247 Also un-skipped several SubgraphIO tests. They appear to function fine. I'm assuming the reasons for them being skipped have been resolved. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6258-Fix-disconnection-of-subgraphInput-links-2966d73d36508112ad1fe602cdcf461b) by [Unito](https://www.unito.io)
18 lines
496 B
TypeScript
18 lines
496 B
TypeScript
import { describe, expect } from 'vitest'
|
|
|
|
import { LLink } from '@/lib/litegraph/src/litegraph'
|
|
|
|
import { test } from './fixtures/testExtensions'
|
|
|
|
describe('LLink', () => {
|
|
test('matches previous snapshot', () => {
|
|
const link = new LLink(1, 'float', 4, 2, 5, 3)
|
|
expect(link.serialize()).toMatchSnapshot('Basic')
|
|
})
|
|
|
|
test('serializes to the previous snapshot', () => {
|
|
const link = new LLink(1, 'float', 4, 2, 5, 3)
|
|
expect(link.serialize()).toMatchSnapshot('Basic')
|
|
})
|
|
})
|