mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-01 22:09:55 +00:00
## Summary See https://typescript-eslint.io/blog/project-service/ for context. Creates a browser_tests specific tsconfig so that they can be linted. Does not add a package.json script to do the linting yet, but `pnpm exec eslint browser_tests` should work for now. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5633-lint-add-tsconfig-for-browser_tests-fix-existing-violations-2726d73d3650819d8ef2c4b0abc31e14) by [Unito](https://www.unito.io)
341 lines
12 KiB
TypeScript
341 lines
12 KiB
TypeScript
// TODO: Fix these tests after migration
|
|
import { describe, expect, it, vi } from 'vitest'
|
|
|
|
import { LinkConnector } from '@/lib/litegraph/src/litegraph'
|
|
import { ToInputFromIoNodeLink } from '@/lib/litegraph/src/litegraph'
|
|
import { SUBGRAPH_INPUT_ID } from '@/lib/litegraph/src/litegraph'
|
|
import { LGraphNode, type LinkNetwork } from '@/lib/litegraph/src/litegraph'
|
|
import type { NodeInputSlot } from '@/lib/litegraph/src/litegraph'
|
|
import type { NodeOutputSlot } from '@/lib/litegraph/src/litegraph'
|
|
import {
|
|
isSubgraphInput,
|
|
isSubgraphOutput
|
|
} from '@/lib/litegraph/src/litegraph'
|
|
|
|
import {
|
|
createTestSubgraph,
|
|
createTestSubgraphNode
|
|
} from './fixtures/subgraphHelpers'
|
|
|
|
describe.skip('Subgraph slot connections', () => {
|
|
describe.skip('SubgraphInput connections', () => {
|
|
it('should connect to compatible regular input slots', () => {
|
|
const subgraph = createTestSubgraph({
|
|
inputs: [{ name: 'test_input', type: 'number' }]
|
|
})
|
|
|
|
const subgraphInput = subgraph.inputs[0]
|
|
|
|
const node = new LGraphNode('TestNode')
|
|
node.addInput('compatible_input', 'number')
|
|
node.addInput('incompatible_input', 'string')
|
|
subgraph.add(node)
|
|
|
|
const compatibleSlot = node.inputs[0] as NodeInputSlot
|
|
const incompatibleSlot = node.inputs[1] as NodeInputSlot
|
|
|
|
expect(compatibleSlot.isValidTarget(subgraphInput)).toBe(true)
|
|
expect(incompatibleSlot.isValidTarget(subgraphInput)).toBe(false)
|
|
})
|
|
|
|
// "not implemented" yet, but the test passes in terms of type checking
|
|
// it("should connect to compatible SubgraphOutput", () => {
|
|
// const subgraph = createTestSubgraph({
|
|
// inputs: [{ name: "test_input", type: "number" }],
|
|
// outputs: [{ name: "test_output", type: "number" }],
|
|
// })
|
|
|
|
// const subgraphInput = subgraph.inputs[0]
|
|
// const subgraphOutput = subgraph.outputs[0]
|
|
|
|
// expect(subgraphOutput.isValidTarget(subgraphInput)).toBe(true)
|
|
// })
|
|
|
|
it('should not connect to another SubgraphInput', () => {
|
|
const subgraph = createTestSubgraph({
|
|
inputs: [
|
|
{ name: 'input1', type: 'number' },
|
|
{ name: 'input2', type: 'number' }
|
|
]
|
|
})
|
|
|
|
const subgraphInput1 = subgraph.inputs[0]
|
|
const subgraphInput2 = subgraph.inputs[1]
|
|
|
|
expect(subgraphInput2.isValidTarget(subgraphInput1)).toBe(false)
|
|
})
|
|
|
|
it('should not connect to output slots', () => {
|
|
const subgraph = createTestSubgraph({
|
|
inputs: [{ name: 'test_input', type: 'number' }]
|
|
})
|
|
|
|
const subgraphInput = subgraph.inputs[0]
|
|
|
|
const node = new LGraphNode('TestNode')
|
|
node.addOutput('test_output', 'number')
|
|
subgraph.add(node)
|
|
const outputSlot = node.outputs[0] as NodeOutputSlot
|
|
|
|
expect(outputSlot.isValidTarget(subgraphInput)).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe.skip('SubgraphOutput connections', () => {
|
|
it('should connect from compatible regular output slots', () => {
|
|
const subgraph = createTestSubgraph()
|
|
const node = new LGraphNode('TestNode')
|
|
node.addOutput('out', 'number')
|
|
subgraph.add(node)
|
|
|
|
const subgraphOutput = subgraph.addOutput('result', 'number')
|
|
const nodeOutput = node.outputs[0]
|
|
|
|
expect(subgraphOutput.isValidTarget(nodeOutput)).toBe(true)
|
|
})
|
|
|
|
it('should connect from SubgraphInput', () => {
|
|
const subgraph = createTestSubgraph()
|
|
|
|
const subgraphInput = subgraph.addInput('value', 'number')
|
|
const subgraphOutput = subgraph.addOutput('result', 'number')
|
|
|
|
expect(subgraphOutput.isValidTarget(subgraphInput)).toBe(true)
|
|
})
|
|
|
|
it('should not connect to another SubgraphOutput', () => {
|
|
const subgraph = createTestSubgraph()
|
|
|
|
const subgraphOutput1 = subgraph.addOutput('result1', 'number')
|
|
const subgraphOutput2 = subgraph.addOutput('result2', 'number')
|
|
|
|
expect(subgraphOutput1.isValidTarget(subgraphOutput2)).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe.skip('LinkConnector dragging behavior', () => {
|
|
it('should drag existing link when dragging from input slot connected to subgraph input node', () => {
|
|
// Create a subgraph with one input
|
|
const subgraph = createTestSubgraph({
|
|
inputs: [{ name: 'input1', type: 'number' }]
|
|
})
|
|
|
|
// Create a node inside the subgraph
|
|
const internalNode = new LGraphNode('InternalNode')
|
|
internalNode.id = 100
|
|
internalNode.addInput('in', 'number')
|
|
subgraph.add(internalNode)
|
|
|
|
// Connect the subgraph input to the internal node's input
|
|
const link = subgraph.inputNode.slots[0].connect(
|
|
internalNode.inputs[0],
|
|
internalNode
|
|
)
|
|
expect(link).toBeDefined()
|
|
expect(link!.origin_id).toBe(SUBGRAPH_INPUT_ID)
|
|
expect(link!.target_id).toBe(internalNode.id)
|
|
|
|
// Verify the input slot has the link
|
|
expect(internalNode.inputs[0].link).toBe(link!.id)
|
|
|
|
// Create a LinkConnector
|
|
const setConnectingLinks = vi.fn()
|
|
const connector = new LinkConnector(setConnectingLinks)
|
|
|
|
// Now try to drag from the input slot
|
|
connector.moveInputLink(subgraph as LinkNetwork, internalNode.inputs[0])
|
|
|
|
// Verify that we're dragging the existing link
|
|
expect(connector.isConnecting).toBe(true)
|
|
expect(connector.state.connectingTo).toBe('input')
|
|
expect(connector.state.draggingExistingLinks).toBe(true)
|
|
|
|
// Check that we have exactly one render link
|
|
expect(connector.renderLinks).toHaveLength(1)
|
|
|
|
// The render link should be a ToInputFromIoNodeLink, not MovingInputLink
|
|
expect(connector.renderLinks[0]).toBeInstanceOf(ToInputFromIoNodeLink)
|
|
|
|
// The input links collection should contain our link
|
|
expect(connector.inputLinks).toHaveLength(1)
|
|
expect(connector.inputLinks[0]).toBe(link)
|
|
|
|
// Verify the link is marked as dragging
|
|
expect(link!._dragging).toBe(true)
|
|
})
|
|
})
|
|
|
|
describe.skip('Type compatibility', () => {
|
|
it('should respect type compatibility for SubgraphInput connections', () => {
|
|
const subgraph = createTestSubgraph({
|
|
inputs: [{ name: 'number_input', type: 'number' }]
|
|
})
|
|
|
|
const subgraphInput = subgraph.inputs[0]
|
|
|
|
const node = new LGraphNode('TestNode')
|
|
node.addInput('number_slot', 'number')
|
|
node.addInput('string_slot', 'string')
|
|
node.addInput('any_slot', '*')
|
|
node.addInput('boolean_slot', 'boolean')
|
|
subgraph.add(node)
|
|
|
|
const numberSlot = node.inputs[0] as NodeInputSlot
|
|
const stringSlot = node.inputs[1] as NodeInputSlot
|
|
const anySlot = node.inputs[2] as NodeInputSlot
|
|
const booleanSlot = node.inputs[3] as NodeInputSlot
|
|
|
|
expect(numberSlot.isValidTarget(subgraphInput)).toBe(true)
|
|
expect(stringSlot.isValidTarget(subgraphInput)).toBe(false)
|
|
expect(anySlot.isValidTarget(subgraphInput)).toBe(true)
|
|
expect(booleanSlot.isValidTarget(subgraphInput)).toBe(false)
|
|
})
|
|
|
|
it('should respect type compatibility for SubgraphOutput connections', () => {
|
|
const subgraph = createTestSubgraph()
|
|
const node = new LGraphNode('TestNode')
|
|
node.addOutput('out', 'string')
|
|
subgraph.add(node)
|
|
|
|
const subgraphOutput = subgraph.addOutput('result', 'number')
|
|
const nodeOutput = node.outputs[0]
|
|
|
|
expect(subgraphOutput.isValidTarget(nodeOutput)).toBe(false)
|
|
})
|
|
|
|
it('should handle wildcard SubgraphInput', () => {
|
|
const subgraph = createTestSubgraph({
|
|
inputs: [{ name: 'any_input', type: '*' }]
|
|
})
|
|
|
|
const subgraphInput = subgraph.inputs[0]
|
|
|
|
const node = new LGraphNode('TestNode')
|
|
node.addInput('number_slot', 'number')
|
|
subgraph.add(node)
|
|
|
|
const numberSlot = node.inputs[0] as NodeInputSlot
|
|
|
|
expect(numberSlot.isValidTarget(subgraphInput)).toBe(true)
|
|
})
|
|
})
|
|
|
|
describe.skip('Type guards', () => {
|
|
it('should correctly identify SubgraphInput', () => {
|
|
const subgraph = createTestSubgraph()
|
|
const subgraphInput = subgraph.addInput('value', 'number')
|
|
const node = new LGraphNode('TestNode')
|
|
node.addInput('in', 'number')
|
|
|
|
expect(isSubgraphInput(subgraphInput)).toBe(true)
|
|
expect(isSubgraphInput(node.inputs[0])).toBe(false)
|
|
expect(isSubgraphInput(null)).toBe(false)
|
|
expect(isSubgraphInput(undefined)).toBe(false)
|
|
expect(isSubgraphInput({})).toBe(false)
|
|
})
|
|
|
|
it('should correctly identify SubgraphOutput', () => {
|
|
const subgraph = createTestSubgraph()
|
|
const subgraphOutput = subgraph.addOutput('result', 'number')
|
|
const node = new LGraphNode('TestNode')
|
|
node.addOutput('out', 'number')
|
|
|
|
expect(isSubgraphOutput(subgraphOutput)).toBe(true)
|
|
expect(isSubgraphOutput(node.outputs[0])).toBe(false)
|
|
expect(isSubgraphOutput(null)).toBe(false)
|
|
expect(isSubgraphOutput(undefined)).toBe(false)
|
|
expect(isSubgraphOutput({})).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe.skip('Nested subgraphs', () => {
|
|
it('should handle dragging from SubgraphInput in nested subgraphs', () => {
|
|
const parentSubgraph = createTestSubgraph({
|
|
inputs: [{ name: 'parent_input', type: 'number' }],
|
|
outputs: [{ name: 'parent_output', type: 'number' }]
|
|
})
|
|
|
|
const nestedSubgraph = createTestSubgraph({
|
|
inputs: [{ name: 'nested_input', type: 'number' }],
|
|
outputs: [{ name: 'nested_output', type: 'number' }]
|
|
})
|
|
|
|
const nestedSubgraphNode = createTestSubgraphNode(nestedSubgraph)
|
|
parentSubgraph.add(nestedSubgraphNode)
|
|
|
|
const regularNode = new LGraphNode('TestNode')
|
|
regularNode.addInput('test_input', 'number')
|
|
nestedSubgraph.add(regularNode)
|
|
|
|
const nestedSubgraphInput = nestedSubgraph.inputs[0]
|
|
const regularNodeSlot = regularNode.inputs[0] as NodeInputSlot
|
|
|
|
expect(regularNodeSlot.isValidTarget(nestedSubgraphInput)).toBe(true)
|
|
})
|
|
|
|
it('should handle multiple levels of nesting', () => {
|
|
const level1 = createTestSubgraph({
|
|
inputs: [{ name: 'level1_input', type: 'string' }]
|
|
})
|
|
|
|
const level2 = createTestSubgraph({
|
|
inputs: [{ name: 'level2_input', type: 'string' }]
|
|
})
|
|
|
|
const level3 = createTestSubgraph({
|
|
inputs: [{ name: 'level3_input', type: 'string' }],
|
|
outputs: [{ name: 'level3_output', type: 'string' }]
|
|
})
|
|
|
|
const level2Node = createTestSubgraphNode(level2)
|
|
level1.add(level2Node)
|
|
|
|
const level3Node = createTestSubgraphNode(level3)
|
|
level2.add(level3Node)
|
|
|
|
const deepNode = new LGraphNode('DeepNode')
|
|
deepNode.addInput('deep_input', 'string')
|
|
level3.add(deepNode)
|
|
|
|
const level3Input = level3.inputs[0]
|
|
const deepNodeSlot = deepNode.inputs[0] as NodeInputSlot
|
|
|
|
expect(deepNodeSlot.isValidTarget(level3Input)).toBe(true)
|
|
|
|
const level3Output = level3.outputs[0]
|
|
expect(level3Output.isValidTarget(level3Input)).toBe(true)
|
|
})
|
|
|
|
it('should maintain type checking across nesting levels', () => {
|
|
const outer = createTestSubgraph({
|
|
inputs: [{ name: 'outer_number', type: 'number' }]
|
|
})
|
|
|
|
const inner = createTestSubgraph({
|
|
inputs: [
|
|
{ name: 'inner_number', type: 'number' },
|
|
{ name: 'inner_string', type: 'string' }
|
|
]
|
|
})
|
|
|
|
const innerNode = createTestSubgraphNode(inner)
|
|
outer.add(innerNode)
|
|
|
|
const node = new LGraphNode('TestNode')
|
|
node.addInput('number_slot', 'number')
|
|
node.addInput('string_slot', 'string')
|
|
inner.add(node)
|
|
|
|
const innerNumberInput = inner.inputs[0]
|
|
const innerStringInput = inner.inputs[1]
|
|
const numberSlot = node.inputs[0] as NodeInputSlot
|
|
const stringSlot = node.inputs[1] as NodeInputSlot
|
|
|
|
expect(numberSlot.isValidTarget(innerNumberInput)).toBe(true)
|
|
expect(numberSlot.isValidTarget(innerStringInput)).toBe(false)
|
|
expect(stringSlot.isValidTarget(innerNumberInput)).toBe(false)
|
|
expect(stringSlot.isValidTarget(innerStringInput)).toBe(true)
|
|
})
|
|
})
|
|
})
|