mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-31 05:19:53 +00:00
* refactor: move settingStore to platform/settings Move src/stores/settingStore.ts to src/platform/settings/settingStore.ts to separate platform infrastructure from domain logic following DDD principles. Updates all import references across ~70 files to maintain compatibility. * fix: update remaining settingStore imports after rebase * fix: complete remaining settingStore import updates * fix: update vi.mock paths for settingStore in tests Update all test files to mock the new settingStore location at @/platform/settings/settingStore instead of @/stores/settingStore * fix: resolve remaining settingStore imports and unused imports after rebase * fix: update settingStore mock path in SelectionToolbox test Fix vi.mock path from @/stores/settingStore to @/platform/settings/settingStore to resolve failing Load3D viewer button test. * refactor: complete comprehensive settings migration to platform layer This commit completes the migration of all settings-related code to the platform layer as part of the Domain-Driven Design (DDD) architecture refactoring. - constants/coreSettings.ts → platform/settings/constants/coreSettings.ts - types/settingTypes.ts → platform/settings/types.ts - stores/settingStore.ts → platform/settings/settingStore.ts (already moved) - composables/setting/useSettingUI.ts → platform/settings/composables/useSettingUI.ts - composables/setting/useSettingSearch.ts → platform/settings/composables/useSettingSearch.ts - composables/useLitegraphSettings.ts → platform/settings/composables/useLitegraphSettings.ts - components/dialog/content/SettingDialogContent.vue → platform/settings/components/SettingDialogContent.vue - components/dialog/content/setting/SettingItem.vue → platform/settings/components/SettingItem.vue - components/dialog/content/setting/SettingGroup.vue → platform/settings/components/SettingGroup.vue - components/dialog/content/setting/SettingsPanel.vue → platform/settings/components/SettingsPanel.vue - components/dialog/content/setting/ColorPaletteMessage.vue → platform/settings/components/ColorPaletteMessage.vue - components/dialog/content/setting/ExtensionPanel.vue → platform/settings/components/ExtensionPanel.vue - components/dialog/content/setting/ServerConfigPanel.vue → platform/settings/components/ServerConfigPanel.vue - ~100+ import statements updated across the codebase - Test file imports corrected - Component imports fixed in dialog service and command menubar - Composable imports updated in GraphCanvas.vue ``` src/platform/settings/ ├── components/ # All settings UI components ├── composables/ # Settings-related composables ├── constants/ # Core settings definitions ├── types.ts # Settings type definitions └── settingStore.ts # Central settings state management ``` ✅ TypeScript compilation successful ✅ All tests passing (settings store, search functionality, UI components) ✅ Production build successful ✅ Domain boundaries properly established This migration consolidates all settings functionality into a cohesive platform domain, improving maintainability and following DDD principles for better code organization. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: format and lint after rebase conflict resolution * fix: update remaining import paths to platform settings - Fix browser test import: extensionAPI.spec.ts - Fix script import: collect-i18n-general.ts - Complete settings migration import path updates 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
138 lines
3.9 KiB
TypeScript
138 lines
3.9 KiB
TypeScript
import { createPinia, setActivePinia } from 'pinia'
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import type NodeSearchBoxPopover from '@/components/searchbox/NodeSearchBoxPopover.vue'
|
|
import type { useSettingStore } from '@/platform/settings/settingStore'
|
|
import { useSearchBoxStore } from '@/stores/workspace/searchBoxStore'
|
|
|
|
// Mock dependencies
|
|
vi.mock('@vueuse/core', () => ({
|
|
useMouse: vi.fn(() => ({
|
|
x: { value: 100 },
|
|
y: { value: 200 }
|
|
}))
|
|
}))
|
|
|
|
const mockSettingStore = createMockSettingStore()
|
|
vi.mock('@/platform/settings/settingStore', () => ({
|
|
useSettingStore: vi.fn(() => mockSettingStore)
|
|
}))
|
|
|
|
function createMockPopover(): InstanceType<typeof NodeSearchBoxPopover> {
|
|
return { showSearchBox: vi.fn() } satisfies Partial<
|
|
InstanceType<typeof NodeSearchBoxPopover>
|
|
> as unknown as InstanceType<typeof NodeSearchBoxPopover>
|
|
}
|
|
|
|
function createMockSettingStore(): ReturnType<typeof useSettingStore> {
|
|
return {
|
|
get: vi.fn()
|
|
} satisfies Partial<
|
|
ReturnType<typeof useSettingStore>
|
|
> as unknown as ReturnType<typeof useSettingStore>
|
|
}
|
|
|
|
describe('useSearchBoxStore', () => {
|
|
beforeEach(() => {
|
|
setActivePinia(createPinia())
|
|
|
|
vi.restoreAllMocks()
|
|
})
|
|
|
|
describe('when user has new search box enabled', () => {
|
|
beforeEach(() => {
|
|
vi.mocked(mockSettingStore.get).mockReturnValue('default')
|
|
})
|
|
|
|
it('should show new search box is enabled', () => {
|
|
const store = useSearchBoxStore()
|
|
expect(store.newSearchBoxEnabled).toBe(true)
|
|
})
|
|
|
|
it('should toggle search box visibility when user presses shortcut', () => {
|
|
const store = useSearchBoxStore()
|
|
|
|
expect(store.visible).toBe(false)
|
|
|
|
store.toggleVisible()
|
|
expect(store.visible).toBe(true)
|
|
|
|
store.toggleVisible()
|
|
expect(store.visible).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe('when user has legacy search box enabled', () => {
|
|
beforeEach(() => {
|
|
vi.mocked(mockSettingStore.get).mockReturnValue('legacy')
|
|
})
|
|
|
|
it('should show new search box is disabled', () => {
|
|
const store = useSearchBoxStore()
|
|
expect(store.newSearchBoxEnabled).toBe(false)
|
|
})
|
|
|
|
it('should open legacy search box at mouse position when user presses shortcut', () => {
|
|
const store = useSearchBoxStore()
|
|
const mockPopover = createMockPopover()
|
|
store.setPopoverRef(mockPopover)
|
|
|
|
expect(vi.mocked(store.visible)).toBe(false)
|
|
|
|
store.toggleVisible()
|
|
|
|
expect(vi.mocked(store.visible)).toBe(false) // Doesn't become visible in legacy mode.
|
|
|
|
expect(vi.mocked(mockPopover.showSearchBox)).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
clientX: 100,
|
|
clientY: 200
|
|
})
|
|
)
|
|
})
|
|
|
|
it('should do nothing when user presses shortcut but popover is not ready', () => {
|
|
const store = useSearchBoxStore()
|
|
store.setPopoverRef(null)
|
|
|
|
store.toggleVisible()
|
|
|
|
expect(store.visible).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe('when user configures popover reference', () => {
|
|
beforeEach(() => {
|
|
vi.mocked(mockSettingStore.get).mockReturnValue('legacy')
|
|
})
|
|
|
|
it('should enable legacy search when popover is set', () => {
|
|
const store = useSearchBoxStore()
|
|
const mockPopover = createMockPopover()
|
|
store.setPopoverRef(mockPopover)
|
|
|
|
store.toggleVisible()
|
|
|
|
expect(vi.mocked(mockPopover.showSearchBox)).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should disable legacy search when popover is cleared', () => {
|
|
const store = useSearchBoxStore()
|
|
const mockPopover = createMockPopover()
|
|
store.setPopoverRef(mockPopover)
|
|
store.setPopoverRef(null)
|
|
|
|
store.toggleVisible()
|
|
|
|
expect(vi.mocked(mockPopover.showSearchBox)).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
|
|
describe('when user first loads the application', () => {
|
|
it('should have search box hidden by default', () => {
|
|
const store = useSearchBoxStore()
|
|
expect(store.visible).toBe(false)
|
|
})
|
|
})
|
|
})
|