mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-22 13:32:11 +00:00
b578147714
## Summary - Add `unmapped` to genhtml `--ignore-errors` flag to fix GH Pages deploy failure - Remove unreachable placeholder block (dead code cleanup) ## Problem PR #11381 added `--ignore-errors source` but genhtml is now failing with a different error: ``` genhtml: ERROR: no data for line:4291, TLA:GNC, file:src/lib/litegraph/src/LGraphNode.ts (use "genhtml --ignore-errors unmapped ..." to bypass this error) ``` This happens when LCOV data references lines that don't map to source (from V8 coverage instrumentation). ## Changes 1. **Add `unmapped` to ignore-errors** — `--ignore-errors source,unmapped` handles both missing source files and unmapped line data 2. **Remove unreachable placeholder block** — The `if [ ! -s coverage/playwright/coverage.lcov ]` check is dead code because the step is already gated on `has-coverage == 'true'`, which only triggers when the merged LCOV exists and is non-empty ## Test plan - [ ] Verify workflow completes successfully on next push to main - [ ] Verify https://comfy-org.github.io/ComfyUI_frontend/ returns 200 Fixes #12229 🤖 Generated with [Claude Code](https://claude.com/claude-code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12273-fix-ci-add-unmapped-to-genhtml-ignore-errors-remove-unreachable-placeholder-3606d73d36508198a4ffddfce3354d4a) by [Unito](https://www.unito.io) --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: GitHub Action <action@github.com>
GitHub Workflows
Naming Convention
Workflow files follow a consistent naming pattern: <prefix>-<descriptive-name>.yaml
Category Prefixes
| Prefix | Purpose | Example |
|---|---|---|
ci- |
Testing, linting, validation | ci-tests-e2e.yaml |
release- |
Version management, publishing | release-version-bump.yaml |
pr- |
PR automation (triggered by labels) | pr-claude-review.yaml |
api- |
External Api type generation | api-update-registry-api-types.yaml |
i18n- |
Internationalization updates | i18n-update-core.yaml |
Documentation
Each workflow file contains comments explaining its purpose, triggers, and behavior. For specific details about what each workflow does, refer to the comments at the top of each .yaml file.
For GitHub Actions documentation, see Events that trigger workflows.