mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
*PR Created by the Glary-Bot Agent* --- ## Summary - Replace all `as unknown as Type` assertions in 59 unit test files with type-safe `@total-typescript/shoehorn` functions - Use `fromPartial<Type>()` for partial mock objects where deep-partial type-checks (21 files) - Use `fromAny<Type>()` for fundamentally incompatible types: null, undefined, primitives, variables, class expressions, and mocks with test-specific extra properties that `PartialDeepObject` rejects (remaining files) - All explicit type parameters preserved so TypeScript return types are correct - Browser test `.spec.ts` files excluded (shoehorn unavailable in `page.evaluate` browser context) ## Verification - `pnpm typecheck` ✅ - `pnpm lint` ✅ - `pnpm format` ✅ - Pre-commit hooks passed (format + oxlint + eslint + typecheck) - Migrated test files verified passing (ran representative subset) - No test behavior changes — only type assertion syntax changed - No UI changes — screenshots not applicable ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10761-test-migrate-as-unknown-as-to-total-typescript-shoehorn-3336d73d365081f6b8adc44db5dcc380) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
185 lines
5.4 KiB
TypeScript
185 lines
5.4 KiB
TypeScript
import { createTestingPinia } from '@pinia/testing'
|
|
import { fromAny, fromPartial } from '@total-typescript/shoehorn'
|
|
import { setActivePinia } from 'pinia'
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import type { LGraphNode } from '@/lib/litegraph/src/litegraph'
|
|
import { api } from '@/scripts/api'
|
|
import { app } from '@/scripts/app'
|
|
import { useNodeOutputStore } from '@/stores/nodeOutputStore'
|
|
import { useMaskEditorSaver } from './useMaskEditorSaver'
|
|
|
|
// ---- Module Mocks ----
|
|
|
|
const mockDataStore: Record<string, unknown> = {
|
|
sourceNode: null,
|
|
inputData: null,
|
|
outputData: null
|
|
}
|
|
|
|
vi.mock('@/stores/maskEditorDataStore', () => ({
|
|
useMaskEditorDataStore: vi.fn(() => mockDataStore)
|
|
}))
|
|
|
|
function createMockCtx(): CanvasRenderingContext2D {
|
|
return fromPartial<CanvasRenderingContext2D>({
|
|
drawImage: vi.fn(),
|
|
getImageData: vi.fn(() => ({
|
|
data: new Uint8ClampedArray(4 * 4 * 4),
|
|
width: 4,
|
|
height: 4
|
|
})),
|
|
putImageData: vi.fn(),
|
|
globalCompositeOperation: 'source-over'
|
|
})
|
|
}
|
|
|
|
function createMockCanvas(): HTMLCanvasElement {
|
|
return fromPartial<HTMLCanvasElement>({
|
|
width: 4,
|
|
height: 4,
|
|
getContext: vi.fn(() => createMockCtx()),
|
|
toBlob: vi.fn((cb: BlobCallback) => {
|
|
cb(new Blob(['x'], { type: 'image/png' }))
|
|
}),
|
|
toDataURL: vi.fn(() => 'data:image/png;base64,mock')
|
|
})
|
|
}
|
|
|
|
const mockEditorStore: Record<string, HTMLCanvasElement | null> = {
|
|
maskCanvas: null,
|
|
rgbCanvas: null,
|
|
imgCanvas: null
|
|
}
|
|
|
|
vi.mock('@/stores/maskEditorStore', () => ({
|
|
useMaskEditorStore: vi.fn(() => mockEditorStore)
|
|
}))
|
|
|
|
vi.mock('@/scripts/api', () => ({
|
|
api: {
|
|
fetchApi: vi.fn(),
|
|
apiURL: vi.fn((route: string) => `http://localhost:8188${route}`)
|
|
}
|
|
}))
|
|
|
|
vi.mock('@/scripts/app', () => ({
|
|
app: {
|
|
canvas: { setDirty: vi.fn() },
|
|
nodeOutputs: {} as Record<string, unknown>,
|
|
nodePreviewImages: {} as Record<string, string[]>,
|
|
getPreviewFormatParam: vi.fn(() => ''),
|
|
getRandParam: vi.fn(() => '')
|
|
}
|
|
}))
|
|
|
|
vi.mock('@/platform/distribution/types', () => ({ isCloud: false }))
|
|
|
|
vi.mock('@/platform/workflow/management/stores/workflowStore', () => ({
|
|
useWorkflowStore: vi.fn(() => ({
|
|
nodeIdToNodeLocatorId: vi.fn((id: string | number) => String(id)),
|
|
nodeToNodeLocatorId: vi.fn((node: { id: number }) => String(node.id))
|
|
}))
|
|
}))
|
|
|
|
vi.mock('@/utils/graphTraversalUtil', () => ({
|
|
executionIdToNodeLocatorId: vi.fn((_rootGraph: unknown, id: string) => id)
|
|
}))
|
|
|
|
describe('useMaskEditorSaver', () => {
|
|
let mockNode: LGraphNode
|
|
const originalCreateElement = document.createElement.bind(document)
|
|
|
|
beforeEach(() => {
|
|
setActivePinia(createTestingPinia({ stubActions: false }))
|
|
vi.clearAllMocks()
|
|
|
|
app.nodeOutputs = {}
|
|
app.nodePreviewImages = {}
|
|
|
|
mockNode = fromAny<LGraphNode, unknown>({
|
|
id: 42,
|
|
type: 'LoadImage',
|
|
images: [],
|
|
imgs: undefined,
|
|
widgets: [
|
|
{ name: 'image', value: 'original.png [input]', callback: vi.fn() }
|
|
],
|
|
widgets_values: ['original.png [input]'],
|
|
properties: { image: 'original.png [input]' },
|
|
graph: { setDirtyCanvas: vi.fn() }
|
|
})
|
|
|
|
mockDataStore.sourceNode = mockNode
|
|
mockDataStore.inputData = {
|
|
baseLayer: { image: {} as HTMLImageElement, url: 'base.png' },
|
|
maskLayer: { image: {} as HTMLImageElement, url: 'mask.png' },
|
|
sourceRef: { filename: 'original.png', subfolder: '', type: 'input' },
|
|
nodeId: 42
|
|
}
|
|
mockDataStore.outputData = null
|
|
|
|
mockEditorStore.maskCanvas = createMockCanvas()
|
|
mockEditorStore.rgbCanvas = createMockCanvas()
|
|
mockEditorStore.imgCanvas = createMockCanvas()
|
|
|
|
vi.mocked(api.fetchApi).mockResolvedValue({
|
|
ok: true,
|
|
json: () =>
|
|
Promise.resolve({
|
|
name: 'clipspace-painted-masked-123.png',
|
|
subfolder: 'clipspace',
|
|
type: 'input'
|
|
})
|
|
} as Response)
|
|
|
|
vi.spyOn(document, 'createElement').mockImplementation(
|
|
(tagName: string, options?: ElementCreationOptions) => {
|
|
if (tagName === 'canvas')
|
|
return fromAny<HTMLCanvasElement, unknown>(createMockCanvas())
|
|
return originalCreateElement(tagName, options)
|
|
}
|
|
)
|
|
|
|
// Mock Image constructor so loadImageFromUrl resolves
|
|
vi.stubGlobal(
|
|
'Image',
|
|
class MockImage {
|
|
crossOrigin = ''
|
|
onload: ((ev: Event) => void) | null = null
|
|
onerror: ((ev: unknown) => void) | null = null
|
|
private _src = ''
|
|
get src() {
|
|
return this._src
|
|
}
|
|
set src(value: string) {
|
|
this._src = value
|
|
queueMicrotask(() => this.onload?.(new Event('load')))
|
|
}
|
|
}
|
|
)
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.restoreAllMocks()
|
|
})
|
|
|
|
it('registers node outputs in store after save for node without prior execution outputs', async () => {
|
|
const store = useNodeOutputStore()
|
|
const locatorId = String(mockNode.id)
|
|
|
|
// Precondition: node has never been executed, no outputs exist
|
|
expect(app.nodeOutputs[locatorId]).toBeUndefined()
|
|
|
|
const { save } = useMaskEditorSaver()
|
|
await save()
|
|
|
|
// After mask editor save, the node must have outputs in the store
|
|
// so the image preview displays correctly (not blank).
|
|
// Bug: the old code used updateNodeImages which silently no-ops
|
|
// when there are no pre-existing outputs for the node.
|
|
expect(store.nodeOutputs[locatorId]).toBeDefined()
|
|
expect(store.nodeOutputs[locatorId]?.images?.length).toBeGreaterThan(0)
|
|
})
|
|
})
|