mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-21 15:24:09 +00:00
6ee3803770
## Summary Implement a redesigned Node Library sidebar using Reka UI components with virtualized tree rendering and improved UX. ## Changes - **What**: - Add three-tab structure (Essential, All, Custom) using Reka UI Tabs - Implement TreeExplorerV2 with virtualized tree using TreeRoot/TreeVirtualizer for performance - Add node hover preview with teleport to show NodePreview component - Implement context menu for toggling favorites on nodes - Add search functionality that auto-expands matching folders - Create panel components: EssentialNodesPanel, AllNodesPanel, CustomNodesPanel - Add 'Open Manager' button in CustomNodesPanel - Use custom icons: comfy--node for nodes, ph--folder-fill for folders - New node preview component: `NodePreviewCard` - Api node folder icon - Node drag preview - **Feature Flag**: Enabled via URL parameter `?nodeRedesign=true` ## Review Focus - TreeExplorerV2.vue uses `[...expandedKeys]` to prevent internal mutation by Reka UI TreeRoot - Context menu injection key is exported from TreeExplorerV2Node.vue and imported by TreeExplorerV2.vue - Hover preview uses teleport to `#node-library-node-preview-container-v2` ## Screenshots (if applicable) | Feature | Screenshot | |---|---| | All nodes tab |<img width="323" height="761" alt="image" src="https://github.com/user-attachments/assets/1976222b-83dc-4a1b-838a-2d49aedea3b8" />| | Custom nodes tab | <img width="308" height="748" alt="image" src="https://github.com/user-attachments/assets/2c23bffb-bdaa-4c6c-8cac-7610fb7f3fb7" />| |Api nodes icon | <img width="299" height="523" alt="image" src="https://github.com/user-attachments/assets/e9ca05b0-1143-44cf-b227-6462173c7cd0" />| | node preview|<img width="499" height="544" alt="image" src="https://github.com/user-attachments/assets/8961a7b4-77ae-4e57-99cf-62d9e4e17088" />| | node drag preview | <img width="434" height="289" alt="image" src="https://github.com/user-attachments/assets/b5838c90-65d4-4bee-b2b3-c41b57870da8" />| Test by adding `?nodeRedesign=true` to the URL ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8548-WIP-feat-implement-NodeLibrarySidebarTabV2-with-Reka-UI-components-2fb6d73d36508134b7e0f75a2c9b976a) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
95 lines
3.1 KiB
TypeScript
95 lines
3.1 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../../fixtures/ComfyPage'
|
|
import { TestIds } from '../../fixtures/selectors'
|
|
|
|
test.describe('Properties panel position', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.NodeLibrary.NewDesign', false)
|
|
// Open a sidebar tab to ensure sidebar is visible
|
|
await comfyPage.menu.nodeLibraryTab.open()
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
})
|
|
|
|
test('positions on the right when sidebar is on the left', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'left')
|
|
await comfyPage.nextFrame()
|
|
|
|
const propertiesPanel = comfyPage.page.getByTestId(
|
|
TestIds.propertiesPanel.root
|
|
)
|
|
const sidebar = comfyPage.page.locator('.side-bar-panel').first()
|
|
|
|
await expect(propertiesPanel).toBeVisible()
|
|
await expect(sidebar).toBeVisible()
|
|
|
|
const propsBoundingBox = await propertiesPanel.boundingBox()
|
|
const sidebarBoundingBox = await sidebar.boundingBox()
|
|
|
|
expect(propsBoundingBox).not.toBeNull()
|
|
expect(sidebarBoundingBox).not.toBeNull()
|
|
|
|
// Properties panel should be to the right of the sidebar
|
|
expect(propsBoundingBox!.x).toBeGreaterThan(
|
|
sidebarBoundingBox!.x + sidebarBoundingBox!.width
|
|
)
|
|
})
|
|
|
|
test('positions on the left when sidebar is on the right', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'right')
|
|
await comfyPage.nextFrame()
|
|
|
|
const propertiesPanel = comfyPage.page.getByTestId(
|
|
TestIds.propertiesPanel.root
|
|
)
|
|
const sidebar = comfyPage.page.locator('.side-bar-panel').first()
|
|
|
|
await expect(propertiesPanel).toBeVisible()
|
|
await expect(sidebar).toBeVisible()
|
|
|
|
const propsBoundingBox = await propertiesPanel.boundingBox()
|
|
const sidebarBoundingBox = await sidebar.boundingBox()
|
|
|
|
expect(propsBoundingBox).not.toBeNull()
|
|
expect(sidebarBoundingBox).not.toBeNull()
|
|
|
|
// Properties panel should be to the left of the sidebar
|
|
expect(propsBoundingBox!.x + propsBoundingBox!.width).toBeLessThan(
|
|
sidebarBoundingBox!.x
|
|
)
|
|
})
|
|
|
|
test('close button icon updates based on sidebar location', async ({
|
|
comfyPage
|
|
}) => {
|
|
const propertiesPanel = comfyPage.page.getByTestId(
|
|
TestIds.propertiesPanel.root
|
|
)
|
|
|
|
// When sidebar is on the left, panel is on the right
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'left')
|
|
await comfyPage.nextFrame()
|
|
|
|
await expect(propertiesPanel).toBeVisible()
|
|
const closeButtonLeft = propertiesPanel
|
|
.locator('button[aria-pressed]')
|
|
.locator('i')
|
|
await expect(closeButtonLeft).toBeVisible()
|
|
await expect(closeButtonLeft).toHaveClass(/lucide--panel-right/)
|
|
|
|
// When sidebar is on the right, panel is on the left
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'right')
|
|
await comfyPage.nextFrame()
|
|
|
|
const closeButtonRight = propertiesPanel
|
|
.locator('button[aria-pressed]')
|
|
.locator('i')
|
|
await expect(closeButtonRight).toBeVisible()
|
|
await expect(closeButtonRight).toHaveClass(/lucide--panel-left/)
|
|
})
|
|
})
|