mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-04 15:10:06 +00:00
f2d5bfab73
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
57 lines
2.0 KiB
TypeScript
57 lines
2.0 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe('Execution', { tag: ['@smoke', '@workflow'] }, () => {
|
|
test(
|
|
'Report error on unconnected slot',
|
|
{ tag: '@screenshot' },
|
|
async ({ comfyPage }) => {
|
|
await comfyPage.canvasOps.disconnectEdge()
|
|
await comfyPage.canvasOps.clickEmptySpace()
|
|
|
|
await comfyPage.command.executeCommand('Comfy.QueuePrompt')
|
|
await expect(comfyPage.page.locator('.comfy-error-report')).toBeVisible()
|
|
await comfyPage.page
|
|
.locator('.p-dialog')
|
|
.getByRole('button', { name: 'Close' })
|
|
.click()
|
|
await comfyPage.page.locator('.comfy-error-report').waitFor({
|
|
state: 'hidden'
|
|
})
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'execution-error-unconnected-slot.png'
|
|
)
|
|
}
|
|
)
|
|
})
|
|
|
|
test.describe(
|
|
'Execute to selected output nodes',
|
|
{ tag: ['@smoke', '@workflow'] },
|
|
() => {
|
|
test('Execute to selected output nodes', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('execution/partial_execution')
|
|
const input = await comfyPage.nodeOps.getNodeRefById(3)
|
|
const output1 = await comfyPage.nodeOps.getNodeRefById(1)
|
|
const output2 = await comfyPage.nodeOps.getNodeRefById(4)
|
|
expect(await (await input.getWidget(0)).getValue()).toBe('foo')
|
|
expect(await (await output1.getWidget(0)).getValue()).toBe('')
|
|
expect(await (await output2.getWidget(0)).getValue()).toBe('')
|
|
|
|
await output1.click('title')
|
|
|
|
await comfyPage.command.executeCommand('Comfy.QueueSelectedOutputNodes')
|
|
await expect(async () => {
|
|
expect(await (await input.getWidget(0)).getValue()).toBe('foo')
|
|
expect(await (await output1.getWidget(0)).getValue()).toBe('foo')
|
|
expect(await (await output2.getWidget(0)).getValue()).toBe('')
|
|
}).toPass({ timeout: 2_000 })
|
|
})
|
|
}
|
|
)
|