mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-04 23:20:07 +00:00
f2d5bfab73
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
94 lines
3.1 KiB
TypeScript
94 lines
3.1 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../../fixtures/ComfyPage'
|
|
import { TestIds } from '../../fixtures/selectors'
|
|
|
|
test.describe('Properties panel position', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
// Open a sidebar tab to ensure sidebar is visible
|
|
await comfyPage.menu.nodeLibraryTab.open()
|
|
await comfyPage.actionbar.propertiesButton.click()
|
|
})
|
|
|
|
test('positions on the right when sidebar is on the left', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'left')
|
|
await comfyPage.nextFrame()
|
|
|
|
const propertiesPanel = comfyPage.page.getByTestId(
|
|
TestIds.propertiesPanel.root
|
|
)
|
|
const sidebar = comfyPage.page.locator('.side-bar-panel').first()
|
|
|
|
await expect(propertiesPanel).toBeVisible()
|
|
await expect(sidebar).toBeVisible()
|
|
|
|
const propsBoundingBox = await propertiesPanel.boundingBox()
|
|
const sidebarBoundingBox = await sidebar.boundingBox()
|
|
|
|
expect(propsBoundingBox).not.toBeNull()
|
|
expect(sidebarBoundingBox).not.toBeNull()
|
|
|
|
// Properties panel should be to the right of the sidebar
|
|
expect(propsBoundingBox!.x).toBeGreaterThan(
|
|
sidebarBoundingBox!.x + sidebarBoundingBox!.width
|
|
)
|
|
})
|
|
|
|
test('positions on the left when sidebar is on the right', async ({
|
|
comfyPage
|
|
}) => {
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'right')
|
|
await comfyPage.nextFrame()
|
|
|
|
const propertiesPanel = comfyPage.page.getByTestId(
|
|
TestIds.propertiesPanel.root
|
|
)
|
|
const sidebar = comfyPage.page.locator('.side-bar-panel').first()
|
|
|
|
await expect(propertiesPanel).toBeVisible()
|
|
await expect(sidebar).toBeVisible()
|
|
|
|
const propsBoundingBox = await propertiesPanel.boundingBox()
|
|
const sidebarBoundingBox = await sidebar.boundingBox()
|
|
|
|
expect(propsBoundingBox).not.toBeNull()
|
|
expect(sidebarBoundingBox).not.toBeNull()
|
|
|
|
// Properties panel should be to the left of the sidebar
|
|
expect(propsBoundingBox!.x + propsBoundingBox!.width).toBeLessThan(
|
|
sidebarBoundingBox!.x
|
|
)
|
|
})
|
|
|
|
test('close button icon updates based on sidebar location', async ({
|
|
comfyPage
|
|
}) => {
|
|
const propertiesPanel = comfyPage.page.getByTestId(
|
|
TestIds.propertiesPanel.root
|
|
)
|
|
|
|
// When sidebar is on the left, panel is on the right
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'left')
|
|
await comfyPage.nextFrame()
|
|
|
|
await expect(propertiesPanel).toBeVisible()
|
|
const closeButtonLeft = propertiesPanel
|
|
.locator('button[aria-pressed]')
|
|
.locator('i')
|
|
await expect(closeButtonLeft).toBeVisible()
|
|
await expect(closeButtonLeft).toHaveClass(/lucide--panel-right/)
|
|
|
|
// When sidebar is on the right, panel is on the left
|
|
await comfyPage.settings.setSetting('Comfy.Sidebar.Location', 'right')
|
|
await comfyPage.nextFrame()
|
|
|
|
const closeButtonRight = propertiesPanel
|
|
.locator('button[aria-pressed]')
|
|
.locator('i')
|
|
await expect(closeButtonRight).toBeVisible()
|
|
await expect(closeButtonRight).toHaveClass(/lucide--panel-left/)
|
|
})
|
|
})
|