mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-04 15:10:06 +00:00
## Summary Major refactoring of browser tests to improve reliability, maintainability, and type safety. ## Changes ### Test Infrastructure Decomposition - Decomposed `ComfyPage.ts` (~1000 lines) into focused helpers: - `CanvasHelper`, `DebugHelper`, `SubgraphHelper`, `NodeOperationsHelper` - `SettingsHelper`, `WorkflowHelper`, `ClipboardHelper`, `KeyboardHelper` - Created `ContextMenu` page object, `BaseDialog` base class, and `BottomPanel` page object - Extracted `DefaultGraphPositions` constants ### Locator Stability - Added `data-testid` attributes to Vue components (sidebar, dialogs, node library) - Created centralized `selectors.ts` with test ID constants - Replaced fragile CSS selectors (`.nth()`, `:nth-child()`) with `getByTestId`/`getByRole` ### Performance & Reliability - Removed `setTimeout` anti-patterns (replaced with `waitForFunction`) - Replaced `waitForTimeout` with retrying assertions - Replaced hardcoded coordinates with computed `NodeReference` positions - Enforced LF line endings for all text files ### Type Safety - Enabled `no-explicit-any` lint rule for browser_tests via oxlint - Purged `as any` casts from browser_tests - Added Window type augmentation for standardized window access - Added proper type annotations throughout ### Bug Fixes - Restored `ExtensionManager` API contract - Removed test-only settings from production schema - Fixed flaky selectors and missing test setup ## Testing - All browser tests pass - Typecheck passes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Overhauled browser E2E test infrastructure with many new helpers/fixtures, updated test APIs, and CI test container image bumped for consistency. * **Chores** * Standardized line endings and applied stricter lint rules for browser tests; workspace dependency version updated. * **Documentation** * Updated Playwright and TypeScript testing guidance and test-run commands. * **UI** * Added stable data-testids to multiple components to improve testability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
134 lines
4.5 KiB
TypeScript
134 lines
4.5 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
import { getMiddlePoint } from '../fixtures/utils/litegraphUtils'
|
|
|
|
test.describe('Reroute Node', { tag: ['@screenshot', '@node'] }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
})
|
|
|
|
test.afterEach(async ({ comfyPage }) => {
|
|
await comfyPage.workflow.setupWorkflowsDirectory({})
|
|
})
|
|
|
|
test('loads from inserted workflow', async ({ comfyPage }) => {
|
|
const workflowName = 'single_connected_reroute_node.json'
|
|
await comfyPage.workflow.setupWorkflowsDirectory({
|
|
[workflowName]: 'links/single_connected_reroute_node.json'
|
|
})
|
|
await comfyPage.setup()
|
|
await comfyPage.menu.topbar.triggerTopbarCommand(['New'])
|
|
|
|
// Insert the workflow
|
|
const workflowsTab = comfyPage.menu.workflowsTab
|
|
await workflowsTab.open()
|
|
await workflowsTab.getPersistedItem(workflowName).click({ button: 'right' })
|
|
const insertButton = comfyPage.page.locator('.p-contextmenu-item-link', {
|
|
hasText: 'Insert'
|
|
})
|
|
await insertButton.click()
|
|
|
|
// Close the sidebar tab
|
|
await workflowsTab.tabButton.click()
|
|
await workflowsTab.root.waitFor({ state: 'hidden' })
|
|
await comfyPage.setFocusMode(true)
|
|
|
|
await expect(comfyPage.canvas).toHaveScreenshot('reroute_inserted.png')
|
|
})
|
|
})
|
|
|
|
test.describe(
|
|
'LiteGraph Native Reroute Node',
|
|
{ tag: ['@screenshot', '@node'] },
|
|
() => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
await comfyPage.settings.setSetting('LiteGraph.Reroute.SplineOffset', 80)
|
|
})
|
|
|
|
test('loads from workflow', async ({ comfyPage }) => {
|
|
await comfyPage.workflow.loadWorkflow('reroute/native_reroute')
|
|
await expect(comfyPage.canvas).toHaveScreenshot('native_reroute.png')
|
|
})
|
|
|
|
test('@2x @0.5x Can add reroute by alt clicking on link', async ({
|
|
comfyPage
|
|
}) => {
|
|
const loadCheckpointNode = (
|
|
await comfyPage.nodeOps.getNodeRefsByTitle('Load Checkpoint')
|
|
)[0]
|
|
const clipEncodeNode = (
|
|
await comfyPage.nodeOps.getNodeRefsByTitle('CLIP Text Encode (Prompt)')
|
|
)[0]
|
|
|
|
const slot1 = await loadCheckpointNode.getOutput(1)
|
|
const slot2 = await clipEncodeNode.getInput(0)
|
|
const middlePoint = getMiddlePoint(
|
|
await slot1.getPosition(),
|
|
await slot2.getPosition()
|
|
)
|
|
|
|
await comfyPage.page.keyboard.down('Alt')
|
|
await comfyPage.page.mouse.click(middlePoint.x, middlePoint.y)
|
|
await comfyPage.page.keyboard.up('Alt')
|
|
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'native_reroute_alt_click.png'
|
|
)
|
|
})
|
|
|
|
test('Can add reroute by clicking middle of link context menu', async ({
|
|
comfyPage
|
|
}) => {
|
|
const loadCheckpointNode = (
|
|
await comfyPage.nodeOps.getNodeRefsByTitle('Load Checkpoint')
|
|
)[0]
|
|
const clipEncodeNode = (
|
|
await comfyPage.nodeOps.getNodeRefsByTitle('CLIP Text Encode (Prompt)')
|
|
)[0]
|
|
|
|
const slot1 = await loadCheckpointNode.getOutput(1)
|
|
const slot2 = await clipEncodeNode.getInput(0)
|
|
const middlePoint = getMiddlePoint(
|
|
await slot1.getPosition(),
|
|
await slot2.getPosition()
|
|
)
|
|
|
|
await comfyPage.page.mouse.click(middlePoint.x, middlePoint.y)
|
|
await comfyPage.page
|
|
.locator('.litecontextmenu .litemenu-entry', { hasText: 'Add Reroute' })
|
|
.click()
|
|
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'native_reroute_context_menu.png'
|
|
)
|
|
})
|
|
|
|
test('Can delete link that is connected to two reroutes', async ({
|
|
comfyPage
|
|
}) => {
|
|
// https://github.com/Comfy-Org/ComfyUI_frontend/issues/4695
|
|
await comfyPage.workflow.loadWorkflow(
|
|
'reroute/single-native-reroute-default-workflow'
|
|
)
|
|
|
|
// To find the clickable midpoint button, we use the hardcoded value from the browser logs
|
|
// since the link is a bezier curve and not a straight line.
|
|
const middlePoint = { x: 359.4188232421875, y: 468.7716979980469 }
|
|
|
|
// Click the middle point of the link to open the context menu.
|
|
await comfyPage.page.mouse.click(middlePoint.x, middlePoint.y)
|
|
|
|
// Click the "Delete" context menu option.
|
|
await comfyPage.page
|
|
.locator('.litecontextmenu .litemenu-entry', { hasText: 'Delete' })
|
|
.click()
|
|
|
|
await expect(comfyPage.canvas).toHaveScreenshot(
|
|
'native_reroute_delete_from_midpoint_context_menu.png'
|
|
)
|
|
})
|
|
}
|
|
)
|