mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
3b78dfbe1c
## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
62 lines
2.0 KiB
TypeScript
62 lines
2.0 KiB
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
|
|
import type { WorkspaceStore } from '@e2e/types/globals'
|
|
|
|
test.describe('Browser tab title', { tag: '@smoke' }, () => {
|
|
test.describe('Beta Menu', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
})
|
|
|
|
test('Can display workflow name', async ({ comfyPage }) => {
|
|
const workflowName = await comfyPage.page.evaluate(async () => {
|
|
return (window.app!.extensionManager as WorkspaceStore).workflow
|
|
.activeWorkflow?.filename
|
|
})
|
|
await expect
|
|
.poll(() => comfyPage.page.title())
|
|
.toBe(`*${workflowName} - ComfyUI`)
|
|
})
|
|
|
|
test('Can display workflow name with unsaved changes', async ({
|
|
comfyPage
|
|
}) => {
|
|
const workflowName = `test-${Date.now()}`
|
|
await comfyPage.menu.topbar.saveWorkflow(workflowName)
|
|
await expect
|
|
.poll(() => comfyPage.page.title())
|
|
.toBe(`${workflowName} - ComfyUI`)
|
|
|
|
await comfyPage.page.evaluate(async () => {
|
|
const node = window.app!.graph!.nodes[0]
|
|
node.pos[0] += 50
|
|
window.app!.graph!.setDirtyCanvas(true, true)
|
|
;(
|
|
window.app!.extensionManager as WorkspaceStore
|
|
).workflow.activeWorkflow?.changeTracker?.checkState()
|
|
})
|
|
await expect
|
|
.poll(() => comfyPage.page.title())
|
|
.toBe(`*${workflowName} - ComfyUI`)
|
|
|
|
// Delete the saved workflow for cleanup.
|
|
await comfyPage.page.evaluate(async () => {
|
|
return (
|
|
window.app!.extensionManager as WorkspaceStore
|
|
).workflow.activeWorkflow?.delete()
|
|
})
|
|
})
|
|
})
|
|
|
|
test.describe('Legacy Menu', () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test('Can display default title', async ({ comfyPage }) => {
|
|
await expect.poll(() => comfyPage.page.title()).toBe('ComfyUI')
|
|
})
|
|
})
|
|
})
|