mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 06:20:11 +00:00
8c9328c1b2
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
64 lines
2.0 KiB
TypeScript
64 lines
2.0 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Focus Mode', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.setup()
|
|
})
|
|
|
|
test('Focus mode hides UI chrome', async ({ comfyPage }) => {
|
|
await expect(comfyPage.menu.sideToolbar).toBeVisible()
|
|
|
|
await comfyPage.setFocusMode(true)
|
|
|
|
await expect(comfyPage.menu.sideToolbar).toBeHidden()
|
|
})
|
|
|
|
test('Focus mode restores UI chrome', async ({ comfyPage }) => {
|
|
await comfyPage.setFocusMode(true)
|
|
await expect(comfyPage.menu.sideToolbar).toBeHidden()
|
|
|
|
await comfyPage.setFocusMode(false)
|
|
await expect(comfyPage.menu.sideToolbar).toBeVisible()
|
|
})
|
|
|
|
test('Toggle focus mode command works', async ({ comfyPage }) => {
|
|
await expect(comfyPage.menu.sideToolbar).toBeVisible()
|
|
|
|
await comfyPage.command.executeCommand('Workspace.ToggleFocusMode')
|
|
await expect(comfyPage.menu.sideToolbar).toBeHidden()
|
|
|
|
await comfyPage.command.executeCommand('Workspace.ToggleFocusMode')
|
|
await expect(comfyPage.menu.sideToolbar).toBeVisible()
|
|
})
|
|
|
|
test('Focus mode hides topbar', async ({ comfyPage }) => {
|
|
const topMenu = comfyPage.page.locator('.comfy-menu-button-wrapper')
|
|
await expect(topMenu).toBeVisible()
|
|
|
|
await comfyPage.setFocusMode(true)
|
|
|
|
await expect(topMenu).toBeHidden()
|
|
})
|
|
|
|
test('Canvas remains visible in focus mode', async ({ comfyPage }) => {
|
|
await comfyPage.setFocusMode(true)
|
|
|
|
await expect(comfyPage.canvas).toBeVisible()
|
|
})
|
|
|
|
test('Focus mode can be toggled multiple times', async ({ comfyPage }) => {
|
|
await comfyPage.setFocusMode(true)
|
|
await expect(comfyPage.menu.sideToolbar).toBeHidden()
|
|
|
|
await comfyPage.setFocusMode(false)
|
|
await expect(comfyPage.menu.sideToolbar).toBeVisible()
|
|
|
|
await comfyPage.setFocusMode(true)
|
|
await expect(comfyPage.menu.sideToolbar).toBeHidden()
|
|
})
|
|
})
|