mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
*PR Created by the Glary-Bot Agent* --- ## Summary - Convert ~120 getter-based locators across 18 browser test fixture files to `public readonly` constructor-assigned properties - Removes unnecessary indirection, makes object shape explicit, and improves IDE auto-complete / type inference - Keeps lazy-init getters (`??=`), computed properties, and `private get page()` convenience accessors as getters ## Changes **`browser_tests/fixtures/components/`** (6 files): `ComfyNodeSearchBox`, `ContextMenu`, `SettingDialog`, `SignInDialog`, `SidebarTab` (all 6 classes), `Topbar` **`browser_tests/fixtures/`** (4 files): `ComfyPage` (ComfyMenu.buttons, ComfyPage.visibleToasts), `UserSelectPage`, `ComfyMouse`, `VueNodeHelpers` **`browser_tests/fixtures/helpers/`** (7 files): `AppModeHelper`, `BuilderFooterHelper`, `BuilderSaveAsHelper`, `BuilderSelectHelper`, `BuilderStepsHelper`, `ToastHelper`, `NodeOperationsHelper` **`browser_tests/fixtures/utils/`** (1 file): `vueNodeFixtures` ## Validation - `pnpm typecheck` ✅ - `pnpm typecheck:browser` ✅ - `pnpm exec eslint browser_tests/fixtures/` ✅ - All pre-commit hooks pass (oxfmt, oxlint, eslint, typecheck, typecheck:browser) ✅ - No visual/manual verification needed — changes are test fixture locator declarations only (no UI or runtime behavior change) Fixes #11131 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11135-refactor-standardize-Page-Object-locators-as-public-readonly-instead-of-getters-33e6d73d3650819690cbc639f3d30daf) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
34 lines
1.0 KiB
TypeScript
34 lines
1.0 KiB
TypeScript
import type { Locator, Page } from '@playwright/test'
|
|
import { test as base } from '@playwright/test'
|
|
|
|
export class UserSelectPage {
|
|
public readonly selectionUrl: string
|
|
public readonly container: Locator
|
|
public readonly newUserInput: Locator
|
|
public readonly existingUserSelect: Locator
|
|
public readonly nextButton: Locator
|
|
|
|
constructor(
|
|
public readonly url: string,
|
|
public readonly page: Page
|
|
) {
|
|
this.selectionUrl = url + '/user-select'
|
|
this.container = page.locator('#comfy-user-selection')
|
|
this.newUserInput = this.container.locator('#new-user-input')
|
|
this.existingUserSelect = this.container.locator('#existing-user-select')
|
|
this.nextButton = this.container.getByText('Next')
|
|
}
|
|
}
|
|
|
|
export const userSelectPageFixture = base.extend<{
|
|
userSelectPage: UserSelectPage
|
|
}>({
|
|
userSelectPage: async ({ page }, use) => {
|
|
const userSelectPage = new UserSelectPage(
|
|
process.env.PLAYWRIGHT_TEST_URL || 'http://localhost:8188',
|
|
page
|
|
)
|
|
await use(userSelectPage)
|
|
}
|
|
})
|