mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
8c9328c1b2
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
103 lines
2.9 KiB
TypeScript
103 lines
2.9 KiB
TypeScript
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Bottom Panel Logs', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
})
|
|
|
|
test('should open bottom panel via toggle button', async ({ comfyPage }) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await expect(bottomPanel.root).toBeHidden()
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
})
|
|
|
|
test('should show Logs tab when terminal panel opens', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
|
|
const logsTab = comfyPage.page.getByRole('tab', { name: /Logs/i })
|
|
await expect(logsTab).toBeVisible()
|
|
})
|
|
|
|
test('should close bottom panel via toggle button', async ({ comfyPage }) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeHidden()
|
|
})
|
|
|
|
test('should switch between shortcuts and terminal panels', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.keyboardShortcutsButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
await expect(
|
|
comfyPage.page.locator('[id*="tab_shortcuts-essentials"]')
|
|
).toBeVisible()
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
|
|
const logsTab = comfyPage.page.getByRole('tab', { name: /Logs/i })
|
|
await expect(logsTab).toBeVisible()
|
|
await expect(
|
|
comfyPage.page.locator('[id*="tab_shortcuts-essentials"]')
|
|
).toBeHidden()
|
|
})
|
|
|
|
test('should persist Logs tab content in bottom panel', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
|
|
const logsTab = comfyPage.page.getByRole('tab', { name: /Logs/i })
|
|
await expect(logsTab).toBeVisible()
|
|
|
|
const isAlreadyActive =
|
|
(await logsTab.getAttribute('aria-selected')) === 'true'
|
|
if (!isAlreadyActive) {
|
|
await logsTab.click()
|
|
}
|
|
|
|
const xtermContainer = bottomPanel.root.locator('.xterm')
|
|
await expect(xtermContainer).toBeVisible()
|
|
})
|
|
|
|
test('should render xterm container in terminal panel', async ({
|
|
comfyPage
|
|
}) => {
|
|
const { bottomPanel } = comfyPage
|
|
|
|
await bottomPanel.toggleButton.click()
|
|
await expect(bottomPanel.root).toBeVisible()
|
|
|
|
const logsTab = comfyPage.page.getByRole('tab', { name: /Logs/i })
|
|
await expect(logsTab).toBeVisible()
|
|
|
|
const isAlreadyActive =
|
|
(await logsTab.getAttribute('aria-selected')) === 'true'
|
|
if (!isAlreadyActive) {
|
|
await logsTab.click()
|
|
}
|
|
|
|
const xtermScreen = bottomPanel.root.locator('.xterm, .xterm-screen')
|
|
await expect(xtermScreen.first()).toBeVisible()
|
|
})
|
|
})
|