mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 22:39:39 +00:00
*PR Created by the Glary-Bot Agent* --- ## Summary - Convert ~120 getter-based locators across 18 browser test fixture files to `public readonly` constructor-assigned properties - Removes unnecessary indirection, makes object shape explicit, and improves IDE auto-complete / type inference - Keeps lazy-init getters (`??=`), computed properties, and `private get page()` convenience accessors as getters ## Changes **`browser_tests/fixtures/components/`** (6 files): `ComfyNodeSearchBox`, `ContextMenu`, `SettingDialog`, `SignInDialog`, `SidebarTab` (all 6 classes), `Topbar` **`browser_tests/fixtures/`** (4 files): `ComfyPage` (ComfyMenu.buttons, ComfyPage.visibleToasts), `UserSelectPage`, `ComfyMouse`, `VueNodeHelpers` **`browser_tests/fixtures/helpers/`** (7 files): `AppModeHelper`, `BuilderFooterHelper`, `BuilderSaveAsHelper`, `BuilderSelectHelper`, `BuilderStepsHelper`, `ToastHelper`, `NodeOperationsHelper` **`browser_tests/fixtures/utils/`** (1 file): `vueNodeFixtures` ## Validation - `pnpm typecheck` ✅ - `pnpm typecheck:browser` ✅ - `pnpm exec eslint browser_tests/fixtures/` ✅ - All pre-commit hooks pass (oxfmt, oxlint, eslint, typecheck, typecheck:browser) ✅ - No visual/manual verification needed — changes are test fixture locator declarations only (no UI or runtime behavior change) Fixes #11131 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11135-refactor-standardize-Page-Object-locators-as-public-readonly-instead-of-getters-33e6d73d3650819690cbc639f3d30daf) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
58 lines
1.8 KiB
TypeScript
58 lines
1.8 KiB
TypeScript
import type { Locator, Page } from '@playwright/test'
|
|
|
|
import type { ComfyPage } from '@e2e/fixtures/ComfyPage'
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
|
|
export class BuilderFooterHelper {
|
|
public readonly nav: Locator
|
|
public readonly exitButton: Locator
|
|
public readonly nextButton: Locator
|
|
public readonly backButton: Locator
|
|
public readonly saveButton: Locator
|
|
public readonly saveGroup: Locator
|
|
public readonly saveAsButton: Locator
|
|
public readonly saveAsChevron: Locator
|
|
public readonly opensAsPopover: Locator
|
|
|
|
constructor(private readonly comfyPage: ComfyPage) {
|
|
this.nav = this.page.getByTestId(TestIds.builder.footerNav)
|
|
this.exitButton = this.buttonByName('Exit app builder')
|
|
this.nextButton = this.buttonByName('Next')
|
|
this.backButton = this.buttonByName('Back')
|
|
this.saveButton = this.page.getByTestId(TestIds.builder.saveButton)
|
|
this.saveGroup = this.page.getByTestId(TestIds.builder.saveGroup)
|
|
this.saveAsButton = this.page.getByTestId(TestIds.builder.saveAsButton)
|
|
this.saveAsChevron = this.page.getByTestId(TestIds.builder.saveAsChevron)
|
|
this.opensAsPopover = this.page.getByTestId(TestIds.builder.opensAs)
|
|
}
|
|
|
|
private get page(): Page {
|
|
return this.comfyPage.page
|
|
}
|
|
|
|
private buttonByName(name: string): Locator {
|
|
return this.nav.getByRole('button', { name })
|
|
}
|
|
|
|
async next() {
|
|
await this.nextButton.click()
|
|
await this.comfyPage.nextFrame()
|
|
}
|
|
|
|
async back() {
|
|
await this.backButton.click()
|
|
await this.comfyPage.nextFrame()
|
|
}
|
|
|
|
async exitBuilder() {
|
|
await this.exitButton.click()
|
|
await this.comfyPage.nextFrame()
|
|
}
|
|
|
|
async openSaveAsFromChevron() {
|
|
await this.saveAsChevron.click()
|
|
await this.page.getByRole('menuitem', { name: 'Save as' }).click()
|
|
await this.comfyPage.nextFrame()
|
|
}
|
|
}
|