mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-26 19:09:52 +00:00
This PR cleans up the base-layer utilities so they no longer pull renderer or workbench code. The renderer-only `isPrimitiveNode` guard now lives in `src/renderer/utils/nodeTypeGuards.ts`, and the node help/model/ordering helpers have moved into `src/workbench/utils`. All affected services, stores, scripts, and tests were updated to import from the new locations. The idea is to reduce the number of Base→Renderer/Base→Workbench edges (higher scoped base/common utils should not import from renderer/workbench layers). ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6621-refactor-move-renderer-dependent-utils-into-workbench-scope-2a36d73d36508167aff0fc8a22202d7f) by [Unito](https://www.unito.io)
LiteGraph Tests
This directory contains the test suite for the LiteGraph library.
Structure
litegraph/
├── core/ # Core functionality tests (LGraph, LGraphNode, etc.)
├── canvas/ # Canvas-related tests (rendering, interactions)
├── infrastructure/ # Infrastructure tests (Rectangle, utilities)
├── subgraph/ # Subgraph-specific tests
├── utils/ # Utility function tests
└── fixtures/ # Test helpers, fixtures, and assets
Running Tests
# Run all litegraph tests
pnpm test:unit -- tests-ui/tests/litegraph/
# Run specific subdirectory
pnpm test:unit -- tests-ui/tests/litegraph/core/
# Run single test file
pnpm test:unit -- tests-ui/tests/litegraph/core/LGraph.test.ts
Migration Status
These tests were migrated from src/lib/litegraph/test/ to centralize test infrastructure. Currently, some tests are marked with .skip due to import/setup issues that need to be resolved.
TODO: Fix Skipped Tests
The following test files have been temporarily disabled and need fixes:
- Most subgraph tests (circular dependency issues)
- Some core tests (missing test utilities)
- Canvas tests (mock setup issues)
See individual test files marked with // TODO: Fix these tests after migration for specific issues.
Writing New Tests
-
Always import from the barrel export to avoid circular dependencies:
import { LGraph, LGraphNode } from '@/lib/litegraph/src/litegraph' -
Use the test fixtures from
fixtures/directory -
Follow existing patterns for test organization
Test Fixtures
Test fixtures and helpers are located in the fixtures/ directory:
testExtensions.ts- Custom vitest extensionssubgraphHelpers.ts- Helpers for creating test subgraphssubgraphFixtures.ts- Common subgraph test scenariosassets/- Test data files