mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
8c9328c1b2
## Summary Add eslint-plugin-playwright as an oxlint JS plugin scoped to browser_tests/, enforcing Playwright best practices at lint time. ## Changes - **What**: Configure eslint-plugin-playwright@2.10.1 via oxlint's alpha `jsPlugins` field (`.oxlintrc.json` override scoped to `browser_tests/**/*.ts`). 18 recommended rules + `prefer-native-locators` + `require-to-pass-timeout` at error severity. All 173 initial violations resolved (config, auto-fix, manual fixes). `no-force-option` set to off — 28 violations need triage (canvas overlay workarounds vs unnecessary force) in a dedicated PR. - **Dependencies**: `eslint-plugin-playwright@^2.10.1` (devDependency, required by oxlint jsPlugins at runtime) ## Review Focus - `.oxlintrc.json` override structure — this is the first use of oxlint's JS plugins alpha feature in this repo - Manual fixes in spec files: `waitForSelector` → `locator.waitFor`, deprecated page methods → locator equivalents, `toPass()` timeout additions - Compound CSS selectors replaced with `.and()` (Playwright native locator composition) to avoid `prefer-native-locators` suppressions - Lint script changes in `package.json` to include `browser_tests/` in oxlint targets --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
58 lines
1.8 KiB
TypeScript
58 lines
1.8 KiB
TypeScript
import type { Locator } from '@playwright/test'
|
|
|
|
import { TestIds } from '@e2e/fixtures/selectors'
|
|
|
|
/** DOM-centric helper for a single Vue-rendered node on the canvas. */
|
|
export class VueNodeFixture {
|
|
public readonly header: Locator
|
|
public readonly title: Locator
|
|
public readonly titleInput: Locator
|
|
public readonly body: Locator
|
|
public readonly pinIndicator: Locator
|
|
public readonly collapseButton: Locator
|
|
public readonly collapseIcon: Locator
|
|
public readonly root: Locator
|
|
|
|
constructor(private readonly locator: Locator) {
|
|
this.header = locator.locator('[data-testid^="node-header-"]')
|
|
this.title = locator.getByTestId('node-title')
|
|
this.titleInput = locator.getByTestId('node-title-input')
|
|
this.body = locator.locator('[data-testid^="node-body-"]')
|
|
this.pinIndicator = locator.getByTestId(TestIds.node.pinIndicator)
|
|
this.collapseButton = locator.getByTestId('node-collapse-button')
|
|
this.collapseIcon = this.collapseButton.locator('i')
|
|
this.root = locator
|
|
}
|
|
|
|
async getTitle(): Promise<string> {
|
|
return (await this.title.textContent()) ?? ''
|
|
}
|
|
|
|
async setTitle(value: string): Promise<void> {
|
|
await this.header.dblclick()
|
|
const input = this.titleInput
|
|
await input.waitFor({ state: 'visible' })
|
|
await input.fill(value)
|
|
await input.press('Enter')
|
|
}
|
|
|
|
async cancelTitleEdit(): Promise<void> {
|
|
await this.header.dblclick()
|
|
const input = this.titleInput
|
|
await input.waitFor({ state: 'visible' })
|
|
await input.press('Escape')
|
|
}
|
|
|
|
async toggleCollapse(): Promise<void> {
|
|
await this.collapseButton.click()
|
|
}
|
|
|
|
async getCollapseIconClass(): Promise<string> {
|
|
return (await this.collapseIcon.getAttribute('class')) ?? ''
|
|
}
|
|
|
|
boundingBox(): ReturnType<Locator['boundingBox']> {
|
|
return this.locator.boundingBox()
|
|
}
|
|
}
|