mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
f90d6cf607
## Summary Migrate 132 test files from `@vue/test-utils` (VTU) to `@testing-library/vue` (VTL) with `@testing-library/user-event`, adopting user-centric behavioral testing patterns across the codebase. ## Changes - **What**: Systematic migration of component/unit tests from VTU's `mount`/`wrapper` API to VTL's `render`/`screen`/`userEvent` API across 132 files in `src/` - **Breaking**: None — test-only changes, no production code affected ### Migration breakdown | Batch | Files | Description | |-------|-------|-------------| | 1 | 19 | Simple render/assert tests | | 2A | 16 | Interactive tests with user events | | 2B-1 | 14 | Interactive tests (continued) | | 2B-2 | 32 | Interactive tests (continued) | | 3A–3E | 51 | Complex tests (stores, composables, heavy mocking) | | Lint fix | 7 | `await` on `fireEvent` calls for `no-floating-promises` | | Review fixes | 15 | Address CodeRabbit feedback (3 rounds) | ### Review feedback addressed - Removed class-based assertions (`text-ellipsis`, `pr-3`, `.pi-save`, `.skeleton`, `.bg-black\/15`, Tailwind utilities) in favor of behavioral/accessible queries - Added null guards before `querySelector` casts - Added `expect(roots).toHaveLength(N)` guards before indexed NodeList access - Wrapped fake timer tests in `try/finally` for guaranteed cleanup - Split double-render tests into focused single-render tests - Replaced CSS class selectors with `screen.getByText`/`screen.getByRole` queries - Updated stubs to use semantic `role`/`aria-label` instead of CSS classes - Consolidated redundant edge-case tests - Removed manual `document.body.appendChild` in favor of VTL container management - Used distinct mock return values to verify command wiring ### VTU holdouts (2 files) These files intentionally retain `@vue/test-utils` because their components use `<script setup>` without `defineExpose`, making internal computed properties and methods inaccessible via VTL: 1. **`NodeWidgets.test.ts`** — partial VTU for `vm.processedWidgets` 2. **`WidgetSelectDropdown.test.ts`** — full VTU for heavy `wrapper.vm.*` access ## Follow-up Deferred items (`ComponentProps` typing, camelCase listener props) tracked in #10966. ## Review Focus - Test correctness: all migrated tests preserve original behavioral coverage - VTL idioms: proper use of `screen` queries, `userEvent`, and accessibility-based selectors - The 2 VTU holdout files are intentional, not oversights ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10965-test-migrate-132-test-files-from-vue-test-utils-to-testing-library-vue-33c6d73d36508199a6a7e513cf5d8296) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org>
78 lines
2.2 KiB
TypeScript
78 lines
2.2 KiB
TypeScript
import { render, screen } from '@testing-library/vue'
|
|
import { describe, expect, it, vi } from 'vitest'
|
|
import { ref } from 'vue'
|
|
|
|
import CompareSliderThumbnail from '@/components/templates/thumbnails/CompareSliderThumbnail.vue'
|
|
|
|
vi.mock('@/components/templates/thumbnails/BaseThumbnail.vue', () => ({
|
|
default: {
|
|
name: 'BaseThumbnail',
|
|
template: '<div class="base-thumbnail"><slot /></div>',
|
|
props: ['isHovered']
|
|
}
|
|
}))
|
|
|
|
vi.mock('@/components/common/LazyImage.vue', () => ({
|
|
default: {
|
|
name: 'LazyImage',
|
|
template:
|
|
'<img :src="src" :alt="alt" :class="imageClass" :style="imageStyle" draggable="false" />',
|
|
props: ['src', 'alt', 'imageClass', 'imageStyle']
|
|
}
|
|
}))
|
|
|
|
vi.mock('@vueuse/core', () => ({
|
|
useMouseInElement: () => ({
|
|
elementX: ref(50),
|
|
elementWidth: ref(100),
|
|
isOutside: ref(false)
|
|
})
|
|
}))
|
|
|
|
describe('CompareSliderThumbnail', () => {
|
|
const renderThumbnail = (props = {}) => {
|
|
return render(CompareSliderThumbnail, {
|
|
props: {
|
|
baseImageSrc: '/base-image.jpg',
|
|
overlayImageSrc: '/overlay-image.jpg',
|
|
alt: 'Comparison Image',
|
|
isVideo: false,
|
|
...props
|
|
}
|
|
})
|
|
}
|
|
|
|
it('renders both base and overlay images', () => {
|
|
renderThumbnail()
|
|
const images = screen.getAllByRole('img')
|
|
expect(images).toHaveLength(2)
|
|
expect(images[0]).toHaveAttribute('src', '/base-image.jpg')
|
|
expect(images[1]).toHaveAttribute('src', '/overlay-image.jpg')
|
|
})
|
|
|
|
it('applies correct alt text to both images', () => {
|
|
renderThumbnail({ alt: 'Custom Alt Text' })
|
|
const images = screen.getAllByRole('img')
|
|
expect(images[0]).toHaveAttribute('alt', 'Custom Alt Text')
|
|
expect(images[1]).toHaveAttribute('alt', 'Custom Alt Text')
|
|
})
|
|
|
|
it('applies clip-path style to overlay image', () => {
|
|
renderThumbnail()
|
|
const images = screen.getAllByRole('img')
|
|
expect(images[1].style.clipPath).toContain('inset')
|
|
})
|
|
|
|
it('renders slider divider', () => {
|
|
renderThumbnail()
|
|
const divider = screen.getByTestId('compare-slider-divider')
|
|
expect(divider).toBeDefined()
|
|
})
|
|
|
|
it('positions slider based on default value', () => {
|
|
renderThumbnail()
|
|
const divider = screen.getByTestId('compare-slider-divider')
|
|
expect(divider.style.left).toBe('50%')
|
|
})
|
|
})
|