mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
675a67cfda
Add AMD ROCm GPU option to the desktop installer ## What changed - Add an AMD GPU choice to the installer picker with updated recommended badge logic, logo asset, and i18n copy. - Accept and auto-select the new `amd` device type in the install flow when it is detected. - Update `@comfyorg/comfyui-electron-types` and lockfile entries required for the new device enum. ## Why - Desktop users with AMD GPUs need a first-class install path instead of falling back to CPU/manual options. - This reuses the existing picker/device model to keep the change scoped and consistent with current UX. - Tradeoffs: torch mirror selection still falls back to the CPU mirror for AMD until a dedicated ROCm mirror is available. ## Evidence - Interactive Storybook file `apps/desktop-ui/src/components/install/GpuPicker.stories.ts` <img width="1377" height="834" alt="image" src="https://github.com/user-attachments/assets/34145f46-d8cc-4e59-b587-0ab5ee79f888" />
108 lines
3.3 KiB
Vue
108 lines
3.3 KiB
Vue
<template>
|
|
<div
|
|
class="mx-auto grid h-[40rem] w-full max-w-3xl grid-rows-[1fr_auto_auto_1fr] select-none"
|
|
>
|
|
<h2 class="text-center font-inter text-3xl font-bold text-neutral-100">
|
|
{{ $t('install.gpuPicker.title') }}
|
|
</h2>
|
|
|
|
<!-- GPU Selection buttons - takes up remaining space and centers content -->
|
|
<div class="flex flex-1 items-center justify-center gap-8">
|
|
<!-- Apple Metal / NVIDIA -->
|
|
<HardwareOption
|
|
v-if="platform === 'darwin'"
|
|
image-path="./assets/images/apple-mps-logo.png"
|
|
placeholder-text="Apple Metal"
|
|
subtitle="Apple Metal"
|
|
:selected="selected === 'mps'"
|
|
@click="pickGpu('mps')"
|
|
/>
|
|
<template v-else>
|
|
<HardwareOption
|
|
image-path="./assets/images/nvidia-logo-square.jpg"
|
|
placeholder-text="NVIDIA"
|
|
:subtitle="$t('install.gpuPicker.nvidiaSubtitle')"
|
|
:selected="selected === 'nvidia'"
|
|
@click="pickGpu('nvidia')"
|
|
/>
|
|
<HardwareOption
|
|
image-path="./assets/images/amd-rocm-logo.png"
|
|
placeholder-text="AMD"
|
|
:subtitle="$t('install.gpuPicker.amdSubtitle')"
|
|
:selected="selected === 'amd'"
|
|
@click="pickGpu('amd')"
|
|
/>
|
|
</template>
|
|
<!-- CPU -->
|
|
<HardwareOption
|
|
placeholder-text="CPU"
|
|
:subtitle="$t('install.gpuPicker.cpuSubtitle')"
|
|
:selected="selected === 'cpu'"
|
|
@click="pickGpu('cpu')"
|
|
/>
|
|
<!-- Manual Install -->
|
|
<HardwareOption
|
|
placeholder-text="Manual Install"
|
|
:subtitle="$t('install.gpuPicker.manualSubtitle')"
|
|
:selected="selected === 'unsupported'"
|
|
@click="pickGpu('unsupported')"
|
|
/>
|
|
</div>
|
|
|
|
<div class="h-16 px-24 pt-12">
|
|
<div v-show="showRecommendedBadge" class="flex items-center gap-2">
|
|
<Tag
|
|
:value="$t('install.gpuPicker.recommended')"
|
|
class="rounded-full bg-neutral-300 px-2 py-[1px] text-sm font-bold text-neutral-900"
|
|
/>
|
|
<i class="icon-[lucide--badge-check] text-lg text-neutral-300" />
|
|
</div>
|
|
</div>
|
|
|
|
<div class="px-24 text-neutral-300">
|
|
<p v-show="descriptionText" class="leading-relaxed">
|
|
{{ descriptionText }}
|
|
</p>
|
|
</div>
|
|
</div>
|
|
</template>
|
|
|
|
<script setup lang="ts">
|
|
import type { TorchDeviceType } from '@comfyorg/comfyui-electron-types'
|
|
import Tag from 'primevue/tag'
|
|
import { computed } from 'vue'
|
|
|
|
import HardwareOption from '@/components/install/HardwareOption.vue'
|
|
import { st } from '@/i18n'
|
|
import { electronAPI } from '@/utils/envUtil'
|
|
|
|
const selected = defineModel<TorchDeviceType | null>('device', {
|
|
required: true
|
|
})
|
|
|
|
const electron = electronAPI()
|
|
const platform = electron.getPlatform()
|
|
|
|
const recommendedDevices: TorchDeviceType[] = ['mps', 'nvidia', 'amd']
|
|
const showRecommendedBadge = computed(() =>
|
|
selected.value ? recommendedDevices.includes(selected.value) : false
|
|
)
|
|
|
|
const descriptionKeys = {
|
|
mps: 'appleMetal',
|
|
nvidia: 'nvidia',
|
|
amd: 'amd',
|
|
cpu: 'cpu',
|
|
unsupported: 'manual'
|
|
} as const
|
|
|
|
const descriptionText = computed(() => {
|
|
const key = selected.value ? descriptionKeys[selected.value] : undefined
|
|
return st(`install.gpuPicker.${key}Description`, '')
|
|
})
|
|
|
|
function pickGpu(value: TorchDeviceType) {
|
|
selected.value = value
|
|
}
|
|
</script>
|