mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-14 01:36:14 +00:00
8e3041aa2f
## Summary Follow-up to #11568. Fixes Playwright required checks hanging as "Waiting for status to be reported" on PRs with no e2e-relevant file changes. ## Problem PR #11568 added a `changes` filter to skip E2E when only docs/apps/storybook files are touched. The E2E workflow skips correctly, but branch rulesets require the 11 matrix-expanded check names (e.g. `playwright-tests-chromium-sharded (1, 8)`). When a matrix job is skipped via dependency, GitHub only reports the parent job name — the individual matrix entries are never reported, so required checks hang forever. ## Fix Add a single `e2e-status` gate job that: - Uses `if: always()` so it always runs regardless of skipped dependencies - Passes when E2E was intentionally skipped (no relevant changes) - Passes when all matrix jobs succeeded - Fails when any matrix job failed **After merging**, the ProtectMain and Core release branches rulesets should be updated to require `e2e-status` instead of the 11 individual matrix check names. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11587-ci-add-e2e-status-gate-job-for-required-checks-34c6d73d365081b59c01e8d61d0b808d) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
GitHub Workflows
Naming Convention
Workflow files follow a consistent naming pattern: <prefix>-<descriptive-name>.yaml
Category Prefixes
| Prefix | Purpose | Example |
|---|---|---|
ci- |
Testing, linting, validation | ci-tests-e2e.yaml |
release- |
Version management, publishing | release-version-bump.yaml |
pr- |
PR automation (triggered by labels) | pr-claude-review.yaml |
api- |
External Api type generation | api-update-registry-api-types.yaml |
i18n- |
Internationalization updates | i18n-update-core.yaml |
Documentation
Each workflow file contains comments explaining its purpose, triggers, and behavior. For specific details about what each workflow does, refer to the comments at the top of each .yaml file.
For GitHub Actions documentation, see Events that trigger workflows.