mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-24 14:45:36 +00:00
## Summary Add a `@perf` test measuring the cost of entering a subgraph containing 80 interior nodes. Establishes a CI baseline for the synchronous mount/unmount bottleneck. ## Changes - **What**: Add `subgraph transition (enter and exit)` perf test to `performance.spec.ts` and a test workflow asset (`large-subgraph-80-nodes.json`) with a single subgraph node containing 80 Note nodes. ## Review Focus This is PR 1 of 2. The test establishes a baseline on main so the optimization PR (PR 2) can show a CI-proven delta for `taskDurationMs` and `totalBlockingTimeMs`. The test: 1. Loads the 80-node subgraph workflow 2. Enters and exits once to warm up 3. Measures a fresh enter transition (start → 80 nodes mounted → layout settled) 4. Records `taskDurationMs`, `layouts`, and `TBT` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10480-test-add-perf-test-for-subgraph-transition-bottleneck-32d6d73d3650811b9b6eec03a9591f82) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Connor Byrne <c.byrne@comfy.org>
115 lines
3.7 KiB
YAML
115 lines
3.7 KiB
YAML
name: 'CI: Performance Report'
|
||
|
||
on:
|
||
push:
|
||
branches: [main, core/*]
|
||
pull_request:
|
||
branches-ignore: [wip/*, draft/*, temp/*]
|
||
|
||
concurrency:
|
||
group: perf-${{ github.ref }}
|
||
cancel-in-progress: false
|
||
|
||
permissions:
|
||
contents: read
|
||
|
||
jobs:
|
||
changes:
|
||
runs-on: ubuntu-latest
|
||
permissions:
|
||
contents: read
|
||
outputs:
|
||
should-run: ${{ steps.changes.outputs.should-run }}
|
||
steps:
|
||
- uses: actions/checkout@v6
|
||
- id: changes
|
||
uses: ./.github/actions/changes-filter
|
||
|
||
perf-tests:
|
||
needs: changes
|
||
if: ${{ needs.changes.outputs.should-run == 'true' && github.repository == 'Comfy-Org/ComfyUI_frontend' }}
|
||
runs-on: ubuntu-latest
|
||
timeout-minutes: 30
|
||
container:
|
||
image: ghcr.io/comfy-org/comfyui-ci-container:0.0.17
|
||
credentials:
|
||
username: ${{ github.actor }}
|
||
password: ${{ secrets.GITHUB_TOKEN }}
|
||
permissions:
|
||
contents: write
|
||
packages: read
|
||
actions: read
|
||
|
||
steps:
|
||
- name: Checkout repository
|
||
uses: actions/checkout@v6
|
||
with:
|
||
persist-credentials: false
|
||
|
||
- name: Setup frontend
|
||
uses: ./.github/actions/setup-frontend
|
||
with:
|
||
include_build_step: true
|
||
|
||
- name: Start ComfyUI server
|
||
uses: ./.github/actions/start-comfyui-server
|
||
|
||
# PRs run each test once to keep wall time bounded; main runs 3× so the
|
||
# baseline saved to perf-data has enough samples to median over noise.
|
||
- name: Run performance tests
|
||
id: perf
|
||
continue-on-error: true
|
||
env:
|
||
PERF_REPEAT: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' && '3' || '2' }}
|
||
run: pnpm exec playwright test --project=performance --workers=1 --repeat-each=$PERF_REPEAT
|
||
|
||
- name: Upload perf metrics
|
||
if: always()
|
||
uses: actions/upload-artifact@v6
|
||
with:
|
||
name: perf-metrics
|
||
path: test-results/perf-metrics.json
|
||
retention-days: 30
|
||
if-no-files-found: warn
|
||
|
||
- name: Save perf baseline to perf-data branch
|
||
if: github.event_name == 'push' && github.ref == 'refs/heads/main' && steps.perf.outcome == 'success'
|
||
continue-on-error: true
|
||
run: |
|
||
git config user.name "github-actions[bot]"
|
||
git config user.email "github-actions[bot]@users.noreply.github.com"
|
||
git config url."https://x-access-token:${GH_TOKEN}@github.com/".insteadOf "https://github.com/"
|
||
|
||
cp test-results/perf-metrics.json /tmp/perf-metrics.json
|
||
|
||
git fetch origin perf-data || {
|
||
echo "Creating perf-data branch"
|
||
git checkout --orphan perf-data
|
||
git rm -rf . 2>/dev/null || true
|
||
echo "# Performance Baselines" > README.md
|
||
mkdir -p baselines
|
||
git add README.md baselines
|
||
git commit -m "Initialize perf-data branch"
|
||
git push origin perf-data
|
||
git fetch origin perf-data
|
||
}
|
||
|
||
git worktree add /tmp/perf-data origin/perf-data
|
||
|
||
TIMESTAMP=$(date -u +%Y%m%dT%H%M%SZ)
|
||
SHA=$(echo "${{ github.sha }}" | cut -c1-8)
|
||
mkdir -p /tmp/perf-data/baselines
|
||
cp /tmp/perf-metrics.json "/tmp/perf-data/baselines/perf-${TIMESTAMP}-${SHA}.json"
|
||
|
||
# Keep only last 20 baselines
|
||
cd /tmp/perf-data
|
||
ls -t baselines/perf-*.json 2>/dev/null | tail -n +21 | xargs -r rm
|
||
|
||
git -C /tmp/perf-data add baselines/
|
||
git -C /tmp/perf-data commit -m "perf: add baseline for ${SHA}" || echo "No changes to commit"
|
||
git -C /tmp/perf-data push origin HEAD:perf-data
|
||
|
||
git worktree remove /tmp/perf-data --force 2>/dev/null || true
|
||
env:
|
||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|