mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-21 23:34:31 +00:00
The third PR for managing display of widgets on subgraph nodes. This is the one that actually makes the functionality usable and user visible. Adds - A right-side modal for configuring which widgets are promoted, accessed by right click or selection toolbar - This menu allows for re-arranging widget order by dragging and dropping. - Indicators inside the subgraph for which widgets have been promoted. - Context menu options for promoting or demoting widget inside of a subgraph. <img width="767" height="694" alt="image" src="https://github.com/user-attachments/assets/4f78645d-7b26-48ba-8c49-78f4807e89e8" /> <img width="784" height="435" alt="image" src="https://github.com/user-attachments/assets/7005c730-a732-481e-befb-57019a8a31a7" /> Known issues - Some preview widgets are not added to a node until a draw operation occurs. The code does not yet have a way of determining which nodes should have draw operations forced to facilitate initial widget creation. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5826-Add-UI-code-for-configuring-subgraphNode-widgets-27c6d73d36508146accbf395e5bcd36a) by [Unito](https://www.unito.io)
LiteGraph Tests
This directory contains the test suite for the LiteGraph library.
Structure
litegraph/
├── core/ # Core functionality tests (LGraph, LGraphNode, etc.)
├── canvas/ # Canvas-related tests (rendering, interactions)
├── infrastructure/ # Infrastructure tests (Rectangle, utilities)
├── subgraph/ # Subgraph-specific tests
├── utils/ # Utility function tests
└── fixtures/ # Test helpers, fixtures, and assets
Running Tests
# Run all litegraph tests
pnpm test:unit -- tests-ui/tests/litegraph/
# Run specific subdirectory
pnpm test:unit -- tests-ui/tests/litegraph/core/
# Run single test file
pnpm test:unit -- tests-ui/tests/litegraph/core/LGraph.test.ts
Migration Status
These tests were migrated from src/lib/litegraph/test/ to centralize test infrastructure. Currently, some tests are marked with .skip due to import/setup issues that need to be resolved.
TODO: Fix Skipped Tests
The following test files have been temporarily disabled and need fixes:
- Most subgraph tests (circular dependency issues)
- Some core tests (missing test utilities)
- Canvas tests (mock setup issues)
See individual test files marked with // TODO: Fix these tests after migration for specific issues.
Writing New Tests
-
Always import from the barrel export to avoid circular dependencies:
import { LGraph, LGraphNode } from '@/lib/litegraph/src/litegraph' -
Use the test fixtures from
fixtures/directory -
Follow existing patterns for test organization
Test Fixtures
Test fixtures and helpers are located in the fixtures/ directory:
testExtensions.ts- Custom vitest extensionssubgraphHelpers.ts- Helpers for creating test subgraphssubgraphFixtures.ts- Common subgraph test scenariosassets/- Test data files