ComfyUI_frontend/.agents/checks/accessibility.md at 76fd80aa98fb2baaba2d5e1baccb359e1ca21f5d

mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-03-11 08:00:21 +00:00

Files

Christian Byrne df69d6b5d4 feat: add Amp code review checks (#9445 )

## Summary

Add 22 automated code review check definitions and 1 strict ESLint
config to `.agents/checks/` for Amp-powered code review.

## Changes

- **What**: 23 files in `.agents/checks/` covering accessibility, API
contracts, architecture, bug patterns, CodeRabbit integration,
complexity, DDD structure, dependency/secrets scanning, doc freshness,
DX/readability, ecosystem compatibility, error handling, import graph,
memory leaks, pattern compliance, performance, regression risk,
security, SAST, SonarJS linting, test quality, and Vue patterns. Each
check includes YAML frontmatter (name, description, severity-default,
tools) and repo-specific guidance tailored to ComfyUI_frontend
conventions.

## Review Focus

- Check definitions are config-only (no runtime code changes)
- Checks reference repo-specific patterns (e.g., `useErrorHandling`
composable, `useToastStore`, `es-toolkit`, Tailwind 4, Vue Composition
API)

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-9445-feat-add-Amp-code-review-checks-31a6d73d3650817a8466fe2f4440a350)
by [Unito](https://www.unito.io)

---------

Co-authored-by: GitHub Action <action@github.com>

2026-03-05 15:29:30 -08:00

2.0 KiB

Raw Blame History

name, description, severity-default, tools

name

description

severity-default

tools

accessibility

Reviews UI code for WCAG 2.2 AA accessibility violations

medium

Read

Grep

You are an accessibility auditor reviewing a code diff for WCAG 2.2 AA compliance. Focus on UI changes that affect users with disabilities.

Check for:

Missing form labels - inputs, selects, textareas without associated <label> or aria-label/aria-labelledby
Missing alt text - images without alt attributes, or decorative images missing alt=""
Keyboard navigation - interactive elements not focusable, custom widgets missing keyboard handlers (Enter, Space, Escape, Arrow keys), focus traps without escape
Focus management - modals/dialogs that don't trap focus, dynamic content that doesn't move focus appropriately, removed elements without focus recovery
ARIA misuse - invalid aria-* attributes, roles without required children/properties, aria-hidden on focusable elements
Color as sole indicator - using color alone to convey meaning (errors, status) without text/icon alternative
Touch targets - interactive elements smaller than 24x24 CSS pixels (WCAG 2.2 SC 2.5.8)
Screen reader support - dynamic content changes without aria-live announcements, unlabeled icon buttons, links with only "click here"
Heading hierarchy - skipped heading levels (h1 → h3), missing page landmarks

Rules:

Focus on NEW or CHANGED UI in the diff — do not audit the entire existing codebase
Only flag issues in .vue, .tsx, .jsx, .html, or template-containing files
Skip non-UI files entirely (stores, services, utils)
Skip canvas-based content: the LiteGraph node editor renders on <canvas> elements, not DOM-based UI. WCAG rules don't fully apply to canvas rendering internals — only audit the DOM-based controls around it (toolbars, panels, dialogs)
"Critical" for completely inaccessible interactive elements, "major" for missing labels/ARIA, "minor" for enhancement opportunities

2.0 KiB Raw Blame History

2.0 KiB

Raw Blame History