mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-05 15:40:10 +00:00
* fix: Forward the scrolling events to the litegraph canvas. * prior-art: Use the existing event forwarding logic from useCanvasInteractions (h/t Ben) * fix: Get proper scaling from properties in the original event, fix browser zoom * tests: Fix missing property on mock * types: Cleanup type annotations in the test * cleanup: Initialize the mocks in place. * tests: extract createMockPointerEvent * tests: extract createMockWheelEvent * tests: extract createMockLGraphCanvas * tests: Add additional assertion for stopPropagation * tests: Comment pruning, test rename suggested by @arjansingh
154 lines
4.9 KiB
TypeScript
154 lines
4.9 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import { useCanvasInteractions } from '@/composables/graph/useCanvasInteractions'
|
|
import type { LGraphCanvas } from '@/lib/litegraph/src/litegraph'
|
|
import { useCanvasStore } from '@/stores/graphStore'
|
|
import { useSettingStore } from '@/stores/settingStore'
|
|
|
|
// Mock stores
|
|
vi.mock('@/stores/graphStore', () => {
|
|
const getCanvas = vi.fn()
|
|
return { useCanvasStore: vi.fn(() => ({ getCanvas })) }
|
|
})
|
|
vi.mock('@/stores/settingStore', () => {
|
|
const getFn = vi.fn()
|
|
return { useSettingStore: vi.fn(() => ({ get: getFn })) }
|
|
})
|
|
vi.mock('@/scripts/app', () => ({
|
|
app: {
|
|
canvas: {
|
|
canvas: {
|
|
dispatchEvent: vi.fn()
|
|
}
|
|
}
|
|
}
|
|
}))
|
|
|
|
function createMockLGraphCanvas(read_only = true): LGraphCanvas {
|
|
const mockCanvas: Partial<LGraphCanvas> = { read_only }
|
|
return mockCanvas as LGraphCanvas
|
|
}
|
|
|
|
function createMockPointerEvent(
|
|
buttons: PointerEvent['buttons'] = 1
|
|
): PointerEvent {
|
|
const mockEvent: Partial<PointerEvent> = {
|
|
buttons,
|
|
preventDefault: vi.fn(),
|
|
stopPropagation: vi.fn()
|
|
}
|
|
return mockEvent as PointerEvent
|
|
}
|
|
|
|
function createMockWheelEvent(ctrlKey = false, metaKey = false): WheelEvent {
|
|
const mockEvent: Partial<WheelEvent> = {
|
|
ctrlKey,
|
|
metaKey,
|
|
preventDefault: vi.fn(),
|
|
stopPropagation: vi.fn()
|
|
}
|
|
return mockEvent as WheelEvent
|
|
}
|
|
|
|
describe('useCanvasInteractions', () => {
|
|
beforeEach(() => {
|
|
vi.resetAllMocks()
|
|
})
|
|
|
|
describe('handlePointer', () => {
|
|
it('should intercept left mouse events when canvas is read_only to enable space+drag navigation', () => {
|
|
const { getCanvas } = useCanvasStore()
|
|
const mockCanvas = createMockLGraphCanvas(true)
|
|
vi.mocked(getCanvas).mockReturnValue(mockCanvas)
|
|
|
|
const { handlePointer } = useCanvasInteractions()
|
|
|
|
const mockEvent = createMockPointerEvent(1) // Left Mouse Button
|
|
handlePointer(mockEvent)
|
|
|
|
expect(mockEvent.preventDefault).toHaveBeenCalled()
|
|
expect(mockEvent.stopPropagation).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should forward middle mouse button events to canvas', () => {
|
|
const { getCanvas } = useCanvasStore()
|
|
const mockCanvas = createMockLGraphCanvas(false)
|
|
vi.mocked(getCanvas).mockReturnValue(mockCanvas)
|
|
const { handlePointer } = useCanvasInteractions()
|
|
|
|
const mockEvent = createMockPointerEvent(4) // Middle mouse button
|
|
handlePointer(mockEvent)
|
|
|
|
expect(mockEvent.preventDefault).toHaveBeenCalled()
|
|
expect(mockEvent.stopPropagation).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should not prevent default when canvas is not in read_only mode and not middle button', () => {
|
|
const { getCanvas } = useCanvasStore()
|
|
const mockCanvas = createMockLGraphCanvas(false)
|
|
vi.mocked(getCanvas).mockReturnValue(mockCanvas)
|
|
const { handlePointer } = useCanvasInteractions()
|
|
|
|
const mockEvent = createMockPointerEvent(1)
|
|
handlePointer(mockEvent)
|
|
|
|
expect(mockEvent.preventDefault).not.toHaveBeenCalled()
|
|
expect(mockEvent.stopPropagation).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should return early when canvas is null', () => {
|
|
const { getCanvas } = useCanvasStore()
|
|
vi.mocked(getCanvas).mockReturnValue(null as unknown as LGraphCanvas) // TODO: Fix misaligned types
|
|
const { handlePointer } = useCanvasInteractions()
|
|
|
|
const mockEvent = createMockPointerEvent(1)
|
|
handlePointer(mockEvent)
|
|
|
|
expect(getCanvas).toHaveBeenCalled()
|
|
expect(mockEvent.preventDefault).not.toHaveBeenCalled()
|
|
expect(mockEvent.stopPropagation).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
|
|
describe('handleWheel', () => {
|
|
it('should forward ctrl+wheel events to canvas in standard nav mode', () => {
|
|
const { get } = useSettingStore()
|
|
vi.mocked(get).mockReturnValue('standard')
|
|
|
|
const { handleWheel } = useCanvasInteractions()
|
|
|
|
// Ctrl key pressed
|
|
const mockEvent = createMockWheelEvent(true)
|
|
|
|
handleWheel(mockEvent)
|
|
|
|
expect(mockEvent.preventDefault).toHaveBeenCalled()
|
|
expect(mockEvent.stopPropagation).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should forward all wheel events to canvas in legacy nav mode', () => {
|
|
const { get } = useSettingStore()
|
|
vi.mocked(get).mockReturnValue('legacy')
|
|
const { handleWheel } = useCanvasInteractions()
|
|
|
|
const mockEvent = createMockWheelEvent()
|
|
handleWheel(mockEvent)
|
|
|
|
expect(mockEvent.preventDefault).toHaveBeenCalled()
|
|
expect(mockEvent.stopPropagation).toHaveBeenCalled()
|
|
})
|
|
|
|
it('should not prevent default for regular wheel events in standard nav mode', () => {
|
|
const { get } = useSettingStore()
|
|
vi.mocked(get).mockReturnValue('standard')
|
|
const { handleWheel } = useCanvasInteractions()
|
|
|
|
const mockEvent = createMockWheelEvent()
|
|
handleWheel(mockEvent)
|
|
|
|
expect(mockEvent.preventDefault).not.toHaveBeenCalled()
|
|
expect(mockEvent.stopPropagation).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
})
|