ComfyUI_frontend

mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-05-13 17:26:22 +00:00

Files

Benjamin Lu 7901e14318 fix: make docked job history toggle persistence-safe (#9265 )

## Summary
Follow-up to #9215 to keep Docked Job History toggle behavior
deterministic even when settings persistence fails.

## Changes
- Close the actions popover immediately when toggling Docked Job
History.
- Use settingStore.setMany(...) when switching from docked to floating
mode.
- Set sidebarTabStore.activeSidebarTabId = 'job-history' before
persisting when switching from floating to docked mode.
- Wrap persistence calls in try/catch without rollback so
locally-applied UI state remains deterministic.
- Expand QueueOverlayHeader tests to cover setMany, popover close
behavior, and persistence-failure paths.

## Testing
- pnpm test:unit -- src/components/queue/QueueOverlayHeader.test.ts
- pnpm typecheck
- pnpm exec eslint src/components/queue/JobHistoryActionsMenu.vue
src/components/queue/QueueOverlayHeader.test.ts
- pnpm lint (fails in this branch due pre-existing stylelint errors in
generated apps/desktop-ui/dist/**/*.css files, unrelated to this change)

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-9265-fix-make-docked-job-history-toggle-persistence-safe-3146d73d3650818f86c4dfdd57669abd)
by [Unito](https://www.unito.io)

2026-02-26 19:49:08 -08:00

dialogs

Component: Button Migration 2: IconButton (#7598 )

2025-12-17 18:11:43 -08:00

job

[refactor] Rename queueIndex variables to reflect job.priority usage (#9258 )

2026-02-26 18:31:27 -08:00

JobHistoryActionsMenu.vue

fix: make docked job history toggle persistence-safe (#9265 )

2026-02-26 19:49:08 -08:00

QueueInlineProgress.test.ts

fix: replace as-unknown-as casts with safer patterns (#9107 )