mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
## Summary Add Vue Testing Library (VTL) infrastructure and pilot-migrate ComfyQueueButton.test.ts as Phase 0 of an incremental VTL adoption. ## Changes - **What**: Install `@testing-library/vue`, `@testing-library/user-event`, `@testing-library/jest-dom`, and `eslint-plugin-testing-library`. Configure jest-dom matchers globally via `vitest.setup.ts` and `tsconfig.json`. Create shared render wrapper at `src/utils/test-utils.ts` (pre-configures PrimeVue, Pinia, i18n). Migrate `ComfyQueueButton.test.ts` from `@vue/test-utils` to VTL. Add warn-level `testing-library/*` ESLint rules for test files. - **Dependencies**: `@testing-library/vue`, `@testing-library/user-event`, `@testing-library/jest-dom`, `eslint-plugin-testing-library` ## Review Focus - `src/utils/test-utils.ts` — shared render wrapper typing approach (uses `ComponentMountingOptions` from VTU since VTL's `RenderOptions` requires a generic parameter) - ESLint rules are all set to `warn` during migration to avoid breaking existing VTU tests - VTL coexists with VTU — no existing tests are broken ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10319-test-add-Vue-Testing-Library-infrastructure-and-pilot-migration-3286d73d3650812793ccd8a839550a04) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
44 lines
1.3 KiB
TypeScript
44 lines
1.3 KiB
TypeScript
import path from 'node:path'
|
|
|
|
export default {
|
|
'tests-ui/**': () =>
|
|
'echo "Files in tests-ui/ are deprecated. Colocate tests with source files." && exit 1',
|
|
|
|
'./**/*.{css,vue}': (stagedFiles: string[]) => {
|
|
const joinedPaths = toJoinedRelativePaths(stagedFiles)
|
|
return [`pnpm exec stylelint --allow-empty-input ${joinedPaths}`]
|
|
},
|
|
|
|
'./**/*.js': (stagedFiles: string[]) => formatAndEslint(stagedFiles),
|
|
|
|
'./**/*.{ts,tsx,vue,mts,json,yaml}': (stagedFiles: string[]) => {
|
|
const commands = [...formatAndEslint(stagedFiles), 'pnpm typecheck']
|
|
|
|
const hasBrowserTestsChanges = stagedFiles
|
|
.map((f) => path.relative(process.cwd(), f).replace(/\\/g, '/'))
|
|
.some((f) => f.startsWith('browser_tests/'))
|
|
|
|
if (hasBrowserTestsChanges) {
|
|
commands.push('pnpm typecheck:browser')
|
|
}
|
|
|
|
return commands
|
|
}
|
|
}
|
|
|
|
function formatAndEslint(fileNames: string[]) {
|
|
const joinedPaths = toJoinedRelativePaths(fileNames)
|
|
return [
|
|
`pnpm exec oxfmt --write ${joinedPaths}`,
|
|
`pnpm exec oxlint --fix ${joinedPaths}`,
|
|
`pnpm exec eslint --cache --fix --no-warn-ignored ${joinedPaths}`
|
|
]
|
|
}
|
|
|
|
function toJoinedRelativePaths(fileNames: string[]) {
|
|
const relativePaths = fileNames.map((f) =>
|
|
path.relative(process.cwd(), f).replace(/\\/g, '/')
|
|
)
|
|
return relativePaths.map((p) => `"${p}"`).join(' ')
|
|
}
|