mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-22 13:32:11 +00:00
c703db5f6c
## Summary - remove Nx root/config artifacts and workspace x metadata - replace Nx-based root scripts with direct pnpm workspace + native Vite/Vitest/Playwright commands - remove Nx dependencies/catalog entries and regenerate lockfile - clean residual Nx references from CI workflows, tooling config, and docs ## Validation - pnpm install --frozen-lockfile - pnpm lint - pnpm typecheck - pnpm build - pnpm build:cloud - pnpm build:desktop - pnpm build:types - pnpm test:browser -- --list - pnpm test:unit *(4 pre-existing failing tests)* ΓöåIssue is synchronized with this [Notion page](https://www.notion.so/PR-12355-chore-remove-Nx-and-migrate-monorepo-workflows-to-pnpm-3666d73d3650817888b9e85e24a10b22) by [Unito](https://www.unito.io) --- **For keeping Nx** - Better monorepo orchestration (task graph, affected runs, caching). - Can reduce CI/runtime cost at larger scale. - Unified interface across tools and packages. **Against keeping Nx** - Extra abstraction layer and config complexity. - Higher maintenance/debugging cost (plugins, cache behavior, drift). - Native `pnpm` + tool CLIs are simpler and clearer today. **Bottom line** - If current pain is low: prefer simplicity and remove Nx. - If measured scale pain is high: orchestration may be worth it (Nx or another tool later). --------- Co-authored-by: Amp <amp@ampcode.com>
GitHub Workflows
Naming Convention
Workflow files follow a consistent naming pattern: <prefix>-<descriptive-name>.yaml
Category Prefixes
| Prefix | Purpose | Example |
|---|---|---|
ci- |
Testing, linting, validation | ci-tests-e2e.yaml |
release- |
Version management, publishing | release-version-bump.yaml |
pr- |
PR automation (triggered by labels) | pr-claude-review.yaml |
api- |
External Api type generation | api-update-registry-api-types.yaml |
i18n- |
Internationalization updates | i18n-update-core.yaml |
Documentation
Each workflow file contains comments explaining its purpose, triggers, and behavior. For specific details about what each workflow does, refer to the comments at the top of each .yaml file.
For GitHub Actions documentation, see Events that trigger workflows.