mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-26 19:09:52 +00:00
9ef6f94f92
Fixed the AUDIO_RECORD widget to display correctly in both rendering modes: - Removed conflicting AUDIO_RECORD registration from ComfyWidgets that was blocking the custom widget implementation in uploadAudio.ts extension - Changed canvasOnly flags from true to false on both audioUIWidget and recordWidget to enable Vue nodes rendering - Added type override (recordWidget.type = 'audiorecord') after widget creation to enable Vue component lookup while preserving LiteGraph button rendering - Removed unused IAudioRecordWidget type definition The widget now works correctly: - LiteGraph mode: Displays as a functional button - Vue nodes mode: Displays full recording UI with waveform visualization ## Summary <!-- One sentence describing what changed and why. --> ## Changes - **What**: <!-- Core functionality added/modified --> - **Breaking**: <!-- Any breaking changes (if none, remove this line) --> - **Dependencies**: <!-- New dependencies (if none, remove this line) --> ## Review Focus <!-- Critical design decisions or edge cases that need attention --> <!-- If this PR fixes an issue, uncomment and update the line below --> <!-- Fixes #ISSUE_NUMBER --> ## Screenshots (if applicable) <!-- Add screenshots or video recording to help explain your changes --> https://github.com/user-attachments/assets/cf6513d4-0a4b-4210-88e2-a948855b5206 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6094-fix-Enable-AUDIO_RECORD-widget-in-both-LiteGraph-and-Vue-nodes-modes-28e6d73d365081faa879f53e3e2dddad) by [Unito](https://www.unito.io) --------- Co-authored-by: bymyself <cbyrne@comfy.org>
29 lines
982 B
TypeScript
29 lines
982 B
TypeScript
import { expect } from '@playwright/test'
|
|
|
|
import { comfyPageFixture as test } from '../fixtures/ComfyPage'
|
|
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.setSetting('Comfy.UseNewMenu', 'Disabled')
|
|
})
|
|
|
|
test.describe('Record Audio Node', () => {
|
|
test('should add a record audio node and take a screenshot', async ({
|
|
comfyPage
|
|
}) => {
|
|
// Open the search box by double clicking on the canvas
|
|
await comfyPage.doubleClickCanvas()
|
|
await expect(comfyPage.searchBox.input).toHaveCount(1)
|
|
|
|
// Search for and add the RecordAudio node
|
|
await comfyPage.searchBox.fillAndSelectFirstNode('RecordAudio')
|
|
await comfyPage.nextFrame()
|
|
|
|
// Verify the RecordAudio node was added
|
|
const recordAudioNodes = await comfyPage.getNodeRefsByType('RecordAudio')
|
|
expect(recordAudioNodes.length).toBe(1)
|
|
|
|
// Take a screenshot of the canvas with the RecordAudio node
|
|
await expect(comfyPage.canvas).toHaveScreenshot('record_audio_node.png')
|
|
})
|
|
})
|