mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-05 21:54:50 +00:00
## Summary - Replace hardcoded `text-white` class with theme-aware alternatives to fix invisible text on light themes - Update Load3D control backgrounds to use semantic tokens - Update dropdown menus to use `bg-interface-menu-surface` - Update overlay backgrounds to use `bg-backdrop` with opacity ## Changes | Component | Old | New | |-----------|-----|-----| | Text on primary bg | `text-white` | `text-base-foreground` | | Dropdown menus | `bg-black/50` | `bg-interface-menu-surface` | | Control panels | `bg-smoke-700/30` | `bg-backdrop/30` | | Loading overlays | `bg-black bg-opacity-50` | `bg-backdrop/50` | | Selected states | `bg-smoke-600` | `bg-button-active-surface` | ## Files Modified (14) - `src/components/TopMenuSection.vue` - `src/components/input/MultiSelect.vue` - `src/components/load3d/*.vue` (12 files) - `src/renderer/extensions/vueNodes/VideoPreview.vue` ## Test plan - [ ] Verify text visibility in light theme - [ ] Verify text visibility in dark theme - [ ] Test Load3D viewer controls functionality - [ ] Test MultiSelect dropdown checkbox visibility ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7908-fix-replace-text-white-with-theme-aware-color-tokens-2e26d73d36508107bb01d1d6e3b74f6a) by [Unito](https://www.unito.io)
80 lines
2.2 KiB
Vue
80 lines
2.2 KiB
Vue
<template>
|
|
<div class="flex flex-col">
|
|
<div v-if="showLightIntensityButton" class="show-light-intensity relative">
|
|
<Button
|
|
v-tooltip.right="{
|
|
value: $t('load3d.lightIntensity'),
|
|
showDelay: 300
|
|
}"
|
|
size="icon"
|
|
variant="textonly"
|
|
class="rounded-full"
|
|
:aria-label="$t('load3d.lightIntensity')"
|
|
@click="toggleLightIntensity"
|
|
>
|
|
<i class="pi pi-sun text-lg text-base-foreground" />
|
|
</Button>
|
|
<div
|
|
v-show="showLightIntensity"
|
|
class="absolute top-0 left-12 rounded-lg bg-black/50 p-4 shadow-lg"
|
|
style="width: 150px"
|
|
>
|
|
<Slider
|
|
v-model="lightIntensity"
|
|
class="w-full"
|
|
:min="lightIntensityMinimum"
|
|
:max="lightIntensityMaximum"
|
|
:step="lightAdjustmentIncrement"
|
|
/>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</template>
|
|
|
|
<script setup lang="ts">
|
|
import Slider from 'primevue/slider'
|
|
import { computed, onMounted, onUnmounted, ref } from 'vue'
|
|
|
|
import Button from '@/components/ui/button/Button.vue'
|
|
import type { MaterialMode } from '@/extensions/core/load3d/interfaces'
|
|
import { useSettingStore } from '@/platform/settings/settingStore'
|
|
|
|
const lightIntensity = defineModel<number>('lightIntensity')
|
|
const materialMode = defineModel<MaterialMode>('materialMode')
|
|
|
|
const showLightIntensityButton = computed(
|
|
() => materialMode.value === 'original'
|
|
)
|
|
const showLightIntensity = ref(false)
|
|
|
|
const lightIntensityMaximum = useSettingStore().get(
|
|
'Comfy.Load3D.LightIntensityMaximum'
|
|
)
|
|
const lightIntensityMinimum = useSettingStore().get(
|
|
'Comfy.Load3D.LightIntensityMinimum'
|
|
)
|
|
const lightAdjustmentIncrement = useSettingStore().get(
|
|
'Comfy.Load3D.LightAdjustmentIncrement'
|
|
)
|
|
|
|
function toggleLightIntensity() {
|
|
showLightIntensity.value = !showLightIntensity.value
|
|
}
|
|
|
|
function closeLightSlider(e: MouseEvent) {
|
|
const target = e.target as HTMLElement
|
|
|
|
if (!target.closest('.show-light-intensity')) {
|
|
showLightIntensity.value = false
|
|
}
|
|
}
|
|
|
|
onMounted(() => {
|
|
document.addEventListener('click', closeLightSlider)
|
|
})
|
|
|
|
onUnmounted(() => {
|
|
document.removeEventListener('click', closeLightSlider)
|
|
})
|
|
</script>
|