mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 13:59:28 +00:00
8b1cf594d1
## Summary - Move error red border from TopMenuSection/ComfyActionbar to ErrorOverlay - Add error indicator (outline + StatusBadge dot) on right side panel toggle button when errors are present, the panel/overlay are closed, and the errors tab setting is enabled - Replace technical group titles (e.g. "Missing Node Packs") with user-friendly i18n messages in ErrorOverlay - Dynamically change action button label based on single error type (e.g. "Show missing nodes" instead of "See Errors") - Remove unused `hasAnyError` prop from ComfyActionbar - Fix `type="secondary"` → `variant="secondary"` on panel toggle button - Pre-wire `missing_media` error type support for #10309 - Migrate ErrorOverlay E2E selectors from `getByText`/`getByRole` to `data-testid` - Update E2E screenshot snapshots affected by TopMenuSection error state design changes ## Test plan - [x] Trigger execution error → verify red border on ErrorOverlay, no red border on TopMenuSection/ComfyActionbar - [x] With errors and right side panel closed → verify red outline + dot on panel toggle button - [x] Open right side panel or error overlay → verify indicator disappears - [x] Disable `Comfy.RightSidePanel.ShowErrorsTab` → verify no indicator even with errors - [x] Load workflow with only missing nodes → verify "Show missing nodes" button label and friendly message - [x] Load workflow with only missing models → verify "Show missing models" button label and count message - [x] Load workflow with mixed errors → verify "See Errors" fallback label - [x] E2E: `pnpm test:browser:local -- --grep "Error overlay"` ## Screenshots <img width="498" height="381" alt="스크린샷 2026-03-26 230252" src="https://github.com/user-attachments/assets/034f0f3f-e6a1-4617-b8f6-cd4c145e3a47" /> <img width="550" height="303" alt="스크린샷 2026-03-26 230525" src="https://github.com/user-attachments/assets/2958914b-0ff0-461b-a6ea-7f2811bf33c2" /> <img width="551" height="87" alt="스크린샷 2026-03-26 230318" src="https://github.com/user-attachments/assets/396e9cb1-667e-44c4-83fe-ab113b313d16" /> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Dante <bunggl@naver.com>
94 lines
2.9 KiB
TypeScript
94 lines
2.9 KiB
TypeScript
import type { Page } from '@playwright/test'
|
|
|
|
import {
|
|
comfyPageFixture as test,
|
|
comfyExpect as expect
|
|
} from '../fixtures/ComfyPage'
|
|
import { TestIds } from '../fixtures/selectors'
|
|
|
|
test.describe('Error overlay See Errors flow', { tag: '@ui' }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
|
|
await comfyPage.settings.setSetting(
|
|
'Comfy.RightSidePanel.ShowErrorsTab',
|
|
true
|
|
)
|
|
await comfyPage.setup()
|
|
})
|
|
|
|
async function triggerExecutionError(comfyPage: {
|
|
canvasOps: { disconnectEdge: () => Promise<void> }
|
|
page: Page
|
|
command: { executeCommand: (cmd: string) => Promise<void> }
|
|
}) {
|
|
await comfyPage.canvasOps.disconnectEdge()
|
|
await comfyPage.page.keyboard.press('Escape')
|
|
await comfyPage.command.executeCommand('Comfy.QueuePrompt')
|
|
}
|
|
|
|
test('Error overlay appears on execution error', async ({ comfyPage }) => {
|
|
await triggerExecutionError(comfyPage)
|
|
|
|
await expect(
|
|
comfyPage.page.getByTestId(TestIds.dialogs.errorOverlay)
|
|
).toBeVisible()
|
|
})
|
|
|
|
test('Error overlay shows error message', async ({ comfyPage }) => {
|
|
await triggerExecutionError(comfyPage)
|
|
|
|
const overlay = comfyPage.page.getByTestId(TestIds.dialogs.errorOverlay)
|
|
await expect(overlay).toBeVisible()
|
|
await expect(overlay).toHaveText(/\S/)
|
|
})
|
|
|
|
test('"See Errors" opens right side panel', async ({ comfyPage }) => {
|
|
await triggerExecutionError(comfyPage)
|
|
|
|
const overlay = comfyPage.page.getByTestId(TestIds.dialogs.errorOverlay)
|
|
await expect(overlay).toBeVisible()
|
|
|
|
await overlay.getByTestId(TestIds.dialogs.errorOverlaySeeErrors).click()
|
|
|
|
await expect(comfyPage.page.getByTestId('properties-panel')).toBeVisible()
|
|
})
|
|
|
|
test('"See Errors" dismisses the overlay', async ({ comfyPage }) => {
|
|
await triggerExecutionError(comfyPage)
|
|
|
|
const overlay = comfyPage.page.getByTestId(TestIds.dialogs.errorOverlay)
|
|
await expect(overlay).toBeVisible()
|
|
|
|
await overlay.getByTestId(TestIds.dialogs.errorOverlaySeeErrors).click()
|
|
|
|
await expect(overlay).not.toBeVisible()
|
|
})
|
|
|
|
test('"Dismiss" closes overlay without opening panel', async ({
|
|
comfyPage
|
|
}) => {
|
|
await triggerExecutionError(comfyPage)
|
|
|
|
const overlay = comfyPage.page.getByTestId(TestIds.dialogs.errorOverlay)
|
|
await expect(overlay).toBeVisible()
|
|
|
|
await overlay.getByTestId(TestIds.dialogs.errorOverlayDismiss).click()
|
|
|
|
await expect(overlay).not.toBeVisible()
|
|
await expect(
|
|
comfyPage.page.getByTestId('properties-panel')
|
|
).not.toBeVisible()
|
|
})
|
|
|
|
test('Close button (X) dismisses overlay', async ({ comfyPage }) => {
|
|
await triggerExecutionError(comfyPage)
|
|
|
|
const overlay = comfyPage.page.getByTestId(TestIds.dialogs.errorOverlay)
|
|
await expect(overlay).toBeVisible()
|
|
|
|
await overlay.getByRole('button', { name: /close/i }).click()
|
|
|
|
await expect(overlay).not.toBeVisible()
|
|
})
|
|
})
|