## Summary
Selecting a node no longer filters the errors tab down to that node —
the tab now always shows every error in the workflow, and selection
instead *emphasizes* the matching entries (auto-expand, row highlight,
and a context label), so the error count never lies about whether the
workflow can run.
## Why
The errors tab has quietly been playing two roles at once. It is a
**status surface** ("is this workflow runnable? what's broken and how
much?") — that's what the hero count, the panel-button badge, and the
Run warning all lean on. But it also behaves like an **inspector**:
select a node and the whole list silently narrows to that node's errors.
Mixing the two is confusing in a very concrete way: with 3 errors in the
workflow, clicking one error node makes the tab read "1 Error detected".
Fix that one error while it's selected and the tab reads as clean —
while Run would still fail on the other two. The count changes meaning
depending on an invisible condition (selection), and it disagrees with
the global badges right next to it. This is the same reason VS Code's
Problems panel always lists everything and makes "current file only" an
explicit toggle rather than an implicit one.
## Changes
- **What**: Selection now works as emphasis on top of an always-complete
list:
- The hero count and the group list always describe the whole workflow,
regardless of selection.
- Selecting a node with errors auto-expands the groups containing them
and collapses the rest; clearing the selection (or moving it to an
error-free node) restores the expansion. Manual collapse choices are
left alone when a selection never matched anything.
- Matching entries get a background highlight using the design-system
selection blue (`--color-blue-selection`), so the panel emphasis
visually matches the canvas selection color. The highlight fades in/out
and bleeds slightly past the text without shifting any layout. This
works across all error kinds: execution errors, missing models, missing
media, missing node packs, and swap suggestions (each row/pack that
references the selected node is highlighted).
- A **resident context strip** sits between the hero and the list. With
no selection it reads `{n} nodes — {count} errors` as a workflow
summary; while a selection has errors it switches to `{node title} —
{count} errors` (or `{n} nodes selected — …` for multi-select). Because
the strip always occupies its slot, selecting/deselecting never reflows
the list.
- The strip is deliberately **always visible** rather than mounted on
demand: we plan to rename the tab to "Issues" and downgrade the
missing-* categories from errors to warnings, at which point this same
line becomes the mixed status readout (`X nodes — X errors / X
warnings`). Landing it as a resident status line now means that change
is a label swap, not a layout change.
- **Refactor**: the tab body (search, hero, grouped cards,
locate/install/replace handlers) is extracted from `TabErrors.vue` into
a reusable `ErrorGroupList.vue` — a follow-up PR mounts it outside the
sidebar. The old selection-filter machinery is kept internally as
`selectionScopedGroups` and now only derives the emphasis state (matched
group keys / card ids / asset node ids, selection error count). The
orphaned `compact` prop on `ErrorNodeCard` is removed along with it.
- **Fixes along the way**: node titles containing `=`/`&` no longer
render as HTML entities in the strip (title goes through `i18n-t` slots
instead of an escaped `t()` param), untitled nodes fall back to
"Untitled" instead of producing "1 nodes selected", and emphasized rows
expose their state to assistive tech via `aria-current` while the strip
announces via `role="status"`.
## Review Focus
- `useErrorGroups.ts`: the selection-emphasis derivation
(`selectionScopedGroups` and the `selectionMatched*` computeds).
Selection matching resolves execution ids through the graph (and by
container prefix for subgraph selections) rather than comparing raw ids
— the new unit tests pin both paths.
- `ErrorGroupList.vue`: the emphasis watcher (immediate,
membership-signature based) that syncs collapse state, and the strip
mode switch. The component tests cover the expand/collapse/restore
cycle, emphasis for selections that predate mount, and the strip label
states.
- The two e2e tests that previously asserted the filtering behavior now
assert the new one (counts stay global, strip shows the selection-scoped
count, deselect returns to the summary).
Known follow-ups (intentionally out of scope): distinct-node counting
can over/under-count in subgraph + mixed-error edge cases (execution ids
vs serialized ids), snapshot/restore of user collapse state across
emphasis, and narrowing the list-container `aria-live` region.
## Screenshots (if applicable)
Before
https://github.com/user-attachments/assets/ccf98954-83ed-4333-ba4e-31cedb9fc38b
### After
https://github.com/user-attachments/assets/f7317e4b-71c2-4009-94cc-25287979c0e4
https://github.com/user-attachments/assets/9008c100-0ec0-4612-8fe4-942fec1be2fe
https://github.com/user-attachments/assets/45734552-9986-41f8-93ad-5d072e355d3d
Playwright Testing for ComfyUI_frontend
This document outlines the setup, usage, and common patterns for Playwright browser tests in the ComfyUI_frontend project.
Prerequisites
CRITICAL: Start ComfyUI backend with --multi-user flag:
python main.py --multi-user
Without this flag, parallel tests will conflict and fail randomly.
Setup
ComfyUI devtools
ComfyUI_devtools is included in this repository under tools/devtools/. During CI/CD, these files are automatically copied to the custom_nodes directory.
ComfyUI_devtools adds additional API endpoints and nodes to ComfyUI for browser testing.
For local development, copy the devtools files to your ComfyUI installation:
cp -r tools/devtools/* /path/to/your/ComfyUI/custom_nodes/ComfyUI_devtools/
Node.js & Playwright Prerequisites
Ensure you have the Node.js version specified in .nvmrc installed.
Then, set up the Chromium test driver:
pnpm exec playwright install chromium --with-deps
Environment Configuration
Create .env from the template:
cp .env_example .env
Key settings for debugging:
# Remove Vue dev overlay that blocks UI elements
DISABLE_VUE_PLUGINS=true
# Test against dev server (recommended) or backend directly
PLAYWRIGHT_TEST_URL=http://localhost:5173 # Dev server
# PLAYWRIGHT_TEST_URL=http://localhost:8188 # Direct backend
PLAYWRIGHT_SETUP_API_URL=http://localhost:8188 # Setup/auth API when using the dev server URL above
# Path to ComfyUI for backing up user data/settings before tests
TEST_COMFYUI_DIR=/path/to/your/ComfyUI
Common Setup Issues
Release API Mocking
By default, all tests mock the release API (api.comfy.org/releases) to prevent release notification popups from interfering with test execution. This is necessary because the release notifications can appear over UI elements and block test interactions.
To test with real release data, you can disable mocking:
await comfyPage.setup({ mockReleases: false })
For tests that specifically need to test release functionality, see the example in tests/releaseNotifications.spec.ts.
Running Tests
Always use UI mode for development:
pnpm test:browser:local --ui
UI mode features:
- Locator picker: Click the target icon, then click any element to get the exact locator code to use in your test. The code appears in the Locator tab.
- Step debugging: Step through your test line-by-line by clicking Source tab
- Time travel: In the Actions tab/panel, click any step to see the browser state at that moment
- Console/Network Tabs: View logs and API calls at each step
- Attachments Tab: View all snapshots with expected and actual images
For CI or headless testing:
pnpm test:browser:local # Run all tests
pnpm test:browser:local widget.spec.ts # Run specific test file
Slowing the browser down for debugging
When running with --headed (or --ui), set SLOW_MO to a millisecond delay
to slow every Playwright action down so you can watch what is happening. The
delay only applies when PLAYWRIGHT_LOCAL is set (the default for the
pnpm test:browser:local script).
SLOW_MO=250 pnpm test:browser:local --headed widget.spec.ts
Test Structure
Browser tests in this project follow a specific organization pattern:
-
Fixtures: Located in
fixtures/- These provide test setup and utilitiesComfyPage.ts- The main fixture for interacting with ComfyUIComfyMouse.ts- Utility for mouse interactions with the canvas- Components fixtures in
fixtures/components/- Page object models for UI components
-
Tests: Located in
tests/- The actual test specifications- Organized by functionality (e.g.,
widget.spec.ts,interaction.spec.ts) - Snapshot directories (e.g.,
widget.spec.ts-snapshots/) contain reference screenshots
- Organized by functionality (e.g.,
-
Utilities: Located in
utils/- Common utility functionslitegraphUtils.ts- Utilities for working with LiteGraph nodes
Writing Effective Tests
When writing new tests, follow these patterns:
Test Structure
// Import the test fixture
import { comfyPageFixture as test } from '@e2e/fixtures/ComfyPage'
test.describe('Feature Name', () => {
// Set up test environment if needed
test.beforeEach(async ({ comfyPage }) => {
// Common setup
})
test('should do something specific', async ({ comfyPage }) => {
// Test implementation
})
})
Leverage Existing Fixtures and Helpers
Always check for existing helpers and fixtures before implementing new ones:
- ComfyPage: Main fixture with methods for canvas interaction and node management
- ComfyMouse: Helper for precise mouse operations on the canvas
- Component Fixtures: Check
browser_tests/fixtures/components/for UI component page objects (e.g.Actionbar.ts,Templates.ts,ContextMenu.ts) - Helper Classes: Check
browser_tests/fixtures/helpers/for domain-specific helper classes wired into ComfyPage (e.g.CanvasHelper.ts,WorkflowHelper.ts) - Utility Functions: Check
browser_tests/fixtures/utils/for standalone utilities (e.g.fitToView.ts,clipboardSpy.ts,builderTestUtils.ts)
Most common testing needs are already addressed by these helpers, which will make your tests more consistent and reliable.
Import Conventions
- Prefer
@e2e/*for imports withinbrowser_tests/ - Continue using
@/*for imports fromsrc/ - Avoid introducing new deep relative imports within
browser_tests/when the alias is available
Key Testing Patterns
-
Focus elements explicitly: Canvas-based elements often need explicit focus before interaction:
// Click the canvas first to focus it before pressing keys await comfyPage.canvas.click() await comfyPage.page.keyboard.press('a') -
Mark canvas as dirty if needed: Some interactions need explicit canvas updates:
// After programmatically changing node state, mark canvas dirty await comfyPage.page.evaluate(() => { window['app'].graph.setDirtyCanvas(true, true) }) -
Use node references over coordinates: Node references from
fixtures/utils/litegraphUtils.tsprovide stable ways to interact with nodes:// Prefer this: const node = await comfyPage.getNodeRefsByType('LoadImage')[0] await node.click('title') // Over this: await comfyPage.canvas.click({ position: { x: 100, y: 100 } }) -
Wait for canvas to render after UI interactions:
await comfyPage.nextFrame() -
Clean up persistent server state: While most state is reset between tests, anything stored on the server persists:
// Reset settings that affect other tests (these are stored on server) await comfyPage.setSetting('Comfy.ColorPalette', 'dark') await comfyPage.setSetting('Comfy.NodeBadge.NodeIdBadgeMode', 'None') // Clean up uploaded files if needed comfyPage.deleteFileAfterTest({ filename: 'image.png' }) -
Prefer functional assertions over screenshots: Use screenshots only when visual verification is necessary:
// Prefer this: await expect.poll(() => node.isPinned()).toBe(true) await expect.poll(() => node.getProperty('title')).toBe('Expected Title') // Over this - only use when needed: await expect(comfyPage.canvas).toHaveScreenshot('state.png') -
Use minimal test workflows: When creating test workflows, keep them as minimal as possible:
// Include only the components needed for the test await comfyPage.loadWorkflow('single_ksampler') -
Debug helpers for visual debugging (remove before committing):
ComfyPage includes temporary debug methods for troubleshooting:
test('debug failing interaction', async ({ comfyPage }, testInfo) => { // Add visual markers to see click positions await comfyPage.debugAddMarker({ x: 100, y: 200 }) // Attach screenshot with markers to test report await comfyPage.debugAttachScreenshot(testInfo, 'node-positions', { element: 'canvas', markers: [{ position: { x: 100, y: 200 } }] }) // Show canvas overlay for easier debugging await comfyPage.debugShowCanvasOverlay() // Remember to remove debug code before committing! })Available debug methods:
debugAddMarker(position)- Red circle at positiondebugAttachScreenshot(testInfo, name)- Attach to test reportdebugShowCanvasOverlay()- Show canvas as overlaydebugGetCanvasDataURL()- Get canvas as base64
Common Patterns and Utilities
Page Object Pattern
Tests use the Page Object pattern to create abstractions over the UI:
// Using the ComfyPage fixture
test('Can toggle boolean widget', async ({ comfyPage }) => {
await comfyPage.loadWorkflow('widgets/boolean_widget')
const node = (await comfyPage.getFirstNodeRef())!
const widget = await node.getWidget(0)
await widget.click()
})
Node References
The NodeReference class provides helpers for interacting with LiteGraph nodes:
// Getting node by type and interacting with it
const nodes = await comfyPage.getNodeRefsByType('LoadImage')
const loadImageNode = nodes[0]
const widget = await loadImageNode.getWidget(0)
await widget.click()
Visual Regression Testing
Tests use screenshot comparisons to verify UI state:
// Take a screenshot and compare to reference
await expect(comfyPage.canvas).toHaveScreenshot('boolean_widget_toggled.png')
Waiting for Animations
Always call nextFrame() after actions that trigger animations:
await comfyPage.canvas.click({ position: { x: 100, y: 100 } })
await comfyPage.nextFrame() // Wait for canvas to redraw
Mouse Interactions
Canvas operations use special helpers to ensure proper timing:
// Using ComfyMouse for drag and drop
await comfyMouse.dragAndDrop(
{ x: 100, y: 100 }, // From
{ x: 200, y: 200 } // To
)
// Standard ComfyPage helpers
await comfyPage.drag({ x: 100, y: 100 }, { x: 200, y: 200 })
await comfyPage.pan({ x: 200, y: 200 })
await comfyPage.zoom(-100) // Zoom in
Workflow Management
Tests use workflows stored in assets/ for consistent starting points:
// Load a test workflow
await comfyPage.loadWorkflow('single_ksampler')
// Wait for workflow to load and stabilize
await comfyPage.nextFrame()
Custom Assertions
The project includes custom Playwright assertions through comfyExpect:
// Check if a node is in a specific state
await expect(node).toBePinned()
await expect(node).toBeBypassed()
await expect(node).toBeCollapsed()
Troubleshooting Common Issues
Flaky Tests
- Timing Issues: Always wait for animations to complete with
nextFrame() - Coordinate Sensitivity: Canvas coordinates are viewport-relative; use node references when possible
- Test Isolation: Tests run in parallel; avoid dependencies between tests
- Screenshots vary: Ensure your OS and browser match the reference environment (Linux)
- Async / await: Race conditions are a very common cause of test flakiness
Screenshot Testing
Due to variations in system font rendering, screenshot expectations are platform-specific. Please note:
- Do not commit local screenshot expectations to the repository
- We maintain Linux screenshot expectations as our GitHub Action runner operates in a Linux environment
- While developing, you can generate local screenshots for your tests, but these will differ from CI-generated ones
Working with Screenshots Locally
Option 1 - Skip screenshot tests (add to playwright.config.ts):
export default defineConfig({
grep: process.env.CI ? undefined : /^(?!.*screenshot).*$/
})
Option 2 - Generate local baselines for comparison:
pnpm test:browser:local --update-snapshots
Creating New Screenshot Baselines
For PRs from Comfy-Org/ComfyUI_frontend branches:
- Write test with
toHaveScreenshot('filename.png') - Create PR and add
New Browser Test Expectationlabel - CI will generate and commit the Linux baseline screenshots
Note: Fork PRs cannot auto-commit screenshots. A maintainer will need to commit the screenshots manually for you (don't worry, they'll do it).
Viewing Test Reports
Automated Test Deployment
The project automatically deploys Playwright test reports to Cloudflare Pages for every PR and push to main branches.
Accessing Test Reports
- From PR comments: Click the "View Report" links for each browser
- Direct URLs: Reports are available at
https://[branch].comfyui-playwright-[browser].pages.dev(branch-specific deployments) - From GitHub Actions: Download artifacts from failed runs
How It Works
-
Test execution: All browser tests run in parallel across multiple browsers
-
Report generation: HTML reports are generated for each browser configuration
-
Cloudflare deployment: Each browser's report deploys to its own Cloudflare Pages project with branch isolation:
comfyui-playwright-chromium(with branch-specific URLs)comfyui-playwright-mobile-chrome(with branch-specific URLs)comfyui-playwright-chromium-2x(2x scale, with branch-specific URLs)comfyui-playwright-chromium-0-5x(0.5x scale, with branch-specific URLs)
-
PR comments: GitHub automatically updates PR comments with:
- ✅/❌ Test status for each browser
- Direct links to interactive test reports
- Real-time progress updates as tests complete
Resources
- Playwright UI Mode - Interactive test debugging
- Playwright Debugging Guide
- act - Run GitHub Actions locally for CI debugging