ComfyUI_frontend

mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-05-05 13:41:59 +00:00

Files

Christian Byrne 83f4e7060a test(infra): AssetHelper with builder pattern + deterministic fixtures (#10545 )

## What

Adds `AssetHelper` — a builder-pattern helper for mocking asset-related
API endpoints in Playwright E2E tests, plus deterministic fixture data.

## Why

12+ asset-related API endpoints need mocking for asset browser tests
(PNL-02), cloud dialog testing (DLG-08), and other asset-dependent E2E
scenarios. Random mock data from existing `createMockAssets()` is
unsuitable for deterministic E2E assertions.

## What's included

### `AssetHelper.ts` (307 LOC)
- Fluent builder API: `assetHelper.withModels(3).withImages(5).mock()`
- Stateful mock store (Map) for upload→verify→delete flows
- Endpoint coverage: GET/POST/PUT/DELETE `/assets`, download progress
- `mockError()` for error state testing
- `clearMocks()` cleanup matching QueueHelper/FeatureFlagHelper pattern

### `assetFixtures.ts` (304 LOC)
- 11 stable named constants (checkpoints, loras, VAE, embedding, inputs,
outputs)
- Factory functions: `generateModels()`, `generateInputFiles()`,
`generateOutputAssets()`
- Fixed IDs/dates/sizes — no randomness, safe for screenshot comparisons

### ComfyPage integration
- Available as `comfyPage.assets` in all tests

## Testing
- TypeScript compiles clean
- Follows existing QueueHelper/FeatureFlagHelper conventions

## Unblocks
- PNL-02: Asset browser tests (@Jaewon Yoon)
- DLG-08: Assets modal / cloud dialog testing

Part of: Test Coverage Q2 Overhaul

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10545-test-infra-AssetHelper-with-builder-pattern-deterministic-fixtures-32f6d73d365081d3985ef079ff3dbede)
by [Unito](https://www.unito.io)

---------

Co-authored-by: GitHub Action <action@github.com>

2026-04-07 14:23:36 -07:00

colorPalette.spec.ts-snapshots

feat: surface missing models in Error Tab for OSS and remove legacy dialog (#9921 )

2026-03-15 22:46:47 +09:00

copyPaste.spec.ts-snapshots

feat: surface missing models in Error Tab for OSS and remove legacy dialog (#9921 )

2026-03-15 22:46:47 +09:00

dialogs

test: add QueueClearHistoryDialog E2E tests (DLG-02) (#10586 )

2026-03-29 16:02:19 -07:00

domWidget.spec.ts-snapshots

Component: The Rest of the PrimeVue buttons (#7649 )

2025-12-29 15:03:34 -08:00

execution.spec.ts-snapshots

fix: improve error overlay design and indicator placement (#10564 )

2026-03-27 09:11:26 +09:00

graphCanvasMenu.spec.ts-snapshots

feat: surface missing models in Error Tab for OSS and remove legacy dialog (#9921 )

2026-03-15 22:46:47 +09:00

groupNode.spec.ts-snapshots

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00

imageCompare.spec.ts-snapshots

fix: image compare node displays wrong height with mismatched resolut… (#10714 )

2026-03-29 14:45:56 -07:00

interaction.spec.ts-snapshots

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00

loadWorkflowInMedia.spec.ts-snapshots

feat: surface missing models in Error Tab for OSS and remove legacy dialog (#9921 )

2026-03-15 22:46:47 +09:00

lodThreshold.spec.ts-snapshots

feat: surface missing models in Error Tab for OSS and remove legacy dialog (#9921 )

2026-03-15 22:46:47 +09:00

maskEditor.spec.ts-snapshots

add basic mask editor tests (#10574 )

2026-03-27 16:04:36 -04:00

minimap.spec.ts-snapshots

test: add minimap e2e tests for close button, viewport, and pan (#10596 )

2026-03-28 23:19:04 -07:00

mobileBaseline.spec.ts-snapshots

fix: improve error overlay design and indicator placement (#10564 )

2026-03-27 09:11:26 +09:00

nodeBadge.spec.ts-snapshots

feat: surface missing models in Error Tab for OSS and remove legacy dialog (#9921 )

2026-03-15 22:46:47 +09:00

nodeDisplay.spec.ts-snapshots

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

nodeSearchBox.spec.ts-snapshots

feat: surface missing models in Error Tab for OSS and remove legacy dialog (#9921 )

2026-03-15 22:46:47 +09:00

noteNode.spec.ts-snapshots

Style: Font Consistency (#7220 )

2025-12-08 19:48:11 -07:00

painter.spec.ts-snapshots

test: add painter widget e2e tests (#10599 )

2026-03-27 00:19:17 -04:00

primitiveNode.spec.ts-snapshots

Disable control widgets on link to parent (#8112 )

2026-01-16 22:11:00 -07:00

propertiesPanel

test: comprehensive properties panel E2E tests (PNL-01) (#10548 )

2026-03-29 15:57:42 -07:00

queue

test: address review comments on new browser tests (#10852 )

2026-04-04 19:26:55 -07:00

recordAudio.spec.ts-snapshots

feat: surface missing models in Error Tab for OSS and remove legacy dialog (#9921 )

2026-03-15 22:46:47 +09:00

rerouteNode.spec.ts-snapshots

feat: surface missing models in Error Tab for OSS and remove legacy dialog (#9921 )

2026-03-15 22:46:47 +09:00

rightClickMenu.spec.ts-snapshots

[feat] Improve group title layout (#9839 )

2026-03-24 12:25:18 -07:00

saveImageAndWebp.spec.ts-snapshots

fix: center ComfyUI logo in sidebar menu button with chevron (#9722 )

2026-03-12 01:10:26 -07:00

selectionToolbox.spec.ts-snapshots

test: update E2E to expect missing nodes overlay on tab switch (#10190 )

2026-03-17 10:46:19 -07:00

sidebar

Support svg outputs in assets panel (#10470 )

2026-04-07 13:53:37 -07:00

subgraph

fix: Ensure zero uuid root graphs get assigned a valid id (#10825 )

2026-04-07 08:50:13 -07:00

templates.spec.ts-snapshots

feat: add Tag component from design system and rename SquareChip (#10650 )

2026-03-29 08:27:53 +09:00

topbar

test: add E2E tests for workflow tab operations (#10796 )

2026-04-03 07:07:31 +09:00

viewport.spec.ts-snapshots

fix: improve error overlay design and indicator placement (#10564 )

2026-03-27 09:11:26 +09:00

vueNodes

test: replace raw CSS selectors with TestIds in context menu spec (#10760 )

2026-04-02 21:04:50 +01:00

widget.spec.ts-snapshots

feat: surface missing models in Error Tab for OSS and remove legacy dialog (#9921 )

2026-03-15 22:46:47 +09:00

actionbar.spec.ts

test: add runtime-safe browser_tests alias (#10735 )

2026-03-30 19:24:09 +00:00

appModeDropdownClipping.spec.ts

test: App mode - setting widget value test (#10746 )

2026-04-07 13:53:01 -07:00

appModeWidgetRename.spec.ts

test: App mode - setting widget value test (#10746 )

2026-04-07 13:53:01 -07:00

appModeWidgetValues.spec.ts

test: App mode - setting widget value test (#10746 )

2026-04-07 13:53:01 -07:00

assetHelper.spec.ts

test(infra): AssetHelper with builder pattern + deterministic fixtures (#10545 )

2026-04-07 14:23:36 -07:00

backgroundImageUpload.spec.ts

test(browser): refactor browser tests for reliability and maintainability (#8510 )

2026-02-03 12:29:40 -08:00

bottomPanelLogs.spec.ts

test: E2E coverage for node search, bottom panel, focus mode, job history (#9556 )

2026-03-17 02:24:22 -07:00

bottomPanelShortcuts.spec.ts

[refactor] Migrate SettingDialog to BaseModalLayout design system (#8270 )

2026-02-12 16:27:11 +09:00

browserTabTitle.spec.ts

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00

builderReorder.spec.ts

test: App mode - setting widget value test (#10746 )

2026-04-07 13:53:01 -07:00

builderSaveFlow.spec.ts

test: App mode - setting widget value test (#10746 )

2026-04-07 13:53:01 -07:00

changeTracker.spec.ts

feat: synthetic widgets getter for SubgraphNode (proxy-widget-v2) (#8856 )

2026-02-23 13:33:41 -08:00

changeTrackerLoadGuard.spec.ts

test: Add test to prevent regression of workflow corruption during graph loading (#10623 )

2026-03-27 11:54:07 -07:00

cloud.spec.ts

test(infra): cloud Playwright project with @cloud/@oss tagging (#10546 )

2026-03-28 22:34:37 -07:00

collapsedNodeLinks.spec.ts

fix: collapsed node connection link positions (#10641 )

2026-04-01 13:49:12 +09:00

colorPalette.spec.ts

[feat] Improve group title layout (#9839 )

2026-03-24 12:25:18 -07:00

commands.spec.ts

test(browser): refactor browser tests for reliability and maintainability (#8510 )

2026-02-03 12:29:40 -08:00

confirmDialogTextWrap.spec.ts

refactor(test): extract dialog page objects from inline getByRole usage (#10822 )

2026-04-06 09:49:32 -07:00

containAudit.spec.ts

tool: add CSS containment audit skill and Playwright diagnostic (#10026 )

2026-03-27 10:08:41 +09:00

copyPaste.spec.ts

test: add copy/paste node and image paste e2e tests (#10233 )

2026-03-20 03:24:09 +01:00

customIcons.spec.ts

test(browser): refactor browser tests for reliability and maintainability (#8510 )

2026-02-03 12:29:40 -08:00

defaultKeybindings.spec.ts

test: add e2e tests for all default keybindings (#10440 )

2026-03-24 16:12:59 +01:00

dialog.spec.ts

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00

domWidget.spec.ts

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00

errorOverlaySeeErrors.spec.ts

fix: improve error overlay design and indicator placement (#10564 )

2026-03-27 09:11:26 +09:00

execution.spec.ts

fix: improve error overlay design and indicator placement (#10564 )

2026-03-27 09:11:26 +09:00

extensionAPI.spec.ts

test(browser): refactor browser tests for reliability and maintainability (#8510 )

2026-02-03 12:29:40 -08:00

featureFlags.spec.ts

fix: make serverFeatureFlags reactive via Vue ref (#9051 )

2026-02-21 18:43:58 +09:00

focusMode.spec.ts

test: E2E coverage for node search, bottom panel, focus mode, job history (#9556 )

2026-03-17 02:24:22 -07:00

graph.spec.ts

refactor: extract helpers from _removeDuplicateLinks and add integration tests (#10332 )

2026-03-21 08:03:55 +09:00

graphCanvasMenu.spec.ts

test: add FeatureFlagHelper and QueueHelper for E2E test infrastructure (#9554 )

2026-03-16 06:51:22 -07:00

groupCopyPaste.spec.ts

fix: LGraphGroup paste position (#9962 )

2026-03-15 18:47:47 +00:00

groupNode.spec.ts

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00

groupSelectChildren.spec.ts

feat: select group children on click (#9149 )

2026-03-13 06:13:18 -07:00

imageCompare.spec.ts

test: add image compare widget basic e2e tests (#10597 )

2026-03-27 18:15:11 -07:00

imagePastePriority.spec.ts

fix: skip node metadata paste when media node is selected (#9773 )

2026-03-12 08:44:11 -07:00

interaction.spec.ts

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00

jobHistoryActions.spec.ts

test: E2E coverage for node search, bottom panel, focus mode, job history (#9556 )

2026-03-17 02:24:22 -07:00

keybindingPresets.spec.ts

feat: import/export keybinding presets (#9681 )

2026-03-20 12:24:31 +01:00

keybindings.spec.ts

test(browser): refactor browser tests for reliability and maintainability (#8510 )

2026-02-03 12:29:40 -08:00

linearMode.spec.ts

fix: App mode - Widget dropdowns clipped in sidebar (#10338 )

2026-03-20 14:18:54 -07:00

litegraphEvent.spec.ts

test(browser): refactor browser tests for reliability and maintainability (#8510 )

2026-02-03 12:29:40 -08:00

loadWorkflowInMedia.spec.ts

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00

lodThreshold.spec.ts

test(browser): refactor browser tests for reliability and maintainability (#8510 )

2026-02-03 12:29:40 -08:00

maskEditor.spec.ts

add basic mask editor tests (#10574 )

2026-03-27 16:04:36 -04:00

menu.spec.ts

feat: synthetic widgets getter for SubgraphNode (proxy-widget-v2) (#8856 )

2026-02-23 13:33:41 -08:00

minimap.spec.ts

test: add minimap e2e tests for close button, viewport, and pan (#10596 )

2026-03-28 23:19:04 -07:00

missingMedia.spec.ts

feat: detect and resolve missing media inputs in error tab (#10309 )

2026-04-01 17:59:02 +09:00

mobileBaseline.spec.ts

fix: make graph canvas toolbar visible on mobile (#10168 )

2026-03-18 15:31:29 -07:00

nodeBadge.spec.ts

test(browser): refactor browser tests for reliability and maintainability (#8510 )

2026-02-03 12:29:40 -08:00

nodeDisplay.spec.ts

refactor: remove legacy missing nodes dialog (#10102 )

2026-03-17 11:14:44 +09:00

nodeGhostPlacement.spec.ts

Node ghost mode when adding nodes (#8694 )

2026-02-06 13:42:38 -08:00

nodeHelp.spec.ts

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00

nodeLibraryEssentials.spec.ts

test: add FeatureFlagHelper and QueueHelper for E2E test infrastructure (#9554 )

2026-03-16 06:51:22 -07:00

nodeSearchBox.spec.ts

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00

nodeSearchBoxV2.spec.ts

V2 Node Search (+ hidden Node Library changes) (#8987 )

2026-02-20 01:10:03 -08:00

nodeSearchBoxV2Extended.spec.ts

test: E2E coverage for node search, bottom panel, focus mode, job history (#9556 )

2026-03-17 02:24:22 -07:00

noteNode.spec.ts

test(browser): refactor browser tests for reliability and maintainability (#8510 )

2026-02-03 12:29:40 -08:00

painter.spec.ts

test: add painter widget e2e tests (#10599 )

2026-03-27 00:19:17 -04:00

pasteImageContextMenu.spec.ts

feat: add Paste Image option to Load Image node context menu (#10021 )

2026-03-16 07:21:05 -07:00

performance.spec.ts

test: add perf test for viewport pan sweep GC churn (#10479 )

2026-03-28 13:54:26 -07:00

primitiveNode.spec.ts

refactor: remove legacy missing nodes dialog (#10102 )

2026-03-17 11:14:44 +09:00

recordAudio.spec.ts

V2 Node Search (+ hidden Node Library changes) (#8987 )

2026-02-20 01:10:03 -08:00

releaseNotifications.spec.ts

fix: type API mock responses in browser tests (#10668 )

2026-03-29 15:45:06 +09:00

remoteWidgets.spec.ts

feat: implement NodeLibrarySidebarTabV2 with Reka UI components (#8548 )

2026-02-20 22:06:09 -08:00

rendererToggleStability.spec.ts

fix: simplify ensureCorrectLayoutScale and fix link sync during Vue node drag (#9680 )

2026-03-13 08:43:18 -07:00

rerouteNode.spec.ts

feat/fix: App mode QA updates (#9439 )

2026-03-06 20:02:19 +00:00

resultGallery.spec.ts

refactor(test): extract dialog page objects from inline getByRole usage (#10822 )

2026-04-06 09:49:32 -07:00

rightClickMenu.spec.ts

Autopan canvas when dragging nodes/links to edges (#8773 )

2026-03-19 04:12:06 -07:00

rightSidePanelTabs.spec.ts

test: E2E coverage for node search, bottom panel, focus mode, job history (#9556 )

2026-03-17 02:24:22 -07:00

saveImageAndWebp.spec.ts

fix: detect video output from data in Nodes 2.0 (#8943 )

2026-02-17 16:17:23 -08:00

selectionRectangle.spec.ts

test: E2E coverage for toasts, error overlay, selection toolbox, linear mode (#9555 )

2026-03-16 23:37:40 -07:00

selectionToolbox.spec.ts

fix: eradicate tailwind @apply usage in vue styles (#9146 )

2026-02-24 21:23:52 -08:00

selectionToolboxActions.spec.ts

test: add browser tests for selection toolbox button actions (#10764 )

2026-04-04 14:03:50 +01:00

selectionToolboxSubmenus.spec.ts

test(browser): refactor browser tests for reliability and maintainability (#8510 )

2026-02-03 12:29:40 -08:00

subgraphPromotedWidgetPanel.spec.ts

fix: resolve subgraph promoted widget panel regressions (#10648 )

2026-04-01 17:10:30 +09:00

templateFitView.spec.ts

feat: automatically fit view when loading templates (#8749 )

2026-02-20 00:37:38 -08:00

templates.spec.ts

refactor(test): extract dialog page objects from inline getByRole usage (#10822 )

2026-04-06 09:49:32 -07:00

toastNotifications.spec.ts

test: E2E coverage for toasts, error overlay, selection toolbox, linear mode (#9555 )

2026-03-16 23:37:40 -07:00

userSelectView.spec.ts

test: add Playwright test tags for filtering (@smoke, @slow, @screenshot, domains) (#8441 )

2026-01-29 16:34:56 -08:00

useSettingSearch.spec.ts

[refactor] Migrate SettingDialog to BaseModalLayout design system (#8270 )

2026-02-12 16:27:11 +09:00

versionMismatchWarnings.spec.ts

test(browser): refactor browser tests for reliability and maintainability (#8510 )

2026-02-03 12:29:40 -08:00

viewport.spec.ts

test(browser): refactor browser tests for reliability and maintainability (#8510 )

2026-02-03 12:29:40 -08:00

widget.spec.ts

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00

widgetCopyButton.spec.ts

test: add FeatureFlagHelper and QueueHelper for E2E test infrastructure (#9554 )

2026-03-16 06:51:22 -07:00

workflowPersistence.spec.ts

refactor(test): extract dialog page objects from inline getByRole usage (#10822 )

2026-04-06 09:49:32 -07:00

workflowTabThumbnail.spec.ts

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00

zoomControls.spec.ts

test: audit skipped tests — prune stale, re-enable stable, remove dead code (#10312 )

2026-03-28 13:08:52 -07:00