mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
df69d6b5d4
## Summary Add 22 automated code review check definitions and 1 strict ESLint config to `.agents/checks/` for Amp-powered code review. ## Changes - **What**: 23 files in `.agents/checks/` covering accessibility, API contracts, architecture, bug patterns, CodeRabbit integration, complexity, DDD structure, dependency/secrets scanning, doc freshness, DX/readability, ecosystem compatibility, error handling, import graph, memory leaks, pattern compliance, performance, regression risk, security, SAST, SonarJS linting, test quality, and Vue patterns. Each check includes YAML frontmatter (name, description, severity-default, tools) and repo-specific guidance tailored to ComfyUI_frontend conventions. ## Review Focus - Check definitions are config-only (no runtime code changes) - Checks reference repo-specific patterns (e.g., `useErrorHandling` composable, `useToastStore`, `es-toolkit`, Tailwind 4, Vue Composition API) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9445-feat-add-Amp-code-review-checks-31a6d73d3650817a8466fe2f4440a350) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>
1.4 KiB
1.4 KiB
name, description, severity-default, tools
| name | description | severity-default | tools | ||
|---|---|---|---|---|---|
| dx-readability | Reviews code for developer experience issues including naming clarity, cognitive complexity, dead code, and confusing patterns | low |
|
You are a developer experience reviewer. Focus on code that will confuse the next developer who reads it.
Check for:
- Unclear naming - variables/functions that don't communicate intent, abbreviations, misleading names
- Cognitive complexity - deeply nested conditions, long functions doing multiple things, complex boolean expressions
- Dead code - unreachable branches, unused variables, commented-out code, vestigial parameters
- Confusing patterns - clever tricks over simple code, implicit behavior, action-at-a-distance, surprising side effects
- Missing context - complex business logic without explaining why, non-obvious algorithms without comments
- Inconsistent abstractions - mixing raw and wrapped APIs, different error handling styles in same module
- Implicit knowledge - code that only works because of undocumented assumptions or conventions
Rules:
- Only flag things that would genuinely confuse a competent developer
- Do NOT flag established project conventions even if you'd prefer different ones
- "Minor" for things that slow comprehension, "nitpick" for pure style preferences
- Major is reserved for genuinely misleading code (names that lie, silent behavior changes)