mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-04 15:10:06 +00:00
* Implement subgraph publishing * Add missing null check * Fix subgraph blueprint display in workflows tab * Fix demotion of subgraph blueprints on reload * Update locales [skip ci] * Update blueprint def on save, cleanup * Fix skipped tracking on subgraph publish When a subgraph is first published, it previously was not added to the subgraphCache. This would cause deletion to fail until a reload occurred. * Fix failing vite tests A couple of tests that were mocking classes broke SubgraphBlueprint inheritance. Since they aren't testing anythign related to subgraph blueprints, the subgraph store is mocked as well. * Make blueprint breadcrumb badge clickable * Add confirmation for overwrite on publish * Simplify blueprint badge naming * Swap to promise.allSettled when fetching subgraphs * Navigate into subgraph on blueprint edit * Revert mission of value in blueprint breadcrumb This was causing the blueprint badge to always display * Misc code quality fixes * Set subgraphNode title on blueprint add. When a subgraph blueprint is added to the graph, the title of the subgraphNode is now set to be the title of the blueprint. NOTE: The name of the subgraph node when a blueprint is edited is left unchanged. This may cause minor user confusion. * Add "Delete Blueprint" option to breadcrumb When editing a blueprint, the options provided for the root graph of the breadcrumb included a Delete Workflow option. This still functioned for deleting the current blueprint when selected, but didn't make sense. It has been updated to instead describe that it deletes the current blueprint * Extract subgraph load code as function * Fix subgraphs appearing in library after refresh Subgraph nodes were hidden from the node library and context menu by setting skip_list to true. Unfortunately, this causes them to be mistakenly be caught and registered as vue nodes when a refresh is performed. This is fixed by adding a check for skip_list. * Add delete button and confirmation for deletion * Use more specific warning for blueprint deletion * At success toast on subgraph publish Will return later to potentially add a node library link to the toast * Don't apply subgraph context menu to normal nodes Subgraph blueprints have a right click -> delete option in the node library. This was incorrectly being dislplayed on non blueprint nodes. * Remove hardcoded subgraphs path Rather happy with this change. Rather than trying to introduce a recursive import to pass a magic string, this solution is both sufficient AND allows potential future extensions with less breakage. * Fix nodeDef update on save Wait to update the node def cache until after a blueprint has been saved. Before, changes to links weren't actually being made visisble. * Fix SaveAs with subgraph blueprints * Remove ugly serialize/deserialize Thought I had already tested this, and found that the mere existence of proxies was causing issues, but simply adding a correct annotation is sufficient now. * Improve error specificity * Framework for user defined blueprint descriptions BlueprintDescription can be added to a workflows extra field to provide more useful information about a blueprint's purpose Actually hooking this up in a way that is user accessible is out of scope for right now, but this will simplify future implementation. * Cleanup breadcrumb dropdown options Removes Dupliate for blueprints, adds a publish subgraph option. The publish subgraph button currently routes through the save as logic. Unforunately, this results in the prompt for name referencing workflows. The cleanest way to resolve this is still being considered * Move blueprint renaming into blueprint load Blueprints should automatically set the name of the added node to the filename when added. This mostly worked, but created uglier edgecases: The subgraph itself wasn't renamed, and it would need to be reimplemented to apply when editing a blueprint. Instead, this is now applied when a subgraphBlueprint is first loaded. This keeps all the logic routed through a single point * Move saveAs prompt into workflow class Ensures that the correct publish text is displayed when editing blueprints without making an awful mess of imports * Fix tests by making subgraphBlueprint internal This has the added benefit of forcing better organization. Reverts the useWorkflowThumbnail patch as it is no longer required. * Add tests for subgraph blueprints * Rewrite confirmation dialog * Fix overwrite on publish new subgraph 1 is used as a placeholder size as -1 indicates the baking userFile is temporary, not persisted, and therefore, not able to overwrite when saved. * When editing blueprint, tint background blue * Fix blueprint tint at low LOD * Set node source for blueprints to Blueprint * Fix publish test Making subgraph blueprints non temporary on publish made it so the following load actually occurs. A mock has been added for this load. * Fix multiple nits * Further cleanup: error handling, and comments * Fixing failing test cases This also moves the bg tinting to a property of the workflow, which makes things more extensible in the future. * Fix temporary marking on publish. The prior fix to allow overwrite of an existing blueprint on publish was misguided. By marking a not-yet-loaded file as non-temporary, the load performed prior to saving was actually fetching the file off disk and discarding the existing changes. This additionally entirely prevented publishing when a blueprint did not already exist with the current name. To fix this, the blueprint is not marked as non-temporary until after the load occurs. Note that this load is still required as it initializes the change tracker state required for saving. * Block unloading subgraph blueprints Will need to be revisited if lazy loading is implemented, but this requires solving some ugly sync/async issues. --------- Co-authored-by: github-actions <github-actions@github.com>
322 lines
11 KiB
TypeScript
322 lines
11 KiB
TypeScript
import { defineStore } from 'pinia'
|
|
import { computed, ref } from 'vue'
|
|
|
|
import { t } from '@/i18n'
|
|
import { SubgraphNode } from '@/lib/litegraph/src/litegraph'
|
|
import type { NodeError } from '@/schemas/apiSchema'
|
|
import type {
|
|
ComfyNode,
|
|
ComfyWorkflowJSON,
|
|
NodeId
|
|
} from '@/schemas/comfyWorkflowSchema'
|
|
import type {
|
|
ComfyNodeDef as ComfyNodeDefV1,
|
|
InputSpec
|
|
} from '@/schemas/nodeDefSchema'
|
|
import { api } from '@/scripts/api'
|
|
import { useDialogService } from '@/services/dialogService'
|
|
import { useWorkflowService } from '@/services/workflowService'
|
|
import { useExecutionStore } from '@/stores/executionStore'
|
|
import { useCanvasStore } from '@/stores/graphStore'
|
|
import { ComfyNodeDefImpl } from '@/stores/nodeDefStore'
|
|
import { useSettingStore } from '@/stores/settingStore'
|
|
import { useToastStore } from '@/stores/toastStore'
|
|
import { UserFile } from '@/stores/userFileStore'
|
|
import {
|
|
ComfyWorkflow,
|
|
LoadedComfyWorkflow,
|
|
useWorkflowStore
|
|
} from '@/stores/workflowStore'
|
|
|
|
async function confirmOverwrite(name: string): Promise<boolean | null> {
|
|
return await useDialogService().confirm({
|
|
title: t('subgraphStore.overwriteBlueprintTitle'),
|
|
type: 'overwriteBlueprint',
|
|
message: t('subgraphStore.overwriteBlueprint'),
|
|
itemList: [name]
|
|
})
|
|
}
|
|
|
|
export const useSubgraphStore = defineStore('subgraph', () => {
|
|
class SubgraphBlueprint extends ComfyWorkflow {
|
|
static override readonly basePath = 'subgraphs/'
|
|
override readonly tintCanvasBg = '#22227740'
|
|
|
|
hasPromptedSave: boolean = false
|
|
|
|
constructor(
|
|
options: { path: string; modified: number; size: number },
|
|
confirmFirstSave: boolean = false
|
|
) {
|
|
super(options)
|
|
this.hasPromptedSave = !confirmFirstSave
|
|
}
|
|
|
|
validateSubgraph() {
|
|
if (!this.activeState?.definitions)
|
|
throw new Error(
|
|
'The root graph of a subgraph blueprint must consist of only a single subgraph node'
|
|
)
|
|
const { subgraphs } = this.activeState.definitions
|
|
const { nodes } = this.activeState
|
|
//Instanceof doesn't function as nodes are serialized
|
|
function isSubgraphNode(node: ComfyNode) {
|
|
return node && subgraphs.some((s) => s.id === node.type)
|
|
}
|
|
if (nodes.length == 1 && isSubgraphNode(nodes[0])) return
|
|
const errors: Record<NodeId, NodeError> = {}
|
|
//mark errors for all but first subgraph node
|
|
let firstSubgraphFound = false
|
|
for (let i = 0; i < nodes.length; i++) {
|
|
if (!firstSubgraphFound && isSubgraphNode(nodes[i])) {
|
|
firstSubgraphFound = true
|
|
continue
|
|
}
|
|
errors[nodes[i].id] = {
|
|
errors: [],
|
|
class_type: nodes[i].type,
|
|
dependent_outputs: []
|
|
}
|
|
}
|
|
useExecutionStore().lastNodeErrors = errors
|
|
useCanvasStore().getCanvas().draw(true, true)
|
|
throw new Error(
|
|
'The root graph of a subgraph blueprint must consist of only a single subgraph node'
|
|
)
|
|
}
|
|
|
|
override async save(): Promise<UserFile> {
|
|
this.validateSubgraph()
|
|
if (
|
|
!this.hasPromptedSave &&
|
|
useSettingStore().get('Comfy.Workflow.WarnBlueprintOverwrite')
|
|
) {
|
|
if (!(await confirmOverwrite(this.filename))) return this
|
|
this.hasPromptedSave = true
|
|
}
|
|
const ret = await super.save()
|
|
useSubgraphStore().updateDef(await this.load())
|
|
return ret
|
|
}
|
|
|
|
override async saveAs(path: string) {
|
|
this.validateSubgraph()
|
|
this.hasPromptedSave = true
|
|
const ret = await super.saveAs(path)
|
|
useSubgraphStore().updateDef(await this.load())
|
|
return ret
|
|
}
|
|
override async load({
|
|
force = false
|
|
}: { force?: boolean } = {}): Promise<LoadedComfyWorkflow> {
|
|
if (!force && this.isLoaded) return await super.load({ force })
|
|
const loaded = await super.load({ force })
|
|
const st = loaded.activeState
|
|
const sg = (st.definitions?.subgraphs ?? []).find(
|
|
(sg) => sg.id == st.nodes[0].type
|
|
)
|
|
if (!sg)
|
|
throw new Error(
|
|
'Loaded subgraph blueprint does not contain valid subgraph'
|
|
)
|
|
sg.name = st.nodes[0].title = this.filename
|
|
return loaded
|
|
}
|
|
override async promptSave(): Promise<string | null> {
|
|
return await useDialogService().prompt({
|
|
title: t('subgraphStore.saveBlueprint'),
|
|
message: t('subgraphStore.blueprintName') + ':',
|
|
defaultValue: this.filename
|
|
})
|
|
}
|
|
override unload(): void {
|
|
//Skip unloading. Even if a workflow is closed after editing,
|
|
//it must remain loaded in order to be added to the graph
|
|
}
|
|
}
|
|
const subgraphCache: Record<string, LoadedComfyWorkflow> = {}
|
|
const typePrefix = 'SubgraphBlueprint.'
|
|
const subgraphDefCache = ref<Map<string, ComfyNodeDefImpl>>(new Map())
|
|
const canvasStore = useCanvasStore()
|
|
const subgraphBlueprints = computed(() => [
|
|
...subgraphDefCache.value.values()
|
|
])
|
|
async function fetchSubgraphs() {
|
|
async function loadBlueprint(options: {
|
|
path: string
|
|
modified: number
|
|
size: number
|
|
}): Promise<void> {
|
|
const name = options.path.slice(0, -'.json'.length)
|
|
options.path = SubgraphBlueprint.basePath + options.path
|
|
const bp = await new SubgraphBlueprint(options, true).load()
|
|
useWorkflowStore().attachWorkflow(bp)
|
|
const nodeDef = convertToNodeDef(bp)
|
|
|
|
subgraphDefCache.value.set(name, nodeDef)
|
|
subgraphCache[name] = bp
|
|
}
|
|
|
|
const res = (
|
|
await api.listUserDataFullInfo(SubgraphBlueprint.basePath)
|
|
).filter((f) => f.path.endsWith('.json'))
|
|
const settled = await Promise.allSettled(res.map(loadBlueprint))
|
|
const errors = settled.filter((i) => 'reason' in i).map((i) => i.reason)
|
|
errors.forEach((e) => console.error('Failed to load subgraph blueprint', e))
|
|
if (errors.length > 0) {
|
|
useToastStore().add({
|
|
severity: 'error',
|
|
summary: t('subgraphStore.loadFailure'),
|
|
detail: errors.length > 3 ? `x${errors.length}` : `${errors}`,
|
|
life: 6000
|
|
})
|
|
}
|
|
}
|
|
function convertToNodeDef(workflow: LoadedComfyWorkflow): ComfyNodeDefImpl {
|
|
const name = workflow.filename
|
|
const subgraphNode = workflow.changeTracker.initialState.nodes[0]
|
|
if (!subgraphNode) throw new Error('Invalid Subgraph Blueprint')
|
|
subgraphNode.inputs ??= []
|
|
subgraphNode.outputs ??= []
|
|
//NOTE: Types are cast to string. This is only used for input coloring on previews
|
|
const inputs = Object.fromEntries(
|
|
subgraphNode.inputs.map((i) => [
|
|
i.name,
|
|
[`${i.type}`, undefined] satisfies InputSpec
|
|
])
|
|
)
|
|
let description = 'User generated subgraph blueprint'
|
|
if (workflow.initialState.extra?.BlueprintDescription)
|
|
description = `${workflow.initialState.extra.BlueprintDescription}`
|
|
const nodedefv1: ComfyNodeDefV1 = {
|
|
input: { required: inputs },
|
|
output: subgraphNode.outputs.map((o) => `${o.type}`),
|
|
output_name: subgraphNode.outputs.map((o) => o.name),
|
|
name: typePrefix + name,
|
|
display_name: name,
|
|
description,
|
|
category: 'Subgraph Blueprints',
|
|
output_node: false,
|
|
python_module: 'blueprint'
|
|
}
|
|
const nodeDefImpl = new ComfyNodeDefImpl(nodedefv1)
|
|
return nodeDefImpl
|
|
}
|
|
async function publishSubgraph() {
|
|
const canvas = canvasStore.getCanvas()
|
|
const subgraphNode = [...canvas.selectedItems][0]
|
|
if (
|
|
canvas.selectedItems.size !== 1 ||
|
|
!(subgraphNode instanceof SubgraphNode)
|
|
)
|
|
throw new TypeError('Must have single SubgraphNode selected to publish')
|
|
|
|
const { nodes = [], subgraphs = [] } = canvas._serializeItems([
|
|
subgraphNode
|
|
])
|
|
if (nodes.length != 1) {
|
|
throw new TypeError('Must have single SubgraphNode selected to publish')
|
|
}
|
|
//create minimal workflow
|
|
const workflowData = {
|
|
revision: 0,
|
|
last_node_id: subgraphNode.id,
|
|
last_link_id: 0,
|
|
nodes,
|
|
links: [],
|
|
version: 0.4,
|
|
definitions: { subgraphs }
|
|
}
|
|
//prompt name
|
|
const name = await useDialogService().prompt({
|
|
title: t('subgraphStore.saveBlueprint'),
|
|
message: t('subgraphStore.blueprintName') + ':',
|
|
defaultValue: subgraphNode.title
|
|
})
|
|
if (!name) return
|
|
if (subgraphDefCache.value.has(name) && !(await confirmOverwrite(name)))
|
|
//User has chosen not to overwrite.
|
|
return
|
|
|
|
//upload file
|
|
const path = SubgraphBlueprint.basePath + name + '.json'
|
|
const workflow = new SubgraphBlueprint({
|
|
path,
|
|
size: -1,
|
|
modified: Date.now()
|
|
})
|
|
workflow.originalContent = JSON.stringify(workflowData)
|
|
const loadedWorkflow = await workflow.load()
|
|
//Mark non-temporary
|
|
workflow.size = 1
|
|
await workflow.save()
|
|
//add to files list?
|
|
useWorkflowStore().attachWorkflow(loadedWorkflow)
|
|
subgraphDefCache.value.set(name, convertToNodeDef(loadedWorkflow))
|
|
subgraphCache[name] = loadedWorkflow
|
|
useToastStore().add({
|
|
severity: 'success',
|
|
summary: t('subgraphStore.publishSuccess'),
|
|
detail: t('subgraphStore.publishSuccessMessage'),
|
|
life: 4000
|
|
})
|
|
}
|
|
function updateDef(blueprint: LoadedComfyWorkflow) {
|
|
subgraphDefCache.value.set(blueprint.filename, convertToNodeDef(blueprint))
|
|
}
|
|
async function editBlueprint(nodeType: string) {
|
|
const name = nodeType.slice(typePrefix.length)
|
|
if (!(name in subgraphCache))
|
|
//As loading is blocked on in startup, this can likely be changed to invalid type
|
|
throw new Error('not yet loaded')
|
|
useWorkflowStore().attachWorkflow(subgraphCache[name])
|
|
await useWorkflowService().openWorkflow(subgraphCache[name])
|
|
const canvas = useCanvasStore().getCanvas()
|
|
if (canvas.graph && 'subgraph' in canvas.graph.nodes[0])
|
|
canvas.setGraph(canvas.graph.nodes[0].subgraph)
|
|
}
|
|
function getBlueprint(nodeType: string): ComfyWorkflowJSON {
|
|
const name = nodeType.slice(typePrefix.length)
|
|
if (!(name in subgraphCache))
|
|
//As loading is blocked on in startup, this can likely be changed to invalid type
|
|
throw new Error('not yet loaded')
|
|
return subgraphCache[name].changeTracker.initialState
|
|
}
|
|
async function deleteBlueprint(nodeType: string) {
|
|
const name = nodeType.slice(typePrefix.length)
|
|
if (!(name in subgraphCache))
|
|
//As loading is blocked on in startup, this can likely be changed to invalid type
|
|
throw new Error('not yet loaded')
|
|
if (
|
|
!(await useDialogService().confirm({
|
|
title: t('subgraphStore.confirmDeleteTitle'),
|
|
type: 'delete',
|
|
message: t('subgraphStore.confirmDelete'),
|
|
itemList: [name]
|
|
}))
|
|
)
|
|
return
|
|
|
|
await subgraphCache[name].delete()
|
|
delete subgraphCache[name]
|
|
subgraphDefCache.value.delete(name)
|
|
}
|
|
function isSubgraphBlueprint(
|
|
workflow: unknown
|
|
): workflow is SubgraphBlueprint {
|
|
return workflow instanceof SubgraphBlueprint
|
|
}
|
|
|
|
return {
|
|
deleteBlueprint,
|
|
editBlueprint,
|
|
fetchSubgraphs,
|
|
getBlueprint,
|
|
isSubgraphBlueprint,
|
|
publishSubgraph,
|
|
subgraphBlueprints,
|
|
typePrefix,
|
|
updateDef
|
|
}
|
|
})
|