mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
72eed86cea
## Summary Follow-up cleanup for #11184 — removes redundant test setup calls that the `@vue-nodes` fixture now handles. ## Changes - **What**: Remove 40 lines of redundant `setSetting`, `setup()`, and `waitForNodes()` calls across 11 test files - `UseNewMenu: 'Top'` calls (already fixture default) - `setup()` + `waitForNodes()` on default workflow (fixture already does this for `@vue-nodes`) - Page reload in `subgraphZeroUuid` (fixture applies VueNodes.Enabled server-side before navigation) ## Review Focus Each removal was verified against the fixture's `setupSettings()` defaults (ComfyPage.ts:420-442) and the `@vue-nodes` auto-setup (lines 454-456). Tests that call `setup()`/`waitForNodes()` after `loadWorkflow()` or `page.evaluate()` were intentionally kept. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11195-test-remove-redundant-setup-settings-now-handled-by-vue-nodes-fixture-3416d73d36508154827df116a97e9130) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
42 lines
1.3 KiB
TypeScript
42 lines
1.3 KiB
TypeScript
import {
|
|
comfyExpect as expect,
|
|
comfyPageFixture as test
|
|
} from '@e2e/fixtures/ComfyPage'
|
|
|
|
test.describe('Widget copy button', { tag: ['@ui', '@vue-nodes'] }, () => {
|
|
test.beforeEach(async ({ comfyPage }) => {
|
|
// Add a PreviewAny node which has a read-only textarea with a copy button
|
|
await comfyPage.page.evaluate(() => {
|
|
const node = window.LiteGraph!.createNode('PreviewAny')
|
|
window.app!.graph.add(node)
|
|
})
|
|
|
|
await comfyPage.vueNodes.waitForNodes()
|
|
})
|
|
|
|
test('Copy button has correct aria-label', async ({ comfyPage }) => {
|
|
const copyButton = comfyPage.page
|
|
.locator('[data-node-id] button[aria-label]')
|
|
.filter({ has: comfyPage.page.locator('.icon-\\[lucide--copy\\]') })
|
|
.first()
|
|
await expect(copyButton).toBeAttached()
|
|
await expect(copyButton).toHaveAttribute('aria-label', /copy/i)
|
|
})
|
|
|
|
test('Copy button exists within textarea widget group container', async ({
|
|
comfyPage
|
|
}) => {
|
|
const container = comfyPage.page
|
|
.locator('[data-node-id] div.group:has(textarea[readonly])')
|
|
.first()
|
|
await expect(container).toBeVisible()
|
|
await container.hover()
|
|
await comfyPage.nextFrame()
|
|
|
|
const copyButton = container.locator('button').filter({
|
|
has: comfyPage.page.locator('.icon-\\[lucide--copy\\]')
|
|
})
|
|
await expect(copyButton.first()).toBeAttached()
|
|
})
|
|
})
|