*PR Created by the Glary-Bot Agent* --- ## Summary #11579 restored *categorical* test coverage for subgraph serialization but didn't reproduce the specific Z-Image-Turbo regression introduced by #10849 — pre-#10849 templates whose `widgets_values` is leftover noise get corrupted on load because the new code applies that array positionally to promoted widget views. This PR adds two **vitest** cases that pin the user-visible symptom directly: after loading a misaligned legacy payload, the promoted widget value should reflect the source default, not the legacy `widgets_values[i]`. Both use `it.fails` so the suite stays green while the bug is present and flips to failing the moment the fix on `fix/subgraph-promoted-widget-inline-state` lands. ## Tests 1. `falls back to source widget value when proxyWidgets is in legacy 2-tuple shape` — configure() with `proxyWidgets: [['-1', 'widget']]` + `widgets_values: [999]` should leave the widget at the source default (42), not 999. 2. `does not corrupt unbound promoted widgets when widgets_values length mismatches view count` — same shape with longer/wrong-length array. ## Verification - All 8 cases in the file pass under `it.fails` (CI green). - Removing `.fails` locally produces the expected failures: `expected 42, received 999` and `expected 42, received 111` — confirming both tests catch the regression. - `pnpm typecheck`, `pnpm exec eslint`, `pnpm exec oxlint` all clean. ## Why `it.fails` and not plain failing tests The actual fix (`fix/subgraph-promoted-widget-inline-state`) is unmerged. Landing genuinely-failing tests on main would break CI for everyone. `it.fails` documents the bug runnably, keeps CI green, and signals when the fix lands so the marker can be dropped. ## Why these assertions, not "widgets_values must be undefined" A first draft asserted that `serialize()` should not write `widgets_values` at all. That conflicts with existing coverage in the same file (`preserves per-instance widget values after configure`, `round-trips per-instance widget values`) which deliberately uses `widgets_values` for round-trip persistence. These rewritten assertions target the load-time corruption symptom directly without contradicting the per-instance contract — feedback from Oracle review. ## Coordination Mirrors the failing tests already on commit `6a982675e` of the unmerged `fix/subgraph-promoted-widget-inline-state` branch, with the addition of `.fails` markers and a clarifying comment so they can land on main first. Follow-up to #11579. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11697-test-subgraph-pin-10849-promoted-widget-value-corruption-with-it-fails-34f6d73d365081d7a04dcf48ebeceafe) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
@ComfyOrg/litegraph
This is the litegraph version used in ComfyUI_frontend.
It is a fork of the original litegraph.js. Some APIs may by unchanged, however it is largely incompatible with the original.
Some early highlights:
- Accumulated comfyUI custom changes (2024-01 ~ 2024-05) (https://github.com/Comfy-Org/litegraph.js/pull/1)
- Type schema change for ComfyUI_frontend TS migration (https://github.com/Comfy-Org/litegraph.js/pull/3)
- Zoom fix (https://github.com/Comfy-Org/litegraph.js/pull/7)
- Emit search box triggering custom events (https://github.com/Comfy-Org/litegraph.js/pull/10)
- Truncate overflowing combo widget text (https://github.com/Comfy-Org/litegraph.js/pull/17)
- Sort node based on ID on graph serialization (https://github.com/Comfy-Org/litegraph.js/pull/21)
- Fix empty input not used when connecting links (https://github.com/Comfy-Org/litegraph.js/pull/24)
- Batch output connection move/disconnect (https://github.com/Comfy-Org/litegraph.js/pull/39)
- And now with hundreds more...
Usage
This library is included as a git subtree in the ComfyUI frontend project at src/lib/litegraph.
litegraph.js
A TypeScript library to create graphs in the browser similar to Unreal Blueprints.
Description of the original litegraph.js
A library in Javascript to create graphs in the browser similar to Unreal Blueprints. Nodes can be programmed easily and it includes an editor to construct and tests the graphs.
It can be integrated easily in any existing web applications and graphs can be run without the need of the editor.
Features
- Renders on Canvas2D (zoom in/out and panning, easy to render complex interfaces, can be used inside a WebGLTexture)
- Easy to use editor (searchbox, keyboard shortcuts, multiple selection, context menu, ...)
- Optimized to support hundreds of nodes per graph (on editor but also on execution)
- Customizable theme (colors, shapes, background)
- Callbacks to personalize every action/drawing/event of nodes
- Graphs can be executed in NodeJS
- Highly customizable nodes (color, shape, widgets, custom rendering)
- Easy to integrate in any JS application (one single file, no dependencies)
- Typescript support
Integration
This library is integrated as a git subtree in the ComfyUI frontend project. To use it in your code:
import { LGraph, LGraphNode, LiteGraph } from '@/lib/litegraph'
How to code a new Node type
Here is an example of how to build a node that sums two inputs:
import { LiteGraph, LGraphNode } from './litegraph'
class MyAddNode extends LGraphNode {
// Name to show
title = 'Sum'
constructor() {
this.addInput('A', 'number')
this.addInput('B', 'number')
this.addOutput('A+B', 'number')
this.properties.precision = 1
}
// Function to call when the node is executed
onExecute() {
var A = this.getInputData(0)
if (A === undefined) A = 0
var B = this.getInputData(1)
if (B === undefined) B = 0
this.setOutputData(0, A + B)
}
}
// Register the node type
LiteGraph.registerNodeType('basic/sum', MyAddNode)
Server side
It also works server-side using NodeJS although some nodes do not work in server (audio, graphics, input, etc).
import { LiteGraph, LGraph } from './litegraph.js'
const graph = new LGraph()
const firstNode = LiteGraph.createNode('basic/sum')
graph.add(firstNode)
const secondNode = LiteGraph.createNode('basic/sum')
graph.add(secondNode)
firstNode.connect(0, secondNode, 1)
graph.start()
Projects using it
ComfyUI
Projects using the original litegraph.js
Feedback
Please open an issue on the GitHub repo.
Development
Litegraph has no runtime dependencies. The build tooling has been tested on Node.JS 20.18.x
Releasing
This library is embedded via git subtree in ComfyUI_frontend. Releases are managed through the parent repository's release process.
Contributors
You can find the current list of contributors on GitHub.
Contributors (pre-fork)
- atlasan
- kriffe
- rappestad
- InventivetalentDev
- NateScarlet
- coderofsalvation
- ilyabesk
- gausszhou




