mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-01-26 19:09:52 +00:00
## Summary Backports Firebase authentication with cloud environments. Changes only work when developing for cloud environment locally. ## Changes - Router guards to force unauthenticated users to sign in. - Configure auth headers for REST and Websocket connections. - Code implemented in a way that enables build tree-shaking based on distribution - Updates to build process to build cloud distribution and simplify development workflow ## Review Focus 1. Idomatic Vue/codebase patterns. 2. Build logic (please double check that I integrated correctly with: https://github.com/Comfy-Org/ComfyUI_frontend/blob/rh-test/vite.config.mts) ## Screenshots (if applicable) https://github.com/user-attachments/assets/ee4ea3f7-afa6-4da0-ba43-d62ed8ba4e18 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6195-Feat-cloud-auth-backport-2946d73d365081f395f5f2a89fb7d800) by [Unito](https://www.unito.io) --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: GitHub Action <action@github.com>
354 lines
9.3 KiB
TypeScript
354 lines
9.3 KiB
TypeScript
import tailwindcss from '@tailwindcss/vite'
|
|
import vue from '@vitejs/plugin-vue'
|
|
import dotenv from 'dotenv'
|
|
import { visualizer } from 'rollup-plugin-visualizer'
|
|
import { FileSystemIconLoader } from 'unplugin-icons/loaders'
|
|
import IconsResolver from 'unplugin-icons/resolver'
|
|
import Icons from 'unplugin-icons/vite'
|
|
import Components from 'unplugin-vue-components/vite'
|
|
import { defineConfig } from 'vite'
|
|
import type { UserConfig } from 'vite'
|
|
import { createHtmlPlugin } from 'vite-plugin-html'
|
|
import vueDevTools from 'vite-plugin-vue-devtools'
|
|
|
|
import { comfyAPIPlugin, generateImportMapPlugin } from './build/plugins'
|
|
|
|
dotenv.config()
|
|
|
|
const IS_DEV = process.env.NODE_ENV === 'development'
|
|
const SHOULD_MINIFY = process.env.ENABLE_MINIFY === 'true'
|
|
const ANALYZE_BUNDLE = process.env.ANALYZE_BUNDLE === 'true'
|
|
// vite dev server will listen on all addresses, including LAN and public addresses
|
|
const VITE_REMOTE_DEV = process.env.VITE_REMOTE_DEV === 'true'
|
|
const DISABLE_TEMPLATES_PROXY = process.env.DISABLE_TEMPLATES_PROXY === 'true'
|
|
const GENERATE_SOURCEMAP = process.env.GENERATE_SOURCEMAP !== 'false'
|
|
|
|
// Auto-detect cloud mode from DEV_SERVER_COMFYUI_URL
|
|
const DEV_SERVER_COMFYUI_ENV_URL = process.env.DEV_SERVER_COMFYUI_URL
|
|
const IS_CLOUD_URL = DEV_SERVER_COMFYUI_ENV_URL?.includes('.comfy.org')
|
|
|
|
const DISTRIBUTION = (process.env.DISTRIBUTION ||
|
|
(IS_CLOUD_URL ? 'cloud' : 'localhost')) as 'desktop' | 'localhost' | 'cloud'
|
|
|
|
// Disable Vue DevTools for production cloud distribution
|
|
const DISABLE_VUE_PLUGINS =
|
|
process.env.DISABLE_VUE_PLUGINS === 'true' ||
|
|
(DISTRIBUTION === 'cloud' && !IS_DEV)
|
|
|
|
const DEV_SEVER_FALLBACK_URL =
|
|
DISTRIBUTION === 'cloud'
|
|
? 'https://stagingcloud.comfy.org'
|
|
: 'http://127.0.0.1:8188'
|
|
|
|
const DEV_SERVER_COMFYUI_URL =
|
|
DEV_SERVER_COMFYUI_ENV_URL || DEV_SEVER_FALLBACK_URL
|
|
|
|
// Optional: Add API key to .env as STAGING_API_KEY if needed for cloud authentication
|
|
const addAuthHeaders = (proxy: any) => {
|
|
proxy.on('proxyReq', (proxyReq: any, _req: any, _res: any) => {
|
|
const apiKey = process.env.STAGING_API_KEY
|
|
if (apiKey) {
|
|
proxyReq.setHeader('X-API-KEY', apiKey)
|
|
}
|
|
})
|
|
}
|
|
|
|
// Cloud endpoint configuration overrides
|
|
const cloudSecureConfig =
|
|
DISTRIBUTION === 'cloud'
|
|
? {
|
|
secure: false
|
|
}
|
|
: {}
|
|
|
|
const cloudProxyConfig =
|
|
DISTRIBUTION === 'cloud'
|
|
? {
|
|
...cloudSecureConfig,
|
|
changeOrigin: true
|
|
}
|
|
: {}
|
|
|
|
const cloudProxyConfigWithAuth =
|
|
DISTRIBUTION === 'cloud'
|
|
? {
|
|
...cloudProxyConfig,
|
|
configure: addAuthHeaders
|
|
}
|
|
: {}
|
|
|
|
const BUILD_FLAGS = {
|
|
REQUIRE_SUBSCRIPTION: process.env.REQUIRE_SUBSCRIPTION === 'true'
|
|
}
|
|
|
|
export default defineConfig({
|
|
base: '',
|
|
server: {
|
|
host: VITE_REMOTE_DEV ? '0.0.0.0' : undefined,
|
|
watch: {
|
|
ignored: [
|
|
'./browser_tests/**',
|
|
'./node_modules/**',
|
|
'./tests-ui/**',
|
|
'.eslintcache',
|
|
'*.config.{ts,mts}',
|
|
'**/.git/**',
|
|
'**/.github/**',
|
|
'**/.nx/**',
|
|
'**/*.{test,spec}.ts',
|
|
'**/coverage/**',
|
|
'**/dist/**',
|
|
'**/playwright-report/**',
|
|
'**/test-results/**'
|
|
]
|
|
},
|
|
proxy: {
|
|
'/internal': {
|
|
target: DEV_SERVER_COMFYUI_URL,
|
|
...cloudProxyConfigWithAuth
|
|
},
|
|
|
|
'/api': {
|
|
target: DEV_SERVER_COMFYUI_URL,
|
|
...cloudProxyConfigWithAuth,
|
|
bypass: (req, res, _options) => {
|
|
// Return empty array for extensions API as these modules
|
|
// are not on vite's dev server.
|
|
if (req.url === '/api/extensions') {
|
|
res.end(JSON.stringify([]))
|
|
return false
|
|
}
|
|
|
|
// Bypass multi-user auth check from staging (cloud only)
|
|
if (DISTRIBUTION === 'cloud' && req.url === '/api/users') {
|
|
res.setHeader('Content-Type', 'application/json')
|
|
res.end(JSON.stringify({})) // Return empty object to simulate single-user mode
|
|
return false
|
|
}
|
|
|
|
return null
|
|
}
|
|
},
|
|
|
|
'/ws': {
|
|
target: DEV_SERVER_COMFYUI_URL,
|
|
ws: true,
|
|
...cloudProxyConfigWithAuth
|
|
},
|
|
|
|
'/workflow_templates': {
|
|
target: DEV_SERVER_COMFYUI_URL,
|
|
...cloudProxyConfigWithAuth
|
|
},
|
|
|
|
// Proxy extension assets (images/videos) under /extensions to the ComfyUI backend
|
|
'/extensions': {
|
|
target: DEV_SERVER_COMFYUI_URL,
|
|
changeOrigin: true,
|
|
...cloudSecureConfig
|
|
},
|
|
|
|
// Proxy docs markdown from backend
|
|
'/docs': {
|
|
target: DEV_SERVER_COMFYUI_URL,
|
|
changeOrigin: true,
|
|
...cloudSecureConfig
|
|
},
|
|
|
|
...(!DISABLE_TEMPLATES_PROXY
|
|
? {
|
|
'/templates': {
|
|
target: DEV_SERVER_COMFYUI_URL,
|
|
...cloudProxyConfig
|
|
}
|
|
}
|
|
: {}),
|
|
|
|
'/testsubrouteindex': {
|
|
target: 'http://localhost:5173',
|
|
rewrite: (path) => path.substring('/testsubrouteindex'.length)
|
|
}
|
|
}
|
|
},
|
|
|
|
plugins: [
|
|
...(!DISABLE_VUE_PLUGINS
|
|
? [vueDevTools(), vue(), createHtmlPlugin({})]
|
|
: [vue()]),
|
|
tailwindcss(),
|
|
comfyAPIPlugin(IS_DEV),
|
|
generateImportMapPlugin([
|
|
{
|
|
name: 'vue',
|
|
pattern: 'vue',
|
|
entry: './dist/vue.esm-browser.prod.js'
|
|
},
|
|
{
|
|
name: 'vue-i18n',
|
|
pattern: 'vue-i18n',
|
|
entry: './dist/vue-i18n.esm-browser.prod.js'
|
|
},
|
|
{
|
|
name: 'primevue',
|
|
pattern: /^primevue\/?.*/,
|
|
entry: './index.mjs',
|
|
recursiveDependence: true
|
|
},
|
|
{
|
|
name: '@primevue/themes',
|
|
pattern: /^@primevue\/themes\/?.*/,
|
|
entry: './index.mjs',
|
|
recursiveDependence: true
|
|
},
|
|
{
|
|
name: '@primevue/forms',
|
|
pattern: /^@primevue\/forms\/?.*/,
|
|
entry: './index.mjs',
|
|
recursiveDependence: true,
|
|
override: {
|
|
'@primeuix/forms': {
|
|
entry: ''
|
|
}
|
|
}
|
|
}
|
|
]),
|
|
|
|
Icons({
|
|
compiler: 'vue3',
|
|
customCollections: {
|
|
comfy: FileSystemIconLoader('packages/design-system/src/icons')
|
|
}
|
|
}),
|
|
|
|
Components({
|
|
dts: true,
|
|
resolvers: [
|
|
IconsResolver({
|
|
customCollections: ['comfy']
|
|
})
|
|
],
|
|
dirs: ['src/components', 'src/layout', 'src/views'],
|
|
deep: true,
|
|
extensions: ['vue'],
|
|
directoryAsNamespace: true
|
|
}),
|
|
|
|
// Bundle analyzer - generates dist/stats.html after build
|
|
// Only enabled when ANALYZE_BUNDLE=true
|
|
...(ANALYZE_BUNDLE
|
|
? [
|
|
visualizer({
|
|
filename: 'dist/stats.html',
|
|
open: false,
|
|
gzipSize: true,
|
|
brotliSize: true,
|
|
template: 'treemap' // or 'sunburst', 'network'
|
|
})
|
|
]
|
|
: [])
|
|
],
|
|
|
|
build: {
|
|
minify: SHOULD_MINIFY ? 'esbuild' : false,
|
|
target: 'es2022',
|
|
sourcemap: GENERATE_SOURCEMAP,
|
|
rollupOptions: {
|
|
treeshake: true,
|
|
output: {
|
|
manualChunks: (id) => {
|
|
if (!id.includes('node_modules')) {
|
|
return undefined
|
|
}
|
|
|
|
if (id.includes('primevue') || id.includes('@primeuix')) {
|
|
return 'vendor-primevue'
|
|
}
|
|
|
|
if (id.includes('@tiptap')) {
|
|
return 'vendor-tiptap'
|
|
}
|
|
|
|
if (id.includes('chart.js')) {
|
|
return 'vendor-chart'
|
|
}
|
|
|
|
if (id.includes('three') || id.includes('@xterm')) {
|
|
return 'vendor-visualization'
|
|
}
|
|
|
|
if (id.includes('/vue') || id.includes('pinia')) {
|
|
return 'vendor-vue'
|
|
}
|
|
|
|
return 'vendor-other'
|
|
}
|
|
}
|
|
}
|
|
},
|
|
|
|
esbuild: {
|
|
minifyIdentifiers: SHOULD_MINIFY,
|
|
keepNames: true,
|
|
minifySyntax: SHOULD_MINIFY,
|
|
minifyWhitespace: SHOULD_MINIFY,
|
|
pure: SHOULD_MINIFY
|
|
? [
|
|
'console.log',
|
|
'console.debug',
|
|
'console.info',
|
|
'console.trace',
|
|
'console.dir',
|
|
'console.dirxml',
|
|
'console.group',
|
|
'console.groupCollapsed',
|
|
'console.groupEnd',
|
|
'console.table',
|
|
'console.time',
|
|
'console.timeEnd',
|
|
'console.timeLog',
|
|
'console.count',
|
|
'console.countReset',
|
|
'console.profile',
|
|
'console.profileEnd',
|
|
'console.clear'
|
|
]
|
|
: []
|
|
},
|
|
|
|
test: {
|
|
globals: true,
|
|
environment: 'happy-dom',
|
|
setupFiles: ['./vitest.setup.ts']
|
|
},
|
|
|
|
define: {
|
|
__COMFYUI_FRONTEND_VERSION__: JSON.stringify(
|
|
process.env.npm_package_version
|
|
),
|
|
__SENTRY_ENABLED__: JSON.stringify(
|
|
!(process.env.NODE_ENV === 'development' || !process.env.SENTRY_DSN)
|
|
),
|
|
__SENTRY_DSN__: JSON.stringify(process.env.SENTRY_DSN || ''),
|
|
__ALGOLIA_APP_ID__: JSON.stringify(process.env.ALGOLIA_APP_ID || ''),
|
|
__ALGOLIA_API_KEY__: JSON.stringify(process.env.ALGOLIA_API_KEY || ''),
|
|
__USE_PROD_CONFIG__: process.env.USE_PROD_CONFIG === 'true',
|
|
__DISTRIBUTION__: JSON.stringify(DISTRIBUTION),
|
|
__BUILD_FLAGS__: JSON.stringify(BUILD_FLAGS),
|
|
__MIXPANEL_TOKEN__: JSON.stringify(process.env.MIXPANEL_TOKEN || '')
|
|
},
|
|
|
|
resolve: {
|
|
alias: {
|
|
'@/utils/formatUtil': '/packages/shared-frontend-utils/src/formatUtil.ts',
|
|
'@/utils/networkUtil':
|
|
'/packages/shared-frontend-utils/src/networkUtil.ts',
|
|
'@': '/src'
|
|
}
|
|
},
|
|
|
|
optimizeDeps: {
|
|
exclude: ['@comfyorg/comfyui-electron-types'],
|
|
entries: ['index.html']
|
|
}
|
|
}) satisfies UserConfig as UserConfig
|