mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-24 00:34:09 +00:00
## Summary This PR refactors the GitHub Actions workflow structure to improve reusability, maintainability, and CI performance. ## Changes ### New Actions - **setup-comfyui-server**: New composite action that handles ComfyUI server setup and launch - Checks out ComfyUI repository - Installs ComfyUI_devtools custom node - Sets up Python environment and dependencies - Optionally launches the server with configurable parameters ### Refactored Actions - **setup-frontend**: Simplified to focus only on frontend-specific tasks - Installs pnpm and Node.js - Installs dependencies - Optionally builds the frontend (can be skipped when using cached builds) - No longer handles server setup or checkout ### Workflow Improvements #### tests-ci.yaml - Introduced a setup job that builds once and caches the entire workspace - Test jobs now restore the cached workspace instead of rebuilding - Eliminated redundant setup steps in each test shard - Better separation between setup and test execution phases - Significant performance improvement through workspace caching #### Locale Update Workflows - Updated `update-locales.yaml` to use the new action structure - Updated `update-locales-for-given-custom-node-repository.yaml` with proper custom node installation - Updated `update-node-definitions-locales.yaml` to use new actions - Removed `working-directory` references where appropriate #### Other Workflows - Updated `update-playwright-expectations.yaml` to use new action structure - Consistent action usage across all workflows ## Benefits 1. **Better Performance**: Workspace caching eliminates redundant builds in CI, significantly reducing test execution time 2. **Improved Maintainability**: Clear separation of concerns makes actions easier to understand and modify 3. **Enhanced Reusability**: Actions can be composed in different ways for different workflows 4. **DRY Principle**: Eliminated code duplication across workflows 5. **Easier Debugging**: Smaller, focused actions make it easier to identify and fix issues ## Testing - [ ] Verify tests-ci workflow runs successfully - [ ] Verify locale update workflows function correctly - [ ] Verify playwright expectations update workflow works - [ ] Confirm cache/restore mechanism works as expected ## Related Issues This refactoring addresses workflow complexity and reduces CI runtime by leveraging GitHub Actions caching more effectively. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5949-refactor-Reorganize-GitHub-Actions-for-better-reusability-2846d73d365081ae8e16f151423b5a88) by [Unito](https://www.unito.io) --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: DrJKL <DrJKL0424@gmail.com>
104 lines
3.9 KiB
YAML
104 lines
3.9 KiB
YAML
# Setting test expectation screenshots for Playwright
|
|
name: Update Playwright Expectations
|
|
|
|
on:
|
|
pull_request:
|
|
types: [labeled]
|
|
issue_comment:
|
|
types: [created]
|
|
|
|
concurrency:
|
|
group: ${{ github.event.number || github.event.issue.number }}
|
|
|
|
jobs:
|
|
test:
|
|
runs-on: ubuntu-latest
|
|
if: >
|
|
( github.event_name == 'pull_request' && github.event.label.name == 'New Browser Test Expectations' ) ||
|
|
( github.event.issue.pull_request &&
|
|
github.event_name == 'issue_comment' &&
|
|
(
|
|
github.event.comment.author_association == 'OWNER' ||
|
|
github.event.comment.author_association == 'MEMBER' ||
|
|
github.event.comment.author_association == 'COLLABORATOR'
|
|
) &&
|
|
startsWith(github.event.comment.body, '/update-playwright') )
|
|
steps:
|
|
- name: Find Update Comment
|
|
uses: peter-evans/find-comment@b30e6a3c0ed37e7c023ccd3f1db5c6c0b0c23aad
|
|
id: "find-update-comment"
|
|
with:
|
|
issue-number: ${{ github.event.number || github.event.issue.number }}
|
|
comment-author: "github-actions[bot]"
|
|
body-includes: "Updating Playwright Expectations"
|
|
|
|
- name: Add Starting Reaction
|
|
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9
|
|
with:
|
|
comment-id: ${{ steps.find-update-comment.outputs.comment-id }}
|
|
issue-number: ${{ github.event.number || github.event.issue.number }}
|
|
body: |
|
|
Updating Playwright Expectations
|
|
edit-mode: replace
|
|
reactions: eyes
|
|
|
|
- name: Get Branch SHA
|
|
id: "get-branch"
|
|
run: echo ::set-output name=branch::$(gh pr view $PR_NO --repo $REPO --json headRefName --jq '.headRefName')
|
|
env:
|
|
REPO: ${{ github.repository }}
|
|
PR_NO: ${{ github.event.number || github.event.issue.number }}
|
|
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
- name: Initial Checkout
|
|
uses: actions/checkout@v5
|
|
with:
|
|
ref: ${{ steps.get-branch.outputs.branch }}
|
|
- name: Setup ComfyUI Server
|
|
uses: ./.github/actions/setup-comfyui-server
|
|
with:
|
|
launch_server: true
|
|
- name: Setup Playwright
|
|
uses: ./.github/actions/setup-playwright
|
|
- name: Run Playwright tests and update snapshots
|
|
id: playwright-tests
|
|
run: pnpm exec playwright test --update-snapshots
|
|
continue-on-error: true
|
|
- uses: actions/upload-artifact@v4
|
|
if: always()
|
|
with:
|
|
name: playwright-report
|
|
path: ./playwright-report/
|
|
retention-days: 30
|
|
- name: Debugging info
|
|
run: |
|
|
echo "PR: ${{ github.event.issue.number }}"
|
|
echo "Branch: ${{ steps.get-branch.outputs.branch }}"
|
|
git status
|
|
- name: Commit updated expectations
|
|
run: |
|
|
git config --global user.name 'github-actions'
|
|
git config --global user.email 'github-actions@github.com'
|
|
git add browser_tests
|
|
if git diff --cached --quiet; then
|
|
echo "No changes to commit"
|
|
else
|
|
git commit -m "[automated] Update test expectations"
|
|
git push origin ${{ steps.get-branch.outputs.branch }}
|
|
fi
|
|
|
|
- name: Add Done Reaction
|
|
uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9
|
|
if: github.event_name == 'issue_comment'
|
|
with:
|
|
comment-id: ${{ steps.find-update-comment.outputs.comment-id }}
|
|
issue-number: ${{ github.event.number || github.event.issue.number }}
|
|
reactions: +1
|
|
reactions-edit-mode: replace
|
|
|
|
- name: Remove New Browser Test Expectations label
|
|
if: always() && github.event_name == 'pull_request'
|
|
run: gh pr edit ${{ github.event.pull_request.number }} --remove-label "New Browser Test Expectations"
|
|
env:
|
|
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|