mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-05-18 11:30:39 +00:00
c671a33182
## Summary Removes hardcoded `version: 10` from `pnpm/action-setup` and instead injects the `packageManager` field into `package.json` when absent (legacy `core/*` branches). ## Why PR #10952 re-added `version: 10` to fix old branches lacking `packageManager`. But `main` now has **both** `version: 10` (workflow) and `packageManager: pnpm@10.33.0` (`package.json`), causing `pnpm/action-setup` to error with: > Multiple versions of pnpm specified Failed run: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/24158869559 This fix handles both cases: - **`main`**: has `packageManager` → action reads it directly, no conflict - **`core/1.42` etc**: missing `packageManager` → step injects it before the action runs E2E test not applicable — this is a CI workflow configuration change with no user-facing behavior. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10972-fix-ci-resolve-pnpm-version-conflict-in-version-bump-workflow-33c6d73d36508112802df75c0dd5ea50) by [Unito](https://www.unito.io)
GitHub Workflows
Naming Convention
Workflow files follow a consistent naming pattern: <prefix>-<descriptive-name>.yaml
Category Prefixes
| Prefix | Purpose | Example |
|---|---|---|
ci- |
Testing, linting, validation | ci-tests-e2e.yaml |
release- |
Version management, publishing | release-version-bump.yaml |
pr- |
PR automation (triggered by labels) | pr-claude-review.yaml |
api- |
External Api type generation | api-update-registry-api-types.yaml |
i18n- |
Internationalization updates | i18n-update-core.yaml |
Documentation
Each workflow file contains comments explaining its purpose, triggers, and behavior. For specific details about what each workflow does, refer to the comments at the top of each .yaml file.
For GitHub Actions documentation, see Events that trigger workflows.